From: "Maxin B. John" <maxin.john@gmail.com>
To: linux-raid@vger.kernel.org
Cc: "Maxin B. John" <maxin.john@intel.com>
Subject: [PATCH 3/3][mdadm] Monitor.c: fix compiler error with x32 toolchain
Date: Sat, 6 Feb 2016 00:28:18 +0200 [thread overview]
Message-ID: <1454711298-32524-3-git-send-email-maxin.john@gmail.com> (raw)
In-Reply-To: <1454711298-32524-1-git-send-email-maxin.john@gmail.com>
From: "Maxin B. John" <maxin.john@intel.com>
With x32 toolchain, this code caused the below listed error:
| Monitor.c: In function 'check_array':
| Monitor.c:545:16: error: comparison between signed and unsigned
integer expressions [-Werror=sign-compare]
| if (st->utime == array.utime &&
Signed-off-by: Maxin B. John <maxin.john@intel.com>
---
Monitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Monitor.c b/Monitor.c
index f19c2e5..748d61b 100644
--- a/Monitor.c
+++ b/Monitor.c
@@ -542,7 +542,7 @@ static int check_array(struct state *st, struct mdstat_ent *mdstat,
alert("NewArray", st->devname, NULL, ainfo);
}
- if (st->utime == array.utime &&
+ if ((unsigned long)st->utime == array.utime &&
st->failed == array.failed_disks &&
st->working == array.working_disks &&
st->spare == array.spare_disks &&
--
2.1.4
next prev parent reply other threads:[~2016-02-05 22:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 22:28 [PATCH 1/3][mdadm] util.c: include poll.h instead of sys/poll.h Maxin B. John
2016-02-05 22:28 ` [PATCH 2/3][mdadm] mdadm.h: bswap is already defined in uclibc Maxin B. John
2016-02-08 16:00 ` Jes Sorensen
2016-02-08 16:10 ` Maxin B. John
2016-02-10 19:20 ` Jes Sorensen
2016-02-11 11:26 ` Maxin B. John
2016-02-05 22:28 ` Maxin B. John [this message]
2016-02-06 1:17 ` [PATCH 3/3][mdadm] Monitor.c: fix compiler error with x32 toolchain Xiao Ni
2016-02-06 5:27 ` Maxin B. John
2016-02-08 15:59 ` [PATCH 1/3][mdadm] util.c: include poll.h instead of sys/poll.h Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454711298-32524-3-git-send-email-maxin.john@gmail.com \
--to=maxin.john@gmail.com \
--cc=linux-raid@vger.kernel.org \
--cc=maxin.john@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.