From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de
Cc: konrad.wilk@oracle.com, rusty@rustcorp.com.au,
luto@amacapital.net, boris.ostrovsky@oracle.com, mcb30@ipxe.org,
jgross@suse.com, JBeulich@suse.com, joro@8bytes.org,
ryabinin.a.a@gmail.com, long.wanglong@huawei.com,
qiuxishi@huawei.com, aryabinin@virtuozzo.com,
mchehab@osg.samsung.com, x86@kernel.org,
xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org,
"Luis R. Rodriguez" <mcgrof@kernel.org>
Subject: [PATCH v2] x86/boot: add BIT() to boot/bitops.h
Date: Fri, 5 Feb 2016 20:49:35 -0800 [thread overview]
Message-ID: <1454734175-15328-1-git-send-email-mcgrof@kernel.org> (raw)
The boot/bitops.h has guards against including the
regular bitops (include/asm-generic/bitops.h), it only
implements what we need at early boot. We'll be making
use of BIT() later so add it.
Users of boot/boot.h must include it prior to asm/setup.h
otherwise the guard protection devised against the regular
linux/bitops.h will not take effect.
v2: spelling fixes, and language descriptipon enhancements
by Konrad.
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
This patch is originally part of a much larger series [0],
this is v2 of the original patch 3/8 [1]. I've split this single
patch out on its own now that it should be clear how I intend
on using BIT() on early code.
[0] http://lkml.kernel.org/r/1450217797-19295-1-git-send-email-mcgrof@do-not-panic.com
[1] http://lkml.kernel.org/r/1450217797-19295-4-git-send-email-mcgrof@do-not-panic.com
arch/x86/boot/bitops.h | 2 ++
arch/x86/boot/boot.h | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/x86/boot/bitops.h b/arch/x86/boot/bitops.h
index 878e4b9940d9..232cff0ff4e3 100644
--- a/arch/x86/boot/bitops.h
+++ b/arch/x86/boot/bitops.h
@@ -40,4 +40,6 @@ static inline void set_bit(int nr, void *addr)
asm("btsl %1,%0" : "+m" (*(u32 *)addr) : "Ir" (nr));
}
+#define BIT(x) (1 << x)
+
#endif /* BOOT_BITOPS_H */
diff --git a/arch/x86/boot/boot.h b/arch/x86/boot/boot.h
index 9011a88353de..4fb53da1f48a 100644
--- a/arch/x86/boot/boot.h
+++ b/arch/x86/boot/boot.h
@@ -23,8 +23,8 @@
#include <stdarg.h>
#include <linux/types.h>
#include <linux/edd.h>
-#include <asm/setup.h>
#include "bitops.h"
+#include <asm/setup.h>
#include "ctype.h"
#include "cpuflags.h"
--
2.7.0
next reply other threads:[~2016-02-06 4:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-06 4:49 Luis R. Rodriguez [this message]
2016-02-12 21:26 ` [PATCH v2] x86/boot: add BIT() to boot/bitops.h Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454734175-15328-1-git-send-email-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=JBeulich@suse.com \
--cc=aryabinin@virtuozzo.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=joro@8bytes.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=long.wanglong@huawei.com \
--cc=luto@amacapital.net \
--cc=mcb30@ipxe.org \
--cc=mchehab@osg.samsung.com \
--cc=mingo@redhat.com \
--cc=qiuxishi@huawei.com \
--cc=rusty@rustcorp.com.au \
--cc=ryabinin.a.a@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.