From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Marcel Apfelbaum <marcel.a@redhat.com>,
Laszlo Ersek <lersek@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH 2/4] pc/q35: drop compatiility with old bios types
Date: Sun, 7 Feb 2016 12:29:39 +0200 [thread overview]
Message-ID: <1454840944-29299-3-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1454840944-29299-1-git-send-email-mst@redhat.com>
We don't ship bios without support for loading ACPI anymore, and old q35
machine types don't allow migrating such bios. Drop it, as well as
has_*mr flags that are there for migration compatibility.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/i386/pc_q35.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index 208a224..22a0fdc 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -116,10 +116,6 @@ static void pc_q35_init(MachineState *machine)
}
pc_cpus_init(pcms);
- if (!pcmc->has_acpi_build) {
- /* only machine types 1.7 & older need this */
- pc_acpi_init("q35-acpi-dsdt.aml");
- }
kvmclock_create();
@@ -435,7 +431,6 @@ static void pc_q35_1_7_machine_options(MachineClass *m)
pc_q35_2_0_machine_options(m);
m->hw_version = "1.7.0";
m->default_machine_opts = NULL;
- m->option_rom_has_mr = true;
SET_MACHINE_COMPAT(m, PC_COMPAT_1_7);
pcmc->smbios_defaults = false;
pcmc->gigabyte_align = false;
@@ -447,12 +442,9 @@ DEFINE_Q35_MACHINE(v1_7, "pc-q35-1.7", pc_compat_1_7,
static void pc_q35_1_6_machine_options(MachineClass *m)
{
- PCMachineClass *pcmc = PC_MACHINE_CLASS(m);
pc_q35_machine_options(m);
m->hw_version = "1.6.0";
- m->rom_file_has_mr = false;
SET_MACHINE_COMPAT(m, PC_COMPAT_1_6);
- pcmc->has_acpi_build = false;
}
DEFINE_Q35_MACHINE(v1_6, "pc-q35-1.6", pc_compat_1_6,
--
MST
next prev parent reply other threads:[~2016-02-07 10:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-07 10:29 [Qemu-devel] [PATCH 0/4] pc: drop AML files Michael S. Tsirkin
2016-02-07 10:29 ` [Qemu-devel] [PATCH 1/4] pc/piix: drop acpi-dsdt.aml Michael S. Tsirkin
2016-02-07 10:29 ` Michael S. Tsirkin [this message]
2016-02-15 10:58 ` [Qemu-devel] [PATCH 2/4] pc/q35: drop compatiility with old bios types Gerd Hoffmann
2016-02-15 11:30 ` Michael S. Tsirkin
2016-02-15 15:20 ` Eduardo Habkost
2016-02-15 14:16 ` Markus Armbruster
2016-02-07 10:29 ` [Qemu-devel] [PATCH 3/4] pc/q35: drop dsdt aml Michael S. Tsirkin
2016-02-07 10:29 ` [Qemu-devel] [PATCH 4/4] configure: don't install aml links Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454840944-29299-3-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jsnow@redhat.com \
--cc=lersek@redhat.com \
--cc=marcel.a@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.