From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48150) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSW2l-0003rF-4r for qemu-devel@nongnu.org; Sun, 07 Feb 2016 15:34:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSW2h-00077Z-P5 for qemu-devel@nongnu.org; Sun, 07 Feb 2016 15:34:51 -0500 From: =?UTF-8?q?Herv=C3=A9=20Poussineau?= Date: Sun, 7 Feb 2016 21:34:05 +0100 Message-Id: <1454877256-22138-3-git-send-email-hpoussin@reactos.org> In-Reply-To: <1454877256-22138-1-git-send-email-hpoussin@reactos.org> References: <1454877256-22138-1-git-send-email-hpoussin@reactos.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v2 02/13] cuda: move unknown commands reject out of switch List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Alyssa Milburn , Mark Cave-Ayland , Alexander Graf , =?UTF-8?q?Herv=C3=A9=20Poussineau?= Signed-off-by: Herv=C3=A9 Poussineau --- hw/misc/macio/cuda.c | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/hw/misc/macio/cuda.c b/hw/misc/macio/cuda.c index 8659dc3..81e34e7 100644 --- a/hw/misc/macio/cuda.c +++ b/hw/misc/macio/cuda.c @@ -590,15 +590,15 @@ static void cuda_receive_packet(CUDAState *s, } } cuda_send_packet_to_host(s, obuf, 3); - break; + return; case CUDA_GET_6805_ADDR: cuda_send_packet_to_host(s, obuf, 3); - break; + return; case CUDA_SET_TIME: ti =3D (((uint32_t)data[1]) << 24) + (((uint32_t)data[2]) << 16)= + (((uint32_t)data[3]) << 8) + data[4]; s->tick_offset =3D ti - (qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) /= get_ticks_per_sec()); cuda_send_packet_to_host(s, obuf, 3); - break; + return; case CUDA_GET_TIME: ti =3D s->tick_offset + (qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) /= get_ticks_per_sec()); obuf[3] =3D ti >> 24; @@ -606,28 +606,28 @@ static void cuda_receive_packet(CUDAState *s, obuf[5] =3D ti >> 8; obuf[6] =3D ti; cuda_send_packet_to_host(s, obuf, 7); - break; + return; case CUDA_FILE_SERVER_FLAG: case CUDA_SET_DEVICE_LIST: case CUDA_SET_AUTO_RATE: case CUDA_SET_POWER_MESSAGES: cuda_send_packet_to_host(s, obuf, 3); - break; + return; case CUDA_POWERDOWN: cuda_send_packet_to_host(s, obuf, 3); qemu_system_shutdown_request(); - break; + return; case CUDA_RESET_SYSTEM: cuda_send_packet_to_host(s, obuf, 3); qemu_system_reset_request(); - break; + return; case CUDA_COMBINED_FORMAT_IIC: obuf[0] =3D ERROR_PACKET; obuf[1] =3D 0x5; obuf[2] =3D CUDA_PACKET; obuf[3] =3D data[0]; cuda_send_packet_to_host(s, obuf, 4); - break; + return; case CUDA_GET_SET_IIC: if (len =3D=3D 4) { cuda_send_packet_to_host(s, obuf, 3); @@ -638,15 +638,17 @@ static void cuda_receive_packet(CUDAState *s, obuf[3] =3D data[0]; cuda_send_packet_to_host(s, obuf, 4); } - break; + return; default: - obuf[0] =3D ERROR_PACKET; - obuf[1] =3D 0x2; - obuf[2] =3D CUDA_PACKET; - obuf[3] =3D data[0]; - cuda_send_packet_to_host(s, obuf, 4); break; } + + qemu_log_mask(LOG_GUEST_ERROR, "CUDA: unknown command 0x%02x\n", dat= a[0]); + obuf[0] =3D ERROR_PACKET; + obuf[1] =3D 0x2; /* unknown command */ + obuf[2] =3D CUDA_PACKET; + obuf[3] =3D data[0]; + cuda_send_packet_to_host(s, obuf, 4); } =20 static void cuda_receive_packet_from_host(CUDAState *s, --=20 2.1.4