From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v5 for Xen 4.7 2/4] libxc: enable per-VCPU
 parameter settings for RTDS scheduler
Date: Tue, 9 Feb 2016 19:20:35 +0100
Message-ID: <1455042035.3148.106.camel@citrix.com>
References: <1454626244-5511-1-git-send-email-lichong659@gmail.com>
	<1454626244-5511-3-git-send-email-lichong659@gmail.com>
	<20160205140900.GZ23178@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0249527205881848454=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20160205140900.GZ23178@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>, Chong Li <lichong659@gmail.com>
Cc: Chong Li <chong.li@wustl.edu>, Sisu Xi <xisisu@gmail.com>, george.dunlap@eu.citrix.com, xen-devel@lists.xen.org, Meng Xu <mengxu@cis.upenn.edu>, dgolomb@seas.upenn.edu
List-Id: xen-devel@lists.xenproject.org

--===============0249527205881848454==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-AwyuMbpBl2fgLfLvWbid"

--=-AwyuMbpBl2fgLfLvWbid
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2016-02-05 at 14:09 +0000, Wei Liu wrote:
> On Thu, Feb 04, 2016 at 04:50:42PM -0600, Chong Li wrote:
> > Add xc_sched_rtds_vcpu_get/set functions to interact with
> > Xen to get/set a domain's per-VCPU parameters.
> >=20
> > Signed-off-by: Chong Li <chong.li@wustl.edu>
> > Signed-off-by: Meng Xu <mengxu@cis.upenn.edu>
> > Signed-off-by: Sisu Xi <xisisu@gmail.com>
>=20
> These looks like sensible wrappers. I will defer this patch to Dario.
> If
> he's happy with this I will just ack it.
>=20
They seem fine to me as well.

However, as said when reviewing patch 1, I'd like to see an attempt for
these hypercalls to be dealt with in the same way as
XEN_SYSCTL_pcitopoinfo is.

If doing that, these wrappers need to be changed accordingly.

Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-AwyuMbpBl2fgLfLvWbid
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEABECAAYFAla6LfMACgkQk4XaBE3IOsRrHACdH2B59KJCV4ANZZgYsLdhO1xm
GFsAnAxZhu7Ob21wi1ktxU5fyl1+zkh6
=6fIl
-----END PGP SIGNATURE-----

--=-AwyuMbpBl2fgLfLvWbid--


--===============0249527205881848454==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============0249527205881848454==--