From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756071AbcBIXxN (ORCPT ); Tue, 9 Feb 2016 18:53:13 -0500 Received: from smtprelay0120.hostedemail.com ([216.40.44.120]:56023 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755801AbcBIXxL (ORCPT ); Tue, 9 Feb 2016 18:53:11 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:4321:5007:6261:6691:7514:10004:10400:10848:11232:11658:11783:11914:12043:12517:12519:12555:12679:12740:13018:13019:13069:13311:13357:13894:13972:14659:21080:30051:30054:30080:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: hat23_8ffd6195ca104 X-Filterd-Recvd-Size: 2253 Message-ID: <1455061988.3333.5.camel@perches.com> Subject: Re: [PATCH] x86/kernel: use pr_() and dev_ From: Joe Perches To: Ingo Molnar , Chen Yucong Cc: tglx@linutronix.de, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org Date: Tue, 09 Feb 2016 15:53:08 -0800 In-Reply-To: <20160209095749.GA2953@gmail.com> References: <1454666121-14972-1-git-send-email-slaoub@gmail.com> <20160209095749.GA2953@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.3-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-02-09 at 10:57 +0100, Ingo Molnar wrote: > * Chen Yucong wrote: > > > arch/x86/kernel/* use a mixture of printk(KERN_ ) and pr_(). > > This patch converts the bulk of printk(KERN_ ) to pr_() and > > uses dev_dbg() instead of the dev_printk(KERN_DEBUG,). All pr_warning() > > calls have been replaced with pr_warn(). > > > > Not sure what to do about the printk(KERN_DEFAULT) and printk() without a > > log level. > > > > Signed-off-by: Chen Yucong > > When converting please also join broken up format strings, such as: > > -               printk(KERN_WARNING PREFIX > -                      "HPET id: %#x base: 0xfed0000000000000 fixed up " > -                      "to 0xfed00000.\n", hpet_tbl->id); > +               pr_warn(PREFIX "HPET id: %#x base: 0xfed0000000000000 fixed up " > +                       "to 0xfed00000.\n", hpet_tbl->id); > > ignore checkpatch: we don't line-break user visible strings. Umm, checkpatch already suggests to coalesce split strings. ie: WARNING: quoted string split across lines #850: FILE: arch/x86/kernel/hpet.c:850: +        "HPET config register value = 0xFFFFFFFF. " +        "Disabling HPET\n"); and checkpatch does the fixing using something like: $ ./scripts/checkpatch.pl -f --fix-inplace --types=split_string arch/x86/kernel/hpet.c