From mboxrd@z Thu Jan 1 00:00:00 1970 From: joe@perches.com (Joe Perches) Date: Tue, 09 Feb 2016 15:56:47 -0800 Subject: [Cocci] coccinelle: add style check for assignment in if In-Reply-To: <56B9E1C2.7070008@users.sourceforge.net> References: <1454935571-4054-1-git-send-email-kborer@gmail.com> <56B9A2F6.4040109@users.sourceforge.net> <56B9E1C2.7070008@users.sourceforge.net> Message-ID: <1455062207.3333.6.camel@perches.com> To: cocci@systeme.lip6.fr List-Id: cocci@systeme.lip6.fr On Tue, 2016-02-09 at 13:55 +0100, SF Markus Elfring wrote: > > > Would you like to consider also the reuse of SmPL variables > > > like "org" and "report"? > > > > I think that there is no point for these things, because checkpatch > > already gives warnings about this issue. > > Can the check result display be more convenient from the semantic > patch script interface in comparison to the other tool? -ENOPARSE. ?More detail please. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754700AbcBIX4y (ORCPT ); Tue, 9 Feb 2016 18:56:54 -0500 Received: from smtprelay0242.hostedemail.com ([216.40.44.242]:34551 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753115AbcBIX4w (ORCPT ); Tue, 9 Feb 2016 18:56:52 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:2840:3138:3139:3140:3141:3142:3350:3622:3865:3866:3867:3868:3870:3871:3873:3874:4321:5007:6117:6261:10004:10400:10848:11232:11658:11914:12517:12519:12740:13069:13311:13357:13894:14659:21080:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: paint24_1eaae2869f036 X-Filterd-Recvd-Size: 1561 Message-ID: <1455062207.3333.6.camel@perches.com> Subject: Re: coccinelle: add style check for assignment in if From: Joe Perches To: SF Markus Elfring , Julia Lawall Cc: Kris Borer , Michal Marek , Gilles Muller , Nicolas Palix , linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr Date: Tue, 09 Feb 2016 15:56:47 -0800 In-Reply-To: <56B9E1C2.7070008@users.sourceforge.net> References: <1454935571-4054-1-git-send-email-kborer@gmail.com> <56B9A2F6.4040109@users.sourceforge.net> <56B9E1C2.7070008@users.sourceforge.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.3-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-02-09 at 13:55 +0100, SF Markus Elfring wrote: > > > Would you like to consider also the reuse of SmPL variables > > > like "org" and "report"? > > > > I think that there is no point for these things, because checkpatch > > already gives warnings about this issue. > > Can the check result display be more convenient from the semantic > patch script interface in comparison to the other tool? -ENOPARSE.  More detail please.