From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH] libxc: Fix CID 1351225 resource leak Date: Wed, 10 Feb 2016 10:28:05 +0100 Message-ID: <1455096485.3148.168.camel@citrix.com> References: <1455095279-3070-1-git-send-email-write.harmandeep@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2680648177147356415==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aTR4G-0001dx-P6 for xen-devel@lists.xenproject.org; Wed, 10 Feb 2016 09:28:12 +0000 In-Reply-To: <1455095279-3070-1-git-send-email-write.harmandeep@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Harmandeep Kaur , xen-devel@lists.xenproject.org Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org --===============2680648177147356415== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-LtLwwFS5QXVAhpq/Pk4Z" --=-LtLwwFS5QXVAhpq/Pk4Z Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Harmandeep, Thanks for this patch. On Wed, 2016-02-10 at 14:37 +0530, Harmandeep Kaur wrote: > In general, I think it would be best if the subject is a bit more "explicative", and if you add a few words of changelog, here, above the S-o-b. In this case, this could be something like this. Subject: "libxc: fix leak in xc_offline_page error path" Changelog: " Avoid leaking the mapping of the m2p in one of the possible failure cases. Coverity CID 1351225 " > Signed-off-by: Harmandeep Kaur > That being said, this case is very simple, so I'll leave it to the tools maintainers to tell whether they want something like what I described above in place or not. The code looks ok to me, so, with or without the subject/changelog improvements: Reviewed-by: Dario Faggioli Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-LtLwwFS5QXVAhpq/Pk4Z Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAla7AqUACgkQk4XaBE3IOsRWugCfSRuFYXq76JK6/7PHPj5BWiQx YkwAnRQlHrcHhGNxwIvc7CSdBpHGsW9o =hNMK -----END PGP SIGNATURE----- --=-LtLwwFS5QXVAhpq/Pk4Z-- --===============2680648177147356415== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2680648177147356415==--