From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] libxc: Fix CID 1351225 resource leak
Date: Wed, 10 Feb 2016 09:48:54 +0000
Message-ID: <1455097734.19857.128.camel@citrix.com>
References: <1455095279-3070-1-git-send-email-write.harmandeep@gmail.com>
	<1455096485.3148.168.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=841e7c5e8=Ian.Campbell@citrix.com>)
	id 1aTROM-00035K-02
	for xen-devel@lists.xenproject.org; Wed, 10 Feb 2016 09:48:58 +0000
In-Reply-To: <1455096485.3148.168.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Dario Faggioli <dario.faggioli@citrix.com>, Harmandeep Kaur <write.harmandeep@gmail.com>, xen-devel@lists.xenproject.org
Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On Wed, 2016-02-10 at 10:28 +0100, Dario Faggioli wrote:
> Hi Harmandeep,
> 
> Thanks for this patch.
> 
> On Wed, 2016-02-10 at 14:37 +0530, Harmandeep Kaur wrote:
> > 
> In general, I think it would be best if the subject is a bit more
> "explicative", and if you add a few words of changelog, here, above the
> S-o-b.
> 
> In this case, this could be something like this.
> 
> Subject: "libxc: fix leak in xc_offline_page error path"
> 
> Changelog: "
> Avoid leaking the mapping of the m2p in one of the possible failure
> cases.
> 
> Coverity CID 1351225
> "
> 
> > Signed-off-by: Harmandeep Kaur <write.harmandeep@gmail.com>
> > 
> That being said, this case is very simple, so I'll leave it to the
> tools maintainers to tell whether they want something like what I
> described above in place or not.

I was going to comment the same, so yes please. The subject and commit
message should describe the actual change and the CID should simply be
referenced as Dario has in his example.

> 
> The code looks ok to me, so, with or without the subject/changelog
> improvements:
> 
> Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
> 
> Regards,
> Dario