Re: [PATCH] libxc: Fix CID 1351228 resource leak

[Ian Campbell <ian.campbell@citrix.com>]

On Wed, 2016-02-10 at 11:14 +0000, Ian Jackson wrote:
> Dario Faggioli writes ("Re: [PATCH] libxc: Fix CID 1351228 resource
> leak"):
> > On Wed, 2016-02-10 at 14:39 +0530, Harmandeep Kaur wrote:
> > > 
> > What I just said about the other patch ("libxc: Fix CID 1351225
> > resource leak") applies here as well, of course. :-)
> > 
> > About the code...
> ...
> > >      if ( t_info == NULL || t_info->tbuf_size == 0 )
> > > +    {
> > > +        xenforeignmemory_unmap(xch->fmem, t_info, 0);
> > >          return -1;
> > > +    }
> > >  
> > >      *size = t_info->tbuf_size;
> > > +    xenforeignmemory_unmap(xch->fmem, t_info, *size);
> ...
> > I think you can arrange for only calling the unmapping function once,
> > i.e., put the unmap call in a place where (after a slight
> > reorganization of the rest of the code as well) it can be common to
> > both the success and error path.
> 
> Indeed.  See tools/libxl/CODING_STYLE.

The code being modified here is in libxc, so strictly speaking this doesn't
apply. However it is still a good principal to obey.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel