From: Harmandeep Kaur <write.harmandeep@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: wei.liu2@citrix.com, ian.campbell@citrix.com,
stefano.stabellini@eu.citrix.com, dario.faggioli@citrix.com,
ian.jackson@eu.citrix.com,
Harmandeep Kaur <write.harmandeep@gmail.com>
Subject: [PATCH v2] libxc: fix leak of t_info in xc_tbuf_get_size()
Date: Thu, 11 Feb 2016 14:02:59 +0530 [thread overview]
Message-ID: <1455179579-3476-1-git-send-email-write.harmandeep@gmail.com> (raw)
Avoid leaking the memory mapping of the trace buffer
Coverity ID 1351228
Signed-off-by: Harmandeep Kaur <write.harmandeep@gmail.com>
---
v2: call to unmapping function reduced to one from two
---
tools/libxc/xc_tbuf.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/tools/libxc/xc_tbuf.c b/tools/libxc/xc_tbuf.c
index 695939a..d96cc67 100644
--- a/tools/libxc/xc_tbuf.c
+++ b/tools/libxc/xc_tbuf.c
@@ -70,11 +70,13 @@ int xc_tbuf_get_size(xc_interface *xch, unsigned long *size)
sysctl.u.tbuf_op.buffer_mfn);
if ( t_info == NULL || t_info->tbuf_size == 0 )
- return -1;
+ rc = -1;
+ else
+ *size = t_info->tbuf_size;
- *size = t_info->tbuf_size;
+ xenforeignmemory_unmap(xch->fmem, t_info, *size);
- return 0;
+ return rc;
}
int xc_tbuf_enable(xc_interface *xch, unsigned long pages, unsigned long *mfn,
--
2.5.0
next reply other threads:[~2016-02-11 8:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 8:32 Harmandeep Kaur [this message]
2016-02-11 9:14 ` [PATCH v2] libxc: fix leak of t_info in xc_tbuf_get_size() Dario Faggioli
2016-02-11 9:52 ` Ian Campbell
2016-02-11 10:03 ` Dario Faggioli
2016-02-11 10:11 ` Ian Campbell
2016-02-11 10:23 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455179579-3476-1-git-send-email-write.harmandeep@gmail.com \
--to=write.harmandeep@gmail.com \
--cc=dario.faggioli@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.