From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 1/2] xenmon: close qos_fd when finished with it in alloc_qos_data Date: Thu, 11 Feb 2016 15:38:20 +0000 Message-ID: <1455205100.814.69.camel@citrix.com> References: <1455121585-22659-1-git-send-email-ian.campbell@citrix.com> <20160211111828.GD17384@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160211111828.GD17384@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Thu, 2016-02-11 at 11:18 +0000, Wei Liu wrote: > On Wed, Feb 10, 2016 at 04:26:24PM +0000, Ian Campbell wrote: > > Otherwise the fd is leaked. NB the mmap'd memory in the global > > cpu_qos_data[n] is not affected by closing the underlying fd. > > > > Compile tested only. > > > > CID: 1055930 > > > > Signed-off-by: Ian Campbell > > Acked-by: Wei Liu Applied both, thanks.