diff for duplicates of <1455251535.13149.7.camel@perches.com> diff --git a/a/1.txt b/N1/1.txt index e026694..94adff1 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -6,9 +6,9 @@ On Thu, 2016-02-11 at 20:07 -0800, Shaun Ren wrote: > diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c [] > @@ -52,12 +55,14 @@ unsigned int rtsx_stor_access_xfer_buf(unsigned char *buffer, -> ? if (*offset >= scsi_bufflen(srb)) -> ? return 0; -> ? cnt = min(buflen, scsi_bufflen(srb) - *offset); +> if (*offset >= scsi_bufflen(srb)) +> return 0; +> cnt = min(buflen, scsi_bufflen(srb) - *offset); > + > + unsigned char *sgbuffer = (unsigned char *)scsi_sglist(srb) + > + *offset; @@ -17,12 +17,12 @@ Please don't declare variables in the middle of functions. Variable declarations are only done at the beginning of functions. > + -> ? if (dir == TO_XFER_BUF) +> if (dir == TO_XFER_BUF) > - memcpy((unsigned char *) scsi_sglist(srb) + *offset, > - buffer, cnt); > + memcpy(sgbuffer, buffer, cnt); -> ? else +> else > - memcpy(buffer, (unsigned char *) scsi_sglist(srb) + > - *offset, cnt); > + memcpy(buffer, sgbuffer, cnt); -> ? *offset += cnt; +> *offset += cnt; diff --git a/a/content_digest b/N1/content_digest index 45023c0..307f190 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,10 +1,19 @@ "ref\01455072328-7033-1-git-send-email-shaun.ren@linux.com\0" "ref\01455250080-9897-1-git-send-email-shaun.ren@linux.com\0" "ref\01455250080-9897-3-git-send-email-shaun.ren@linux.com\0" - "From\0joe@perches.com (Joe Perches)\0" - "Subject\0[PATCH v4 2/8] Staging: rts5208: rtsx_transport.c: Align to open parenthesis\0" + "From\0Joe Perches <joe@perches.com>\0" + "Subject\0Re: [PATCH v4 2/8] Staging: rts5208: rtsx_transport.c: Align to open parenthesis\0" "Date\0Thu, 11 Feb 2016 20:32:15 -0800\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Shaun Ren <shaun.ren@linux.com>" + gregkh@linuxfoundation.org + " rjui@broadcom.com\0" + "Cc\0sbranden@broadcom.com" + jonmason@broadcom.com + mahfouz.saif.elyazal@gmail.com + devel@driverdev.osuosl.org + linux-arm-kernel@lists.infradead.org + bcm-kernel-feedback-list@broadcom.com + " linux-kernel@vger.kernel.org\0" "\00:1\0" "b\0" "On Thu, 2016-02-11 at 20:07 -0800, Shaun Ren wrote:\n" @@ -15,9 +24,9 @@ "> diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c\n" "[]\n" "> @@ -52,12 +55,14 @@ unsigned int rtsx_stor_access_xfer_buf(unsigned char *buffer,\n" - "> ?\t\tif (*offset >= scsi_bufflen(srb))\n" - "> ?\t\t\treturn 0;\n" - "> ?\t\tcnt = min(buflen, scsi_bufflen(srb) - *offset);\n" + "> \302\240\t\tif (*offset >= scsi_bufflen(srb))\n" + "> \302\240\t\t\treturn 0;\n" + "> \302\240\t\tcnt = min(buflen, scsi_bufflen(srb) - *offset);\n" "> +\n" "> +\t\tunsigned char *sgbuffer = (unsigned char *)scsi_sglist(srb) +\n" "> +\t\t\t*offset;\n" @@ -26,14 +35,14 @@ "Variable declarations are only done at the beginning of functions.\n" "\n" "> +\n" - "> ?\t\tif (dir == TO_XFER_BUF)\n" + "> \302\240\t\tif (dir == TO_XFER_BUF)\n" "> -\t\t\tmemcpy((unsigned char *) scsi_sglist(srb) + *offset,\n" "> -\t\t\t\t\tbuffer, cnt);\n" "> +\t\t\tmemcpy(sgbuffer, buffer, cnt);\n" - "> ?\t\telse\n" + "> \302\240\t\telse\n" "> -\t\t\tmemcpy(buffer, (unsigned char *) scsi_sglist(srb) +\n" "> -\t\t\t\t\t*offset, cnt);\n" "> +\t\t\tmemcpy(buffer, sgbuffer, cnt);\n" - "> ?\t\t*offset += cnt;" + "> \302\240\t\t*offset += cnt;" -85a60dae7834b4677504a471768b6096b837f437a871a0704aa45a3823088e05 +4d305e00137bca7e8c4cc317c3adbb7511b0334fdd0db77bdae24a6bbffb0ce4
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.