From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: [PATCH v5 4/5] drm/dsi: Add routine to unregister a DSI device Date: Fri, 12 Feb 2016 14:48:33 +0530 Message-ID: <1455268714-28755-5-git-send-email-architt@codeaurora.org> References: <1449751300-2841-1-git-send-email-architt@codeaurora.org> <1455268714-28755-1-git-send-email-architt@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1455268714-28755-1-git-send-email-architt@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org, treding@nvidia.com Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, a.hajda@samsung.com List-Id: linux-arm-msm@vger.kernel.org QSBkcml2ZXIgY2FsbGluZyBtaXBpX2RzaV9kZXZpY2VfcmVnaXN0ZXJfZnVsbCBtaWdodCB3YW50 IHRvIHVucmVnaXN0ZXIKdGhlIGRldmljZSBvbmNlIGl0J3MgZG9uZS4gSXQgbWlnaHQgYWxzbyBy ZXF1aXJlIGl0IGluIGFuIGVycm9yIGhhbmRsaW5nCnBhdGggaW4gY2FzZSBzb21ldGhpbmcgZGlk bid0IGdvIHJpZ2h0LgoKQ3JlYXRlIG1pcGlfZHNpX2RldmljZV91bnJlZ2lzdGVyIGZvciB0aGlz IHB1cnBzZSwgdXNlIGl0IHdpdGhpbgptaXBpX2RzaV9yZW1vdmVfZGV2aWNlX2ZuIGFzIGl0IGRv ZXMgdGhlIHNhbWUgdGhpbmcuCgpSZXZpZXdlZC1ieTogQW5kcnplaiBIYWpkYSA8YS5oYWpkYUBz YW1zdW5nLmNvbT4KU2lnbmVkLW9mZi1ieTogQXJjaGl0IFRhbmVqYSA8YXJjaGl0dEBjb2RlYXVy b3JhLm9yZz4KLS0tCiBkcml2ZXJzL2dwdS9kcm0vZHJtX21pcGlfZHNpLmMgfCAxMiArKysrKysr KysrKy0KIGluY2x1ZGUvZHJtL2RybV9taXBpX2RzaS5oICAgICB8ICAxICsKIDIgZmlsZXMgY2hh bmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9kcm1fbWlwaV9kc2kuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fbWlwaV9kc2ku YwppbmRleCA0MmE3YWFjLi5mMmY1YTZkIDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJt X21pcGlfZHNpLmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9taXBpX2RzaS5jCkBAIC0yMjUs NiArMjI1LDE2IEBAIG1pcGlfZHNpX2RldmljZV9yZWdpc3Rlcl9mdWxsKHN0cnVjdCBtaXBpX2Rz aV9ob3N0ICpob3N0LAogfQogRVhQT1JUX1NZTUJPTChtaXBpX2RzaV9kZXZpY2VfcmVnaXN0ZXJf ZnVsbCk7CiAKKy8qKgorICogbWlwaV9kc2lfZGV2aWNlX3VucmVnaXN0ZXIgLSB1bnJlZ2lzdGVy IE1JUEkgRFNJIGRldmljZQorICogQGRzaTogRFNJIHBlcmlwaGVyYWwgZGV2aWNlCisgKi8KK3Zv aWQgbWlwaV9kc2lfZGV2aWNlX3VucmVnaXN0ZXIoc3RydWN0IG1pcGlfZHNpX2RldmljZSAqZHNp KQoreworCWRldmljZV91bnJlZ2lzdGVyKCZkc2ktPmRldik7Cit9CitFWFBPUlRfU1lNQk9MKG1p cGlfZHNpX2RldmljZV91bnJlZ2lzdGVyKTsKKwogaW50IG1pcGlfZHNpX2hvc3RfcmVnaXN0ZXIo c3RydWN0IG1pcGlfZHNpX2hvc3QgKmhvc3QpCiB7CiAJc3RydWN0IGRldmljZV9ub2RlICpub2Rl OwpAQCAtMjQ0LDcgKzI1NCw3IEBAIHN0YXRpYyBpbnQgbWlwaV9kc2lfcmVtb3ZlX2RldmljZV9m bihzdHJ1Y3QgZGV2aWNlICpkZXYsIHZvaWQgKnByaXYpCiB7CiAJc3RydWN0IG1pcGlfZHNpX2Rl dmljZSAqZHNpID0gdG9fbWlwaV9kc2lfZGV2aWNlKGRldik7CiAKLQlkZXZpY2VfdW5yZWdpc3Rl cigmZHNpLT5kZXYpOworCW1pcGlfZHNpX2RldmljZV91bnJlZ2lzdGVyKGRzaSk7CiAKIAlyZXR1 cm4gMDsKIH0KZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9taXBpX2RzaS5oIGIvaW5jbHVk ZS9kcm0vZHJtX21pcGlfZHNpLmgKaW5kZXggYTkxNDExNi4uMDZlMGE5MyAxMDA2NDQKLS0tIGEv aW5jbHVkZS9kcm0vZHJtX21pcGlfZHNpLmgKKysrIGIvaW5jbHVkZS9kcm0vZHJtX21pcGlfZHNp LmgKQEAgLTIxMCw2ICsyMTAsNyBAQCBzdGF0aWMgaW5saW5lIGludCBtaXBpX2RzaV9waXhlbF9m b3JtYXRfdG9fYnBwKGVudW0gbWlwaV9kc2lfcGl4ZWxfZm9ybWF0IGZtdCkKIHN0cnVjdCBtaXBp X2RzaV9kZXZpY2UgKgogbWlwaV9kc2lfZGV2aWNlX3JlZ2lzdGVyX2Z1bGwoc3RydWN0IG1pcGlf ZHNpX2hvc3QgKmhvc3QsCiAJCQkgICAgICBjb25zdCBzdHJ1Y3QgbWlwaV9kc2lfZGV2aWNlX2lu Zm8gKmluZm8pOwordm9pZCBtaXBpX2RzaV9kZXZpY2VfdW5yZWdpc3RlcihzdHJ1Y3QgbWlwaV9k c2lfZGV2aWNlICpkc2kpOwogc3RydWN0IG1pcGlfZHNpX2RldmljZSAqb2ZfZmluZF9taXBpX2Rz aV9kZXZpY2VfYnlfbm9kZShzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wKTsKIGludCBtaXBpX2RzaV9h dHRhY2goc3RydWN0IG1pcGlfZHNpX2RldmljZSAqZHNpKTsKIGludCBtaXBpX2RzaV9kZXRhY2go c3RydWN0IG1pcGlfZHNpX2RldmljZSAqZHNpKTsKLS0gClRoZSBRdWFsY29tbSBJbm5vdmF0aW9u IENlbnRlciwgSW5jLiBpcyBhIG1lbWJlciBvZiB0aGUgQ29kZSBBdXJvcmEgRm9ydW0sCmhvc3Rl ZCBieSBUaGUgTGludXggRm91bmRhdGlvbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751777AbcBLJTj (ORCPT ); Fri, 12 Feb 2016 04:19:39 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:58381 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751514AbcBLJS6 (ORCPT ); Fri, 12 Feb 2016 04:18:58 -0500 From: Archit Taneja To: dri-devel@lists.freedesktop.org, treding@nvidia.com Cc: linux-kernel@vger.kernel.org, a.hajda@samsung.com, airlied@linux.ie, daniel@ffwll.ch, l.stach@pengutronix.de, robh@kernel.org, linux-arm-msm@vger.kernel.org, jani.nikula@linux.intel.com, Archit Taneja Subject: [PATCH v5 4/5] drm/dsi: Add routine to unregister a DSI device Date: Fri, 12 Feb 2016 14:48:33 +0530 Message-Id: <1455268714-28755-5-git-send-email-architt@codeaurora.org> X-Mailer: git-send-email 1.8.2.1 In-Reply-To: <1455268714-28755-1-git-send-email-architt@codeaurora.org> References: <1449751300-2841-1-git-send-email-architt@codeaurora.org> <1455268714-28755-1-git-send-email-architt@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A driver calling mipi_dsi_device_register_full might want to unregister the device once it's done. It might also require it in an error handling path in case something didn't go right. Create mipi_dsi_device_unregister for this purpse, use it within mipi_dsi_remove_device_fn as it does the same thing. Reviewed-by: Andrzej Hajda Signed-off-by: Archit Taneja --- drivers/gpu/drm/drm_mipi_dsi.c | 12 +++++++++++- include/drm/drm_mipi_dsi.h | 1 + 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c index 42a7aac..f2f5a6d 100644 --- a/drivers/gpu/drm/drm_mipi_dsi.c +++ b/drivers/gpu/drm/drm_mipi_dsi.c @@ -225,6 +225,16 @@ mipi_dsi_device_register_full(struct mipi_dsi_host *host, } EXPORT_SYMBOL(mipi_dsi_device_register_full); +/** + * mipi_dsi_device_unregister - unregister MIPI DSI device + * @dsi: DSI peripheral device + */ +void mipi_dsi_device_unregister(struct mipi_dsi_device *dsi) +{ + device_unregister(&dsi->dev); +} +EXPORT_SYMBOL(mipi_dsi_device_unregister); + int mipi_dsi_host_register(struct mipi_dsi_host *host) { struct device_node *node; @@ -244,7 +254,7 @@ static int mipi_dsi_remove_device_fn(struct device *dev, void *priv) { struct mipi_dsi_device *dsi = to_mipi_dsi_device(dev); - device_unregister(&dsi->dev); + mipi_dsi_device_unregister(dsi); return 0; } diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h index a914116..06e0a93 100644 --- a/include/drm/drm_mipi_dsi.h +++ b/include/drm/drm_mipi_dsi.h @@ -210,6 +210,7 @@ static inline int mipi_dsi_pixel_format_to_bpp(enum mipi_dsi_pixel_format fmt) struct mipi_dsi_device * mipi_dsi_device_register_full(struct mipi_dsi_host *host, const struct mipi_dsi_device_info *info); +void mipi_dsi_device_unregister(struct mipi_dsi_device *dsi); struct mipi_dsi_device *of_find_mipi_dsi_device_by_node(struct device_node *np); int mipi_dsi_attach(struct mipi_dsi_device *dsi); int mipi_dsi_detach(struct mipi_dsi_device *dsi); -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation