Re: [PATCH] libxl: fix handling returns in libxl_get_version_info()

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1301 bytes --]

On Fri, 2016-02-12 at 16:34 +0530, Harmandeep Kaur wrote:
> On Fri, Feb 12, 2016 at 4:30 PM, Dario Faggioli
> <dario.faggioli@citrix.com> wrote:
> > 
> Sorry I actually meant,
> tools/libxl/xl_cmdimpl.c:    vinfo = libxl_get_version_info(ctx);
> 
> vinfo = libxl_get_version_info(ctx);
>     if (vinfo) {
>
Which again checks for vinfo to not be NULL before using it, so this
also seems ok to me.

>         i = (1 << 20) / vinfo->pagesize;
>         printf("total_memory           : %"PRIu64"\n",
> info.total_pages / i);
>         printf("free_memory            : %"PRIu64"\n",
> (info.free_pages - info.outstanding_pages) / i);
>         printf("sharing_freed_memory   : %"PRIu64"\n",
> info.sharing_freed_pages / i);
>         printf("sharing_used_memory    : %"PRIu64"\n",
> info.sharing_used_frames / i);
>         printf("outstanding_claims     : %"PRIu64"\n",
> info.outstanding_pages / i);
>     }
> 
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel