From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ander Conselvan De Oliveira Subject: Re: [PATCH 2/5] drm/i915: Cleaning up intel_dp_hpd_pulse Date: Fri, 12 Feb 2016 19:19:36 +0200 Message-ID: <1455297576.2720.66.camel@gmail.com> References: <1455095087-9285-1-git-send-email-shubhangi.shrivastava@intel.com> <1455095087-9285-2-git-send-email-shubhangi.shrivastava@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com [209.85.220.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id EB29B6EB30 for ; Fri, 12 Feb 2016 09:20:26 -0800 (PST) Received: by mail-pa0-f43.google.com with SMTP id fl4so37717830pad.0 for ; Fri, 12 Feb 2016 09:20:26 -0800 (PST) In-Reply-To: <1455095087-9285-2-git-send-email-shubhangi.shrivastava@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Shubhangi Shrivastava , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyMDE2LTAyLTEwIGF0IDE0OjM0ICswNTMwLCBTaHViaGFuZ2kgU2hyaXZhc3RhdmEg d3JvdGU6Cj4gQ3VycmVudCBEUCBkZXRlY3Rpb24gaGFzIERQQ0Qgb3BlcmF0aW9ucyBzcGxpdCBh Y3Jvc3MKPiBpbnRlbF9kcF9ocGRfcHVsc2UgYW5kIGludGVsX2RwX2RldGVjdCB3aGljaCBjb250 YWlucwo+IGR1cGxpY2F0ZXMgYXMgd2VsbC4gQWxzbyBpbnRlbF9kcF9kZXRlY3QgaXMgY2FsbGVk Cj4gZHVyaW5nIG1vZGVzIGVudW1lcmF0aW9uIGFzIHdlbGwgd2hpY2ggd2lsbCByZXN1bHQKPiBp biBtdWx0aXBsZSBkcGNkIG9wZXJhdGlvbnMuIFNvIHRoaXMgcGF0Y2ggdHJpZXMKPiB0byBzb2x2 ZSBib3RoIHRoZXNlIGJ5IGJyaW5naW5nIGFsbCBEUENEIG9wZXJhdGlvbnMKPiBpbiBvbmUgc2lu Z2xlIGZ1bmN0aW9uIGFuZCBtYWtlIGludGVsX2RwX2RldGVjdAo+IHVzZSBleGlzdGluZyB2YWx1 ZXMgaW5zdGVhZCBvZiByZXBlYXRpbmcgc2FtZSBzdGVwcy4KPiAKPiB2MjogUHVsbGVkIGluIGEg aHVuayBmcm9tIGxhc3QgcGF0Y2ggb2YgdGhlIHNlcmllcyB0bwo+ICAgICB0aGlzIHBhdGNoLiAo QW5kZXIpCj4gdjM6IEFkZGVkIE1TVCBob3RwbHVnIGhhbmRsaW5nLiAoQW5kZXIpCgpUaGUgY2hh bmdlIGxvZyBmb3IgdGhpcyB2ZXJzaW9uIG9mIHRoZSBwYXRjaCBpcyBtaXNzaW5nLiBXaXRoIHRo YXQsIHRoaXMgaXMKClJldmlld2VkLWJ5OiBBbmRlciBDb25zZWx2YW4gZGUgT2xpdmVpcmEgPGNv bnNlbHZhbjJAZ21haWwuY29tPgoKPiAKPiBUZXN0ZWQtYnk6IE5hdGhhbiBEIENpb2JhbnUgPG5h dGhhbi5kLmNpb2JhbnVAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFNpdmFrdW1hciBUaHVs YXNpbWFuaSA8c2l2YWt1bWFyLnRodWxhc2ltYW5pQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5 OiBTaHViaGFuZ2kgU2hyaXZhc3RhdmEgPHNodWJoYW5naS5zaHJpdmFzdGF2YUBpbnRlbC5jb20+ Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgIHwgNzIgKysrKysrKysr KysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tCj4gLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kcnYuaCB8ICAxICsKPiAgMiBmaWxlcyBjaGFuZ2VkLCA0NyBpbnNlcnRpb25zKCsp LCAyNiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBpbmRleCAwNDIy ODNhLi5hZDVlYzNiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rw LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gQEAgLTQ2NTMsNiAr NDY1MywxNiBAQCBpbnRlbF9kcF9sb25nX3B1bHNlKHN0cnVjdCBpbnRlbF9jb25uZWN0b3IKPiAq aW50ZWxfY29ubmVjdG9yKQo+ICAJCSAqLwo+ICAJCXN0YXR1cyA9IGNvbm5lY3Rvcl9zdGF0dXNf ZGlzY29ubmVjdGVkOwo+ICAJCWdvdG8gb3V0Owo+ICsJfSBlbHNlIGlmIChjb25uZWN0b3ItPnN0 YXR1cyA9PSBjb25uZWN0b3Jfc3RhdHVzX2Nvbm5lY3RlZCkgewo+ICsJCS8qCj4gKwkJICogSWYg ZGlzcGxheSB3YXMgY29ubmVjdGVkIGFscmVhZHkgYW5kIGlzIHN0aWxsIGNvbm5lY3RlZAo+ICsJ CSAqIGNoZWNrIGxpbmtzIHN0YXR1cywgdGhlcmUgaGFzIGJlZW4ga25vd24gaXNzdWVzIG9mCj4g KwkJICogbGluayBsb3NzIHRyaWdnZXJyaW5nIGxvbmcgcHVsc2UhISEhCj4gKwkJICovCj4gKwkJ ZHJtX21vZGVzZXRfbG9jaygmZGV2LT5tb2RlX2NvbmZpZy5jb25uZWN0aW9uX211dGV4LCBOVUxM KTsKPiArCQlpbnRlbF9kcF9jaGVja19saW5rX3N0YXR1cyhpbnRlbF9kcCk7Cj4gKwkJZHJtX21v ZGVzZXRfdW5sb2NrKCZkZXYtPm1vZGVfY29uZmlnLmNvbm5lY3Rpb25fbXV0ZXgpOwo+ICsJCWdv dG8gb3V0Owo+ICAJfQo+ICAKPiAgCS8qCj4gQEAgLTQ2NjYsNiArNDY3Niw3IEBAIGludGVsX2Rw X2xvbmdfcHVsc2Uoc3RydWN0IGludGVsX2Nvbm5lY3Rvcgo+ICppbnRlbF9jb25uZWN0b3IpCj4g IAlpbnRlbF9kcF9zZXRfZWRpZChpbnRlbF9kcCk7Cj4gIAo+ICAJc3RhdHVzID0gY29ubmVjdG9y X3N0YXR1c19jb25uZWN0ZWQ7Cj4gKwlpbnRlbF9kcC0+ZGV0ZWN0X2RvbmUgPSB0cnVlOwo+ICAK PiAgCS8qIFRyeSB0byByZWFkIHRoZSBzb3VyY2Ugb2YgdGhlIGludGVycnVwdCAqLwo+ICAJaWYg KGludGVsX2RwLT5kcGNkW0RQX0RQQ0RfUkVWXSA+PSAweDExICYmCj4gQEAgLTQ2ODIsOCArNDY5 MywyMSBAQCBpbnRlbF9kcF9sb25nX3B1bHNlKHN0cnVjdCBpbnRlbF9jb25uZWN0b3IKPiAqaW50 ZWxfY29ubmVjdG9yKQo+ICAJfQo+ICAKPiAgb3V0Ogo+IC0JaWYgKHN0YXR1cyAhPSBjb25uZWN0 b3Jfc3RhdHVzX2Nvbm5lY3RlZCkKPiArCWlmIChzdGF0dXMgIT0gY29ubmVjdG9yX3N0YXR1c19j b25uZWN0ZWQpIHsKPiAgCQlpbnRlbF9kcF91bnNldF9lZGlkKGludGVsX2RwKTsKPiArCQkvKgo+ ICsJCSAqIElmIHdlIHdlcmUgaW4gTVNUIG1vZGUsIGFuZCBkZXZpY2UgaXMgbm90IHRoZXJlLAo+ ICsJCSAqIGdldCBvdXQgb2YgTVNUIG1vZGUKPiArCQkgKi8KPiArCQlpZiAoaW50ZWxfZHAtPmlz X21zdCkgewo+ICsJCQlEUk1fREVCVUdfS01TKCJNU1QgZGV2aWNlIG1heSBoYXZlIGRpc2FwcGVh cmVkICVkIHZzCj4gJWRcbiIsCj4gKwkJCQlpbnRlbF9kcC0+aXNfbXN0LCBpbnRlbF9kcAo+IC0+ bXN0X21nci5tc3Rfc3RhdGUpOwo+ICsJCQlpbnRlbF9kcC0+aXNfbXN0ID0gZmFsc2U7Cj4gKwkJ CWRybV9kcF9tc3RfdG9wb2xvZ3lfbWdyX3NldF9tc3QoJmludGVsX2RwLT5tc3RfbWdyLAo+ICsJ CQkJCQkJaW50ZWxfZHAtPmlzX21zdCk7Cj4gKwkJfQo+ICsJfQo+ICsKPiAgCWludGVsX2Rpc3Bs YXlfcG93ZXJfcHV0KHRvX2k5MTUoZGV2KSwgcG93ZXJfZG9tYWluKTsKPiAgCXJldHVybjsKPiAg fQo+IEBAIC00NzA3LDcgKzQ3MzEsMTEgQEAgaW50ZWxfZHBfZGV0ZWN0KHN0cnVjdCBkcm1fY29u bmVjdG9yICpjb25uZWN0b3IsIGJvb2wKPiBmb3JjZSkKPiAgCQlyZXR1cm4gY29ubmVjdG9yX3N0 YXR1c19kaXNjb25uZWN0ZWQ7Cj4gIAl9Cj4gIAo+IC0JaW50ZWxfZHBfbG9uZ19wdWxzZShpbnRl bF9kcC0+YXR0YWNoZWRfY29ubmVjdG9yKTsKPiArCS8qIElmIGZ1bGwgZGV0ZWN0IGlzIG5vdCBw ZXJmb3JtZWQgeWV0LCBkbyBhIGZ1bGwgZGV0ZWN0ICovCj4gKwlpZiAoIWludGVsX2RwLT5kZXRl Y3RfZG9uZSkKPiArCQlpbnRlbF9kcF9sb25nX3B1bHNlKGludGVsX2RwLT5hdHRhY2hlZF9jb25u ZWN0b3IpOwo+ICsKPiArCWludGVsX2RwLT5kZXRlY3RfZG9uZSA9IGZhbHNlOwo+ICAKPiAgCWlm IChpbnRlbF9jb25uZWN0b3ItPmRldGVjdF9lZGlkKQo+ICAJCXJldHVybiBjb25uZWN0b3Jfc3Rh dHVzX2Nvbm5lY3RlZDsKPiBAQCAtNTA0MCwyNSArNTA2OCwyNSBAQCBpbnRlbF9kcF9ocGRfcHVs c2Uoc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydAo+ICppbnRlbF9kaWdfcG9ydCwgYm9vbCBsb25n X2hwZCkKPiAgCQkvKiBpbmRpY2F0ZSB0aGF0IHdlIG5lZWQgdG8gcmVzdGFydCBsaW5rIHRyYWlu aW5nICovCj4gIAkJaW50ZWxfZHAtPnRyYWluX3NldF92YWxpZCA9IGZhbHNlOwo+ICAKPiAtCQlp ZiAoIWludGVsX2RpZ2l0YWxfcG9ydF9jb25uZWN0ZWQoZGV2X3ByaXYsIGludGVsX2RpZ19wb3J0 KSkKPiAtCQkJZ290byBtc3RfZmFpbDsKPiAtCj4gLQkJaWYgKCFpbnRlbF9kcF9nZXRfZHBjZChp bnRlbF9kcCkpIHsKPiAtCQkJZ290byBtc3RfZmFpbDsKPiAtCQl9Cj4gLQo+IC0JCWludGVsX2Rw X3Byb2JlX291aShpbnRlbF9kcCk7Cj4gKwkJaW50ZWxfZHBfbG9uZ19wdWxzZShpbnRlbF9kcC0+ YXR0YWNoZWRfY29ubmVjdG9yKTsKPiArCQlpZiAoaW50ZWxfZHAtPmlzX21zdCkKPiArCQkJcmV0 ID0gSVJRX0hBTkRMRUQ7Cj4gKwkJZ290byBwdXRfcG93ZXI7Cj4gIAo+IC0JCWlmICghaW50ZWxf ZHBfcHJvYmVfbXN0KGludGVsX2RwKSkgewo+IC0JCQlkcm1fbW9kZXNldF9sb2NrKCZkZXYtPm1v ZGVfY29uZmlnLmNvbm5lY3Rpb25fbXV0ZXgsCj4gTlVMTCk7Cj4gLQkJCWludGVsX2RwX2NoZWNr X2xpbmtfc3RhdHVzKGludGVsX2RwKTsKPiAtCQkJZHJtX21vZGVzZXRfdW5sb2NrKCZkZXYKPiAt Pm1vZGVfY29uZmlnLmNvbm5lY3Rpb25fbXV0ZXgpOwo+IC0JCQlnb3RvIG1zdF9mYWlsOwo+IC0J CX0KPiAgCX0gZWxzZSB7Cj4gIAkJaWYgKGludGVsX2RwLT5pc19tc3QpIHsKPiAtCQkJaWYgKGlu dGVsX2RwX2NoZWNrX21zdF9zdGF0dXMoaW50ZWxfZHApID09IC1FSU5WQUwpCj4gLQkJCQlnb3Rv IG1zdF9mYWlsOwo+ICsJCQlpZiAoaW50ZWxfZHBfY2hlY2tfbXN0X3N0YXR1cyhpbnRlbF9kcCkg PT0gLUVJTlZBTCkgewo+ICsJCQkJLyoKPiArCQkJCSAqIElmIHdlIHdlcmUgaW4gTVNUIG1vZGUs IGFuZCBkZXZpY2UgaXMgbm90Cj4gKwkJCQkgKiB0aGVyZSwgZ2V0IG91dCBvZiBNU1QgbW9kZQo+ ICsJCQkJICovCj4gKwkJCQlEUk1fREVCVUdfS01TKCJNU1QgZGV2aWNlIG1heSBoYXZlCj4gZGlz YXBwZWFyZWQgJWQgdnMgJWRcbiIsCj4gKwkJCQkJaW50ZWxfZHAtPmlzX21zdCwgaW50ZWxfZHAK PiAtPm1zdF9tZ3IubXN0X3N0YXRlKTsKPiArCQkJCWludGVsX2RwLT5pc19tc3QgPSBmYWxzZTsK PiArCQkJCWRybV9kcF9tc3RfdG9wb2xvZ3lfbWdyX3NldF9tc3QoJmludGVsX2RwCj4gLT5tc3Rf bWdyLAo+ICsJCQkJCQkJCWludGVsX2RwCj4gLT5pc19tc3QpOwo+ICsJCQkJZ290byBwdXRfcG93 ZXI7Cj4gKwkJCX0KPiAgCQl9Cj4gIAo+ICAJCWlmICghaW50ZWxfZHAtPmlzX21zdCkgewo+IEBA IC01MDcwLDE0ICs1MDk4LDYgQEAgaW50ZWxfZHBfaHBkX3B1bHNlKHN0cnVjdCBpbnRlbF9kaWdp dGFsX3BvcnQKPiAqaW50ZWxfZGlnX3BvcnQsIGJvb2wgbG9uZ19ocGQpCj4gIAo+ICAJcmV0ID0g SVJRX0hBTkRMRUQ7Cj4gIAo+IC0JZ290byBwdXRfcG93ZXI7Cj4gLW1zdF9mYWlsOgo+IC0JLyog aWYgd2Ugd2VyZSBpbiBNU1QgbW9kZSwgYW5kIGRldmljZSBpcyBub3QgdGhlcmUgZ2V0IG91dCBv ZiBNU1QKPiBtb2RlICovCj4gLQlpZiAoaW50ZWxfZHAtPmlzX21zdCkgewo+IC0JCURSTV9ERUJV R19LTVMoIk1TVCBkZXZpY2UgbWF5IGhhdmUgZGlzYXBwZWFyZWQgJWQgdnMgJWRcbiIsCj4gaW50 ZWxfZHAtPmlzX21zdCwgaW50ZWxfZHAtPm1zdF9tZ3IubXN0X3N0YXRlKTsKPiAtCQlpbnRlbF9k cC0+aXNfbXN0ID0gZmFsc2U7Cj4gLQkJZHJtX2RwX21zdF90b3BvbG9neV9tZ3Jfc2V0X21zdCgm aW50ZWxfZHAtPm1zdF9tZ3IsIGludGVsX2RwCj4gLT5pc19tc3QpOwo+IC0JfQo+ICBwdXRfcG93 ZXI6Cj4gIAlpbnRlbF9kaXNwbGF5X3Bvd2VyX3B1dChkZXZfcHJpdiwgcG93ZXJfZG9tYWluKTsK PiAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+IGluZGV4IDg3ODE3MmEuLjNkMDAzZDYg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+IEBAIC03NTMsNiArNzUzLDcgQEAgc3Ry dWN0IGludGVsX2RwIHsKPiAgCWludCBsaW5rX3JhdGU7Cj4gIAl1aW50OF90IGxhbmVfY291bnQ7 Cj4gIAlib29sIGhhc19hdWRpbzsKPiArCWJvb2wgZGV0ZWN0X2RvbmU7Cj4gIAllbnVtIGhkbWlf Zm9yY2VfYXVkaW8gZm9yY2VfYXVkaW87Cj4gIAlib29sIGxpbWl0ZWRfY29sb3JfcmFuZ2U7Cj4g IAlib29sIGNvbG9yX3JhbmdlX2F1dG87Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeAo=