From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>, tytso@mit.edu
Cc: linux-ext4@vger.kernel.org, Darren Hart <dvhart@linux.intel.com>
Subject: Re: [PATCH 9/9] libext2fs: sort keys for xattr blocks
Date: Sun, 14 Feb 2016 10:37:06 +0000 [thread overview]
Message-ID: <1455446226.16142.387.camel@linuxfoundation.org> (raw)
In-Reply-To: <20160213223824.25381.8002.stgit@birch.djwong.org>
On Sat, 2016-02-13 at 14:38 -0800, Darrick J. Wong wrote:
> Richard Purdie reports that libext2fs doesn't sort attribute keys in
> the xattr block correctly, causing the kernel to return -ENODATA when
> querying attributes that should be there. Therefore, sort attributes
> so that whatever ends up in the xattr block is sorted according to
> what the kernel expects.
>
> Cc: Darren Hart <dvhart@linux.intel.com>
> Reported-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> lib/ext2fs/ext_attr.c | 24 +++++++++++-
> tests/d_xattr_sorting/expect | 29 ++++++++++++++
> tests/d_xattr_sorting/name | 1
> tests/d_xattr_sorting/script | 86
> ++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 139 insertions(+), 1 deletion(-)
> create mode 100644 tests/d_xattr_sorting/expect
> create mode 100644 tests/d_xattr_sorting/name
> create mode 100644 tests/d_xattr_sorting/script
I had some test scripts I'd used to debug this. I applied this patch
and those tests passed, thanks!
Tested-by: Richard Purdie <richard.purdie@linuxfoundation.org>
I'll update the version of this we're using in OpenEmbedded and the
Yocto Project to your patch.
Cheers,
Richard
next prev parent reply other threads:[~2016-02-14 10:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-13 22:37 [PATCH 0/9] e2fsprogs: save checksum seeds; fix broken xattr editing; misc fixes Darrick J. Wong
2016-02-13 22:37 ` [PATCH 1/9] libext2fs: store checksum seed in superblock Darrick J. Wong
2016-03-05 23:21 ` Theodore Ts'o
2016-02-13 22:37 ` [PATCH 2/9] tune2fs: allow user to turn on saving the checksum seed Darrick J. Wong
2016-03-05 23:36 ` Theodore Ts'o
2016-02-13 22:37 ` [PATCH 3/9] e2fsck: check the checksum seed feature flag is set correctly Darrick J. Wong
2016-03-05 23:37 ` Theodore Ts'o
2016-02-13 22:37 ` [PATCH 4/9] mke2fs: store checksum seed at format time Darrick J. Wong
2016-03-06 0:19 ` Theodore Ts'o
2016-02-13 22:37 ` [PATCH 5/9] tests: check proper operation of metadata_csum_seed Darrick J. Wong
2016-03-06 0:20 ` Theodore Ts'o
2016-02-13 22:38 ` [PATCH 6/9] filefrag: accommodate holes when calculating expected values Darrick J. Wong
2016-03-06 2:41 ` Theodore Ts'o
2016-02-13 22:38 ` [PATCH 7/9] tune2fs: confirm dangerous operations Darrick J. Wong
2016-02-15 0:49 ` Andreas Dilger
2016-02-15 16:53 ` Darrick J. Wong
2016-03-06 5:10 ` Theodore Ts'o
2016-03-06 6:24 ` Darrick J. Wong
2016-02-13 22:38 ` [PATCH 8/9] tune2fs: recover the journal Darrick J. Wong
2016-03-06 5:23 ` Theodore Ts'o
2016-02-13 22:38 ` [PATCH 9/9] libext2fs: sort keys for xattr blocks Darrick J. Wong
2016-02-14 10:37 ` Richard Purdie [this message]
2016-03-06 3:55 ` Theodore Ts'o
2016-03-06 22:08 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455446226.16142.387.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=darrick.wong@oracle.com \
--cc=dvhart@linux.intel.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.