From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46287)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <abologna@redhat.com>) id 1aVG4y-0003kO-T3
	for qemu-devel@nongnu.org; Mon, 15 Feb 2016 05:08:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <abologna@redhat.com>) id 1aVG4v-0007wL-Ks
	for qemu-devel@nongnu.org; Mon, 15 Feb 2016 05:08:28 -0500
Received: from mx1.redhat.com ([209.132.183.28]:47053)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <abologna@redhat.com>) id 1aVG4v-0007vy-Ge
	for qemu-devel@nongnu.org; Mon, 15 Feb 2016 05:08:25 -0500
Message-ID: <1455530899.4617.69.camel@redhat.com>
From: Andrea Bolognani <abologna@redhat.com>
Date: Mon, 15 Feb 2016 11:08:19 +0100
In-Reply-To: <CAMJs5B-QfPeWrB1LFp5qj-N71zD1AGL-MNiJDJfvdqJruAdrQw@mail.gmail.com>
References: <1452016711.16471.6.camel@redhat.com>
	<CAFEAcA_Y6keKPb0Ayjp4yFSdfZXg7rFmxxZ33f=e4R0sV+b8HQ@mail.gmail.com>
	<1452018414.16471.8.camel@redhat.com> <20160106113402.GA13870@cbox>
	<1452084567.4759.6.camel@redhat.com>
	<CAFEAcA9AGYQiWPDH6fcxMo=jycxtKL8c50JmH1TtS4=Qz53-XQ@mail.gmail.com>
	<20160122144432.GJ14825@redhat.com> <20160202114933.GA11792@cbox>
	<20160202121010.GH18461@redhat.com>
	<20160202125926.GE3688@hawk.localdomain> <20160202140528.GC6190@cbox>
	<56B0D0AC.3010003@redhat.com>
	<CAMJs5B-QfPeWrB1LFp5qj-N71zD1AGL-MNiJDJfvdqJruAdrQw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [libvirt]  ARM KVM GICv3 Support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>, Christoffer Dall <christoffer.dall@linaro.org>, Eric Blake <eblake@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Andrew Jones <drjones@redhat.com>, Eric Auger <eric.auger@linaro.org>, Libvirt <libvir-list@redhat.com>, Andre Przywara <andre.przywara@arm.com>, QEMU Developers <qemu-devel@nongnu.org>, Marc Zyngier <marc.zyngier@arm.com>

On Tue, 2016-02-02 at 16:58 +0100, Christoffer Dall wrote:
> ok, so that would mean we need to implement a QMP command to tell us
> which gic versions are supported for a given machine.=C2=A0=C2=A0Curren=
t
> possible responses are "2", "3" and "2,3"
>=C2=A0
> and we also need to add code to libvirt to try that QMP command, and
> if it doesn't exist, fall back to not specifying gic-version, using
> the old-qemu compatible default of providing a gicv2 to guests, and if
> the QMP command exists, use the newest gic-version.
>=C2=A0
> users can then always override this behavior by directly specifying a
> gic version "host", "2", or "3" in their xml file.
>=C2=A0
> any objections?

Dan voiced his preference for probing the host GIC versions from
libvirt and just passing that to QEMU dealing with any failure later
on, but I think that was mostly to keep things simple and not
because the QMP command approach was wrong?

IOW Dan, if we went ahead with the QMP command approach, would you
oppose it? Peter Xu has posted some RFC QEMU patches yesterday...

Cheers.

--=C2=A0
Andrea Bolognani
Software Engineer - Virtualization Team