From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH] kernel/cpu: Distinctive name for cpu_hotplug.dep_map Date: Mon, 15 Feb 2016 14:30:46 +0200 Message-ID: <1455539446.5499.2.camel@linux.intel.com> References: <1454509468-10627-1-git-send-email-joonas.lahtinen@linux.intel.com> <20160203171244.GA8159@in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id B55636E5D2 for ; Mon, 15 Feb 2016 12:30:50 +0000 (UTC) In-Reply-To: <20160203171244.GA8159@in.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ingo Molnar , Peter Zijlstra , ego@linux.vnet.ibm.com Cc: Intel graphics driver community testing & development , "Rafael J. Wysocki" , Linux kernel development List-Id: intel-gfx@lists.freedesktop.org SGksCgpBY2NvcmRpbmcgdG8gc2NyaXB0cy9nZXRfbWFpbnRhaW5lci5wbCBJbmdvIG9yIFBldGVy IHdvdWxkIGJlIG1vcmUKYXBwcm9wcmlhdGUgdG8gbWVyZ2UuCgpBZGRlZCB0aGVtIGFzIFRvOgoK T24ga2UsIDIwMTYtMDItMDMgYXQgMjI6NDIgKzA1MzAsIEdhdXRoYW0gUiBTaGVub3kgd3JvdGU6 Cj4gSGVsbG8gSm9vbmFzLAo+IAo+IE9uIFdlZCwgRmViIDAzLCAyMDE2IGF0IDA0OjI0OjI4UE0g KzAyMDAsIEpvb25hcyBMYWh0aW5lbiB3cm90ZToKPiA+IFVzZSBkaXN0aW5jdGl2ZSBuYW1lIGZv ciBjcHVfaG90cGx1Zy5kZXBfbWFwIHRvIGF2b2lkIHRoZSBhY3R1YWwKPiA+IGNwdV9ob3RwbHVn LmxvY2sgYXBwZWFyaW5nIGFzIGNwdV9ob3RwbHVnLmxvY2sjMiBpbiBsb2NrZGVwIHNwbGF0cy4K PiA+IAo+ID4gQ2M6IEdhdXRoYW0gUi4gU2hlbm95IDxlZ29AbGludXgudm5ldC5pYm0uY29tPgo+ ID4gQ2M6IFJhZmFlbCBKLiBXeXNvY2tpIDxyYWZhZWwuai53eXNvY2tpQGludGVsLmNvbT4KPiA+ IENjOiBJbnRlbCBncmFwaGljcyBkcml2ZXIgY29tbXVuaXR5IHRlc3RpbmcgJiBkZXZlbG9wbWVu dCA8aW50ZWwtZ2YKPiA+IHhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnPgo+ID4gU2lnbmVkLW9mZi1i eTogSm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgo+ID4g LS0tCj4gPiDCoGtlcm5lbC9jcHUuYyB8IDIgKy0KPiA+IMKgMSBmaWxlIGNoYW5nZWQsIDEgaW5z ZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9rZXJuZWwvY3B1 LmMgYi9rZXJuZWwvY3B1LmMKPiA+IGluZGV4IDViOWQzOTYuLjZhMTNmMjQgMTAwNjQ0Cj4gPiAt LS0gYS9rZXJuZWwvY3B1LmMKPiA+ICsrKyBiL2tlcm5lbC9jcHUuYwo+ID4gQEAgLTc4LDcgKzc4 LDcgQEAgc3RhdGljIHN0cnVjdCB7Cj4gPiDCoAkud3EgPSBfX1dBSVRfUVVFVUVfSEVBRF9JTklU SUFMSVpFUihjcHVfaG90cGx1Zy53cSksCj4gPiDCoAkubG9jayA9IF9fTVVURVhfSU5JVElBTEla RVIoY3B1X2hvdHBsdWcubG9jayksCj4gPiDCoCNpZmRlZiBDT05GSUdfREVCVUdfTE9DS19BTExP Qwo+ID4gLQkuZGVwX21hcCA9IHsubmFtZSA9ICJjcHVfaG90cGx1Zy5sb2NrIiB9LAo+ID4gKwku ZGVwX21hcCA9IFNUQVRJQ19MT0NLREVQX01BUF9JTklUKCJjcHVfaG90cGx1Zy5kZXBfbWFwIiwK PiA+ICZjcHVfaG90cGx1Zy5kZXBfbWFwKSwKPiAKPiBMb29rcyBnb29kIHRvIG1lIQo+IEFja2Vk LWJ5OiBHYXV0aGFtIFIuIFNoZW5veSA8ZWdvQGxpbnV4LnZuZXQuaWJtLmNvbT4KPiAKClRoYW5r cyEKClJlZ2FyZHMsIEpvb25hcwoKPiAtLQo+IFRoYW5rcyBhbmQgUmVnYXJkcwo+IGdhdXRoYW0u Cj4gCi0tIApKb29uYXMgTGFodGluZW4KT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKSW50 ZWwgQ29ycG9yYXRpb24KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753121AbcBOMaw (ORCPT ); Mon, 15 Feb 2016 07:30:52 -0500 Received: from mga04.intel.com ([192.55.52.120]:59683 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752986AbcBOMau (ORCPT ); Mon, 15 Feb 2016 07:30:50 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,450,1449561600"; d="scan'208";a="885224206" Message-ID: <1455539446.5499.2.camel@linux.intel.com> Subject: Re: [PATCH] kernel/cpu: Distinctive name for cpu_hotplug.dep_map From: Joonas Lahtinen To: Ingo Molnar , Peter Zijlstra , ego@linux.vnet.ibm.com Cc: Linux kernel development , "Rafael J. Wysocki" , Intel graphics driver community testing & development Date: Mon, 15 Feb 2016 14:30:46 +0200 In-Reply-To: <20160203171244.GA8159@in.ibm.com> References: <1454509468-10627-1-git-send-email-joonas.lahtinen@linux.intel.com> <20160203171244.GA8159@in.ibm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.4 (3.18.4-1.fc23) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, According to scripts/get_maintainer.pl Ingo or Peter would be more appropriate to merge. Added them as To: On ke, 2016-02-03 at 22:42 +0530, Gautham R Shenoy wrote: > Hello Joonas, > > On Wed, Feb 03, 2016 at 04:24:28PM +0200, Joonas Lahtinen wrote: > > Use distinctive name for cpu_hotplug.dep_map to avoid the actual > > cpu_hotplug.lock appearing as cpu_hotplug.lock#2 in lockdep splats. > > > > Cc: Gautham R. Shenoy > > Cc: Rafael J. Wysocki > > Cc: Intel graphics driver community testing & development > x@lists.freedesktop.org> > > Signed-off-by: Joonas Lahtinen > > --- > >  kernel/cpu.c | 2 +- > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/kernel/cpu.c b/kernel/cpu.c > > index 5b9d396..6a13f24 100644 > > --- a/kernel/cpu.c > > +++ b/kernel/cpu.c > > @@ -78,7 +78,7 @@ static struct { > >   .wq = __WAIT_QUEUE_HEAD_INITIALIZER(cpu_hotplug.wq), > >   .lock = __MUTEX_INITIALIZER(cpu_hotplug.lock), > >  #ifdef CONFIG_DEBUG_LOCK_ALLOC > > - .dep_map = {.name = "cpu_hotplug.lock" }, > > + .dep_map = STATIC_LOCKDEP_MAP_INIT("cpu_hotplug.dep_map", > > &cpu_hotplug.dep_map), > > Looks good to me! > Acked-by: Gautham R. Shenoy > Thanks! Regards, Joonas > -- > Thanks and Regards > gautham. > -- Joonas Lahtinen Open Source Technology Center Intel Corporation