From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mail.openembedded.org (Postfix) with ESMTP id C2F116FFCE for ; Mon, 15 Feb 2016 16:54:22 +0000 (UTC) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP; 15 Feb 2016 08:54:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,451,1449561600"; d="scan'208";a="652477893" Received: from jlock-mobl1.gar.corp.intel.com ([10.252.12.36]) by FMSMGA003.fm.intel.com with ESMTP; 15 Feb 2016 08:54:21 -0800 Message-ID: <1455555256.4309.27.camel@linux.intel.com> From: Joshua G Lock To: Mirela Rabulea , "bitbake-devel@lists.openembedded.org" Date: Mon, 15 Feb 2016 16:54:16 +0000 In-Reply-To: References: <1453903391.3557.42.camel@linux.intel.com> <1455138641.3442.8.camel@linux.intel.com> X-Mailer: Evolution 3.18.4 (3.18.4-1.fc23) Mime-Version: 1.0 Cc: Nicolae Manescu , Alexandru Purice , "Roman, Alexandru CostinX" , "Voiculescu, BogdanX A" Subject: Re: [PATCH] Fix bug 8940 - Alow Hob to run images on a custom simulator, other than qemu X-BeenThere: bitbake-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussion that advance bitbake development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2016 16:54:23 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit On Sun, 2016-02-14 at 22:09 +0000, Mirela Rabulea wrote: > Hi Joshua, > I found one more issue with a corner case when commuting from "Run > custom image" to "Deploy image". From the comments I found in the > code, the case when there are both "runnable" and "deployable" > present in the same build is not expected. > However, with the introduction of the "Run custom", I think this > requires a fix, so here is the v4 of the patch (squashed version > attached). > If you did not get to check the v3 patch, you may skip it and check > the v4. With this patch applied I'm still seeing the same behaviour — after building core-image-minimal for genericx86-64 runqemu is displayed as the run script but clicking on "Run custom image" launches the "Usb image maker". Regards, Joshua > Only the v4 fix: > From 4e6c941d74a7b1e11fbd26085a6908b746f61536 Mon Sep 17 00:00:00 > 2001 > From: Mirela Rabulea > Date: Sun, 14 Feb 2016 23:42:32 +0200 > Subject: [PATCH] Allow Hob to run images on a custom simulator, other > than >  qemu Fixed bug when commuting from deploy image to run custom image. > > Signed-off-by: Mirela Rabulea > --- >  bitbake/lib/bb/ui/crumbs/imagedetailspage.py | 3 ++- >  1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/bitbake/lib/bb/ui/crumbs/imagedetailspage.py > b/bitbake/lib/bb/ui/crumbs/imagedetailspage.py > index b22cf80..32d4854 100755 > --- a/bitbake/lib/bb/ui/crumbs/imagedetailspage.py > +++ b/bitbake/lib/bb/ui/crumbs/imagedetailspage.py > @@ -516,8 +516,9 @@ class ImageDetailsPage (HobPage): >          for fileitem in action_images: >              sel_btn = gtk.RadioButton(sel_parent_btn, > fileitem['type']) >              sel_parent_btn = sel_btn if not sel_parent_btn else > sel_parent_btn > -            if fileitem['name'] == self.toggled_image: > +            if curr_row == 0: >                  sel_btn.set_active(True) > +                self.toggled_image = fileitem['name'] >              sel_btn.connect('toggled', self.table_selected_cb, > fileitem) >              if curr_row < 10: >                  table.attach(sel_btn, 0, 4, curr_row, curr_row + 1, > xpadding=24)