From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752743AbcBPI1a (ORCPT ); Tue, 16 Feb 2016 03:27:30 -0500 Received: from mx2.suse.de ([195.135.220.15]:44596 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751115AbcBPI13 (ORCPT ); Tue, 16 Feb 2016 03:27:29 -0500 Message-ID: <1455611093.4532.2.camel@suse.com> Subject: Re: [PATCH] usb: check for signals in chaoskey read function From: Oliver Neukum To: Keith Packard Cc: linux-usb@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org Date: Tue, 16 Feb 2016 09:24:53 +0100 In-Reply-To: <1455590972-2120-1-git-send-email-keithp@keithp.com> References: <1455590972-2120-1-git-send-email-keithp@keithp.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-02-15 at 18:49 -0800, Keith Packard wrote: > Call signal_pending before reading a chunk of data from the device so > that long read operations can be interrupted with a signal. Hi, why is this needed? You are doing this right after a mutex_lock_interruptible(). Regards Oliver