From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2] tools: libxl: make it illegal to pass libxl__realloc(gc) a non-gc ptr Date: Thu, 18 Feb 2016 11:30:20 +0000 Message-ID: <1455795020.6225.38.camel@citrix.com> References: <1455182634-19386-1-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1455182634-19386-1-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: ian.jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org Cc: Andrew Cooper List-Id: xen-devel@lists.xenproject.org T24gVGh1LCAyMDE2LTAyLTExIGF0IDA5OjIzICswMDAwLCBJYW4gQ2FtcGJlbGwgd3JvdGU6Cj4g VGhhdCBpcywgaWYgZ2MgaXMgbm90IE5PR0MgYW5kIHB0ciBpcyBub3QgTlVMTCB0aGVuIHB0ciBt dXN0IGJlCj4gYXNzb2NpYXRlZCBnYy4KPiAKPiBDdXJyZW50bHkgaW4gdGhpcyBjYXNlIHRoZSBu ZXdfcHRyIHdvdWxkIG5vdCBiZSByZWdpc3RlcmVkIHdpdGggYW55Cj4gZ2MsIHdoaWNoIENvdmVy aXR5IHJpZ2h0bHkgcG9pbnRzIG91dCAoaW4gdmFyaW91cyBkaWZmZXJlbnQgcGxhY2VzKQo+IHdv dWxkIGJlIGEgbWVtb3J5IGxlYWsuCgpUaGlzIGNoYW5nZSB3YXNuJ3Qgc3VmZmljaWVudCB0byBw bGFjYXRlIENvdmVyaXR5LiBJIHRoaW5rIGl0J3MgYW5hbHlzaXMKbm93IGlzIGEgZmFsc2UgcG9z aXRpdmUsIHNlZSBlLmcgQ0lEIDEzNDMzMDcsIGJ1dCBhIHNlY29uZCBvcGluaW9uIHdvdWxkIGJl CmFwcHJlY2lhdGVkLgoKSXQgZG9lc24ndCBzZWVtIHRvIHNwb3QgdGhhdCB0aGlzIGxvb3A6CsKg IMKgIMKgIMKgIGZvciAoaSA9IDA7IGkgPCBnYy0+YWxsb2NfbWF4c2l6ZTsgaSsrKSB7CsKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoGlmIChnYy0+YWxsb2NfcHRyc1tpXSA9PSBwdHIpIHsKwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBnYy0+YWxsb2NfcHRyc1tpXSA9IG5ld19wdHI7CsKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgYnJlYWs7CsKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoH0KwqDCoMKgwqDCoMKgwqDCoH0KZWl0aGVyIGV4aXRzIHdpdGggaSA8IGdjLT5hbGxvY19t YXhzaXplIGhhdmluZyB1cGRhdGVkIGFsbG9jX3B0cnMgb3IgZXhpdHMKd2l0aCBpID09IGdjLT5h bGxvY19tYXhzaXplLgoKSGF2aW5nIGV4aXRlZCB0aGUgbG9vcCB3aXRoICJDb25kaXRpb24gaSA8 IGdjLT5hbGxvY19tYXhzaXplLCB0YWtpbmcgZmFsc2UKYnJhbmNoIiBpdCB0aGVuIGRvZXMgIkNv bmRpdGlvbiBpID09IGdjLT5hbGxvY19tYXhzaXplLCB0YWtpbmcgZmFsc2UKYnJhbmNoIiwgYXZv aWRpbmcgdGhlIGFzc2VydCAod2hpY2ggSSBoYWQgaG9wZWQgd291bGQgYmUgc3VmZmljaWVudCB0 bwpxdWFzaCB0aGUgaXNzdWUpLiBQcmVzdW1hYmx5IGl0IGVpdGhlciBjYW5ub3QgdHJhY2sgdGhl IHBvc3NpYmxlIHZhbHVlcyBvZgppIGF0IGFsbCBvciBpdCBjb25zaWRlcnMgdGhlIHBvc3NpYmls aXR5IHRoYXQgaSA+IGdjLT5hbGxvY19tYXhzaXplIG1pZ2h0CmJlIHRydWUgaGVyZS4KClBlcmhh cHMgY2hhbmdpbmcgdGhlIHRlc3QgdG8gaSA+PSBnYy0+YWxsb2NfbWF4c2l6ZSBtaWdodCBiZSBl bm91Z2ggb2YgYQpoaW50IHRvIGl0PyBPciBtYXliZSBhc3NlcnRpbmcgImk8PWdjLT5hbGxvY19t YXhzaXplIiBhZnRlciB0aGUgbG9vcD8KCk9yIG1heWJlIHRoaXMgcmVhbGx5IHJlcXVpcmVzIG1v ZGVsbGluZz8KClVuZm9ydHVuYXRlbHkgdGhlIGFjdHVhbCBDSURzIGFyZSByZXBvcnRlZCBpbiB0 aGUgY2FsbGVycyBvZiBsaWJ4bF9fcmVhbGxvYwphbmQgZGV0ZXJtaW5pbmcgZm9yIHN1cmUgdGhh dCBlYWNoIHN1Y2ggaXNzdWUgaXMgaW5kZWVkIGRvd24gdG8gdGhpcyBtaXMtCmFuYWx5c2lzIG9m IHRoZSBiZWhhdmlvdXIgb2YgbGlieGxfX3JlYWxsb2MgaXMgbm90IGVudGlyZWx5IHRyaXZpYWwu CgpJYW4uCgoKPiAKPiBJdCB3b3VsZCBhbHNvIGJlIHBvc3NpYmxlIHRvIGZpeCB0aGlzIGJ5IGFk ZGluZyBhIGxpYnhsX19wdHJfYWRkKCkgYXQKPiB0aGUgc2FtZSBwb2ludCwgaG93ZXZlciBzZW1h bnRpY2FsbHkgaXQgc2VlbXMgbGlrZSBhIHByb2dyYW1taW5nIGVycm9yCj4gdG8gZ2MtcmVhbGxv YyBhIHBvaW50ZXIgd2hpY2ggaXMgbm90IGFzc29jaWF0ZWQgd2l0aCB0aGUgZ2MgaW4KPiBxdWVz dGlvbiwgc28gdHJlYXQgaXQgYXMgc3VjaC4KPiAKPiBDb21waWxlIHRlc3RlZCBvbmx5LCB0aGlz IGNoYW5nZSBjb3VsZCBleHBvc2UgbGF0ZW50IGJ1Z3MuCj4gCj4gU2lnbmVkLW9mZi1ieTogSWFu IENhbXBiZWxsIDxpYW4uY2FtcGJlbGxAY2l0cml4LmNvbT4KPiAtLS0KPiB2MjogQ2hlY2sgd2Ug YWN0dWFsbHkgZGlkbid0IGZpbmQgdGhlIHB0ciBpbiB0aGUgZ2MKPiDCoMKgwqDCoENvcnJlY3Qg bG9nIG1lc3NhZ2UgYW5kIHNob3J0ZW4gc2luY2UgTE9HIHdpbGwgaW5qZWN0IHRoZQo+IMKgwqDC oMKgwqDCoMKgZnVuY3Rpb24gbmFtZS4KPiAtLS0KPiDCoHRvb2xzL2xpYnhsL2xpYnhsX2ludGVy bmFsLmMgfCA0ICsrKysKPiDCoHRvb2xzL2xpYnhsL2xpYnhsX2ludGVybmFsLmggfCA0ICsrKy0K PiDCoDIgZmlsZXMgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4g ZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhsL2xpYnhsX2ludGVybmFsLmMgYi90b29scy9saWJ4bC9s aWJ4bF9pbnRlcm5hbC5jCj4gaW5kZXggMzI4MDQ2Yi4uZmM4MTEzMCAxMDA2NDQKPiAtLS0gYS90 b29scy9saWJ4bC9saWJ4bF9pbnRlcm5hbC5jCj4gKysrIGIvdG9vbHMvbGlieGwvbGlieGxfaW50 ZXJuYWwuYwo+IEBAIC0xMjIsNiArMTIyLDEwIEBAIHZvaWQgKmxpYnhsX19yZWFsbG9jKGxpYnhs X19nYyAqZ2MsIHZvaWQgKnB0ciwKPiBzaXplX3QgbmV3X3NpemUpCj4gwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoGJyZWFrOwo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgfQo+ IMKgwqDCoMKgwqDCoMKgwqDCoH0KPiArwqDCoMKgwqDCoMKgwqDCoGlmIChpID09IGdjLT5hbGxv Y19tYXhzaXplKSB7Cj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoExPRyhDUklUSUNBTCwgInBv aW50ZXIgaXMgbm90IHRyYWNrZWQgYnkgdGhlIGdpdmVuIGdjIik7Cj4gK8KgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoGFib3J0KCk7Cj4gK8KgwqDCoMKgwqDCoMKgwqB9Cj4gwqDCoMKgwqDCoH0KPiDC oAo+IMKgwqDCoMKgwqByZXR1cm4gbmV3X3B0cjsKPiBkaWZmIC0tZ2l0IGEvdG9vbHMvbGlieGwv bGlieGxfaW50ZXJuYWwuaCBiL3Rvb2xzL2xpYnhsL2xpYnhsX2ludGVybmFsLmgKPiBpbmRleCBm YzFiNTU4Li42NTBhOTU4IDEwMDY0NAo+IC0tLSBhL3Rvb2xzL2xpYnhsL2xpYnhsX2ludGVybmFs LmgKPiArKysgYi90b29scy9saWJ4bC9saWJ4bF9pbnRlcm5hbC5oCj4gQEAgLTYxNyw3ICs2MTcs OSBAQCBfaGlkZGVuIHZvaWQgKmxpYnhsX196YWxsb2MobGlieGxfX2djICpnY19vcHQsIHNpemVf dAo+IHNpemUpIE5OMTsKPiDCoF9oaWRkZW4gdm9pZCAqbGlieGxfX2NhbGxvYyhsaWJ4bF9fZ2Mg KmdjX29wdCwgc2l6ZV90IG5tZW1iLCBzaXplX3QKPiBzaXplKSBOTjE7Cj4gwqAvKiBjaGFuZ2Ug dGhlIHNpemUgb2YgdGhlIG1lbW9yeSBibG9jayBwb2ludGVkIHRvIGJ5IEBwdHIgdG8gQG5ld19z aXplCj4gYnl0ZXMuCj4gwqAgKiB1bmxpa2Ugb3RoZXIgYWxsb2NhdGlvbiBmdW5jdGlvbnMgaGVy ZSBhbnkgYWRkaXRpb25hbCBzcGFjZSBiZXR3ZWVuCj4gdGhlCj4gLSAqIG9sZHNpemUgYW5kIEBu ZXdfc2l6ZSBpcyBub3QgaW5pdGlhbGlzZWQgKHNpbWlsYXIgdG8gYSBnYydkCj4gcmVhbGxvYygz KSkuICovCj4gKyAqIG9sZHNpemUgYW5kIEBuZXdfc2l6ZSBpcyBub3QgaW5pdGlhbGlzZWQgKHNp bWlsYXIgdG8gYSBnYydkCj4gcmVhbGxvYygzKSkuCj4gKyAqIGlmIEBwdHIgaXMgbm9uLU5VTEwg YW5kIEBnY19vcHQgaXMgbm90IG5vZ2NfZ2MgdGhlbiBAcHRyIG11c3QgaGF2ZQo+IGJlZW4KPiAr ICogcmVnaXN0ZXJlZCB3aXRoIEBnY19vcHQgcHJldmlvdXNseS4gKi8KPiDCoF9oaWRkZW4gdm9p ZCAqbGlieGxfX3JlYWxsb2MobGlieGxfX2djICpnY19vcHQsIHZvaWQgKnB0ciwgc2l6ZV90Cj4g bmV3X3NpemUpIE5OMTsKPiDCoC8qIHByaW50IEBmbXQgaW50byBhbiBhbGxvY2F0ZWQgc3RyaW5n IGxhcmdlIGVub3VnaHRvIGNvbnRhaW4gdGhlCj4gcmVzdWx0Lgo+IMKgICogKHNpbWlsYXIgdG8g Z2MnZCBhc3ByaW50ZigzKSkuICovCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4u b3JnCmh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=