Re: [PATCH 2/2] PCI: imx6: add initial imx6sx support

[Christoph Fritz <chf.fritz@googlemail.com>]

Hi Richard

On Mon, 2016-02-15 at 07:24 +0000, Richard Zhu wrote:
> > -----Original Message-----
> > From: Christoph Fritz [mailto:chf.fritz@googlemail.com]
> > -static void imx6_pcie_init_phy(struct pcie_port *pp)
> > +static int imx6_pcie_init_phy(struct pcie_port *pp)
> >  {
> >  	struct imx6_pcie *imx6_pcie = to_imx6_pcie(pp);
> > +	int ret = 0;
> > +
> > +	if (imx6_pcie->is_imx6sx) {
> > +		/* power up separate domain available on i.mx6sx */
> > +		regmap_update_bits(imx6_pcie->gpc_ips_reg,
> > +			PCIE_PHY_IMX6SX_GPC_CNTR,
> > +			PCIE_PHY_IMX6SX_GPC_CNTR_PUP_REQ,
> > +			PCIE_PHY_IMX6SX_GPC_CNTR_PUP_REQ);
> 
>  [Zhu hongxing]  First of all, thanks for trying to upstream imx6sx pcie driver.
> As Lucas discussed with me before,  the GPC regulator operations should be touched in
> Imx pcie driver at all.  These bits operations should be encapsulate into the PM system,
>  for example, the regulator driver.

Ok, for an initial version, I'll just leave the regulator in my
devicetree enabled. For further enhancements I suppose
arch/arm/mach-imx/gpc.c needs to get touched?

Let me reroll this patchset.

Thanks
 -- Christoph