From: tixy@linaro.org (Jon Medhurst (Tixy))
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 9/9] ARM: fix kprobe test with CONFIG_CPU_32v3
Date: Thu, 18 Feb 2016 14:21:16 +0000 [thread overview]
Message-ID: <1455805276.3036.3.camel@linaro.org> (raw)
In-Reply-To: <1455804123-2526139-10-git-send-email-arnd@arndb.de>
On Thu, 2016-02-18 at 15:02 +0100, Arnd Bergmann wrote:
> ARMv3 did not have 16-bit load/store or 32-bit multiply instructions,
> so building the kprobe test code fails with lots of warnings about
> these:
>
> /tmp/ccI4SKHx.s:19585: Error: selected processor does not support ARM mode `umull r0,r1,r2,r3'
> /tmp/ccI4SKHx.s:19617: Error: selected processor does not support ARM mode `umullls r7,r8,r9,r10'
> /tmp/ccI4SKHx.s:19645: Error: selected processor does not support ARM mode `umull lr,r12,r11,r13'
> /tmp/ccI4SKHx.s:19727: Error: selected processor does not support ARM mode `umulls r0,r1,r2,r3'
> ...
> /tmp/ccI4SKHx.s:21273: Error: selected processor does not support ARM mode `strh r0,[r1,-r2]'
> /tmp/ccI4SKHx.s:21309: Error: selected processor does not support ARM mode `streqh r14,[r11,r12]'
> /tmp/ccI4SKHx.s:21333: Error: selected processor does not support ARM mode `streqh r14,[r13,r12]'
>
> This puts all the affected instructions inside an #ifdef section,
> like we do for the other architecture levels.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
I was about to say that I didn't know that we supported ARMv3 then got a
feeling of deja vu :-) [1]
Acked-by: Jon Medhurst <tixy@linaro.org>
[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-March/242997.html
> arch/arm/probes/kprobes/test-arm.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/probes/kprobes/test-arm.c b/arch/arm/probes/kprobes/test-arm.c
> index 8866aedfdea2..4e8511f0582d 100644
> --- a/arch/arm/probes/kprobes/test-arm.c
> +++ b/arch/arm/probes/kprobes/test-arm.c
> @@ -391,6 +391,7 @@ void kprobe_arm_test_cases(void)
> TEST_UNSUPPORTED(__inst_arm(0xe0700090) " @ undef")
> TEST_UNSUPPORTED(__inst_arm(0xe07fff9f) " @ undef")
>
> +#if __LINUX_ARM_ARCH__ >= 4
> TEST_RR( "umull r0, r1, r",2, VAL1,", r",3, VAL2,"")
> TEST_RR( "umullls r7, r8, r",9, VAL2,", r",10, VAL1,"")
> TEST_R( "umull lr, r12, r",11,VAL3,", r13")
> @@ -436,6 +437,7 @@ void kprobe_arm_test_cases(void)
> TEST_UNSUPPORTED(__inst_arm(0xe0f0f392) " @ smlals r0, pc, r2, r3")
> TEST_UNSUPPORTED(__inst_arm(0xe0f0139f) " @ smlals r0, r1, pc, r3")
> TEST_UNSUPPORTED(__inst_arm(0xe0f01f92) " @ smlals r0, r1, r2, pc")
> +#endif
>
> TEST_GROUP("Synchronization primitives")
>
> @@ -478,7 +480,7 @@ void kprobe_arm_test_cases(void)
> TEST_UNSUPPORTED("ldrexh r2, [sp]")
> #endif
> TEST_GROUP("Extra load/store instructions")
> -
> +#if __LINUX_ARM_ARCH__ >= 4
> TEST_RPR( "strh r",0, VAL1,", [r",1, 48,", -r",2, 24,"]")
> TEST_RPR( "streqh r",14,VAL2,", [r",11,0, ", r",12, 48,"]")
> TEST_UNSUPPORTED( "streqh r14, [r13, r12]")
> @@ -560,6 +562,7 @@ void kprobe_arm_test_cases(void)
> TEST( "ldrsh r0, [pc, #0]")
> TEST_UNSUPPORTED(__inst_arm(0xe1ffc3f0) " @ ldrsh r12, [pc, #48]!")
> TEST_UNSUPPORTED(__inst_arm(0xe0d9f3f0) " @ ldrsh pc, [r9], #48")
> +#endif
>
> #if __LINUX_ARM_ARCH__ >= 7
> TEST_UNSUPPORTED("strht r1, [r2], r3")
WARNING: multiple messages have this Message-ID (diff)
From: "Jon Medhurst (Tixy)" <tixy@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Nicolas Pitre <nico@linaro.org>,
Marc Zyngier <marc.zyngier@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 9/9] ARM: fix kprobe test with CONFIG_CPU_32v3
Date: Thu, 18 Feb 2016 14:21:16 +0000 [thread overview]
Message-ID: <1455805276.3036.3.camel@linaro.org> (raw)
In-Reply-To: <1455804123-2526139-10-git-send-email-arnd@arndb.de>
On Thu, 2016-02-18 at 15:02 +0100, Arnd Bergmann wrote:
> ARMv3 did not have 16-bit load/store or 32-bit multiply instructions,
> so building the kprobe test code fails with lots of warnings about
> these:
>
> /tmp/ccI4SKHx.s:19585: Error: selected processor does not support ARM mode `umull r0,r1,r2,r3'
> /tmp/ccI4SKHx.s:19617: Error: selected processor does not support ARM mode `umullls r7,r8,r9,r10'
> /tmp/ccI4SKHx.s:19645: Error: selected processor does not support ARM mode `umull lr,r12,r11,r13'
> /tmp/ccI4SKHx.s:19727: Error: selected processor does not support ARM mode `umulls r0,r1,r2,r3'
> ...
> /tmp/ccI4SKHx.s:21273: Error: selected processor does not support ARM mode `strh r0,[r1,-r2]'
> /tmp/ccI4SKHx.s:21309: Error: selected processor does not support ARM mode `streqh r14,[r11,r12]'
> /tmp/ccI4SKHx.s:21333: Error: selected processor does not support ARM mode `streqh r14,[r13,r12]'
>
> This puts all the affected instructions inside an #ifdef section,
> like we do for the other architecture levels.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
I was about to say that I didn't know that we supported ARMv3 then got a
feeling of deja vu :-) [1]
Acked-by: Jon Medhurst <tixy@linaro.org>
[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-March/242997.html
> arch/arm/probes/kprobes/test-arm.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/probes/kprobes/test-arm.c b/arch/arm/probes/kprobes/test-arm.c
> index 8866aedfdea2..4e8511f0582d 100644
> --- a/arch/arm/probes/kprobes/test-arm.c
> +++ b/arch/arm/probes/kprobes/test-arm.c
> @@ -391,6 +391,7 @@ void kprobe_arm_test_cases(void)
> TEST_UNSUPPORTED(__inst_arm(0xe0700090) " @ undef")
> TEST_UNSUPPORTED(__inst_arm(0xe07fff9f) " @ undef")
>
> +#if __LINUX_ARM_ARCH__ >= 4
> TEST_RR( "umull r0, r1, r",2, VAL1,", r",3, VAL2,"")
> TEST_RR( "umullls r7, r8, r",9, VAL2,", r",10, VAL1,"")
> TEST_R( "umull lr, r12, r",11,VAL3,", r13")
> @@ -436,6 +437,7 @@ void kprobe_arm_test_cases(void)
> TEST_UNSUPPORTED(__inst_arm(0xe0f0f392) " @ smlals r0, pc, r2, r3")
> TEST_UNSUPPORTED(__inst_arm(0xe0f0139f) " @ smlals r0, r1, pc, r3")
> TEST_UNSUPPORTED(__inst_arm(0xe0f01f92) " @ smlals r0, r1, r2, pc")
> +#endif
>
> TEST_GROUP("Synchronization primitives")
>
> @@ -478,7 +480,7 @@ void kprobe_arm_test_cases(void)
> TEST_UNSUPPORTED("ldrexh r2, [sp]")
> #endif
> TEST_GROUP("Extra load/store instructions")
> -
> +#if __LINUX_ARM_ARCH__ >= 4
> TEST_RPR( "strh r",0, VAL1,", [r",1, 48,", -r",2, 24,"]")
> TEST_RPR( "streqh r",14,VAL2,", [r",11,0, ", r",12, 48,"]")
> TEST_UNSUPPORTED( "streqh r14, [r13, r12]")
> @@ -560,6 +562,7 @@ void kprobe_arm_test_cases(void)
> TEST( "ldrsh r0, [pc, #0]")
> TEST_UNSUPPORTED(__inst_arm(0xe1ffc3f0) " @ ldrsh r12, [pc, #48]!")
> TEST_UNSUPPORTED(__inst_arm(0xe0d9f3f0) " @ ldrsh pc, [r9], #48")
> +#endif
>
> #if __LINUX_ARM_ARCH__ >= 7
> TEST_UNSUPPORTED("strht r1, [r2], r3")
next prev parent reply other threads:[~2016-02-18 14:21 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 14:01 [PATCH 0/9] ARM: randconfig testing fallout Arnd Bergmann
2016-02-18 14:01 ` [PATCH 1/9] ARM: ARMv7-M uses BE-8, not BE-32 Arnd Bergmann
2016-02-18 14:01 ` Arnd Bergmann
2016-02-18 16:06 ` Nicolas Pitre
2016-02-18 16:06 ` Nicolas Pitre
2016-02-18 16:12 ` Arnd Bergmann
2016-02-18 16:12 ` Arnd Bergmann
2016-02-19 8:47 ` Vladimir Murzin
2016-02-19 8:47 ` Vladimir Murzin
2016-02-19 10:17 ` Arnd Bergmann
2016-02-19 10:17 ` Arnd Bergmann
2016-02-18 14:01 ` [PATCH 2/9] ARM: change NR_IPIS to 8 Arnd Bergmann
2016-02-18 14:01 ` Arnd Bergmann
2016-02-18 14:26 ` Marc Zyngier
2016-02-18 14:26 ` Marc Zyngier
2016-02-18 14:37 ` Russell King - ARM Linux
2016-02-18 14:37 ` Russell King - ARM Linux
2016-02-18 15:18 ` Arnd Bergmann
2016-02-18 15:18 ` Arnd Bergmann
2018-09-18 8:19 ` Chunyan Zhang
2018-09-18 8:19 ` Chunyan Zhang
2016-02-18 14:01 ` [PATCH 3/9] ARM: make free_memmap as __init Arnd Bergmann
2016-02-18 14:01 ` Arnd Bergmann
2016-02-18 15:55 ` Nicolas Pitre
2016-02-18 15:55 ` Nicolas Pitre
2016-02-18 14:01 ` [PATCH 4/9] ARM: add CONFIG_PHYS_OFFSET default values Arnd Bergmann
2016-02-18 14:01 ` Arnd Bergmann
2016-02-18 16:02 ` Nicolas Pitre
2016-02-18 16:02 ` Nicolas Pitre
2016-02-19 8:33 ` Arnd Bergmann
2016-02-19 8:33 ` Arnd Bergmann
2016-02-19 14:29 ` Chris Brandt
2016-02-19 14:29 ` Chris Brandt
2016-02-19 15:34 ` Arnd Bergmann
2016-02-19 15:34 ` Arnd Bergmann
2016-02-19 16:43 ` Russell King - ARM Linux
2016-02-19 16:43 ` Russell King - ARM Linux
2016-02-19 17:18 ` Chris Brandt
2016-02-19 17:18 ` Chris Brandt
2016-02-19 17:57 ` Nicolas Pitre
2016-02-19 17:57 ` Nicolas Pitre
2016-02-19 16:10 ` Nicolas Pitre
2016-02-19 16:10 ` Nicolas Pitre
2016-02-19 16:23 ` Arnd Bergmann
2016-02-19 16:23 ` Arnd Bergmann
2016-02-19 17:31 ` Nicolas Pitre
2016-02-19 17:31 ` Nicolas Pitre
2016-02-19 18:07 ` Russell King - ARM Linux
2016-02-19 18:07 ` Russell King - ARM Linux
2016-02-19 21:14 ` Arnd Bergmann
2016-02-19 21:14 ` Arnd Bergmann
2016-02-18 14:01 ` [PATCH 5/9] ARM: atags_to_fdt: don't warn about stack size Arnd Bergmann
2016-02-18 14:01 ` Arnd Bergmann
2016-02-18 16:13 ` Nicolas Pitre
2016-02-18 16:13 ` Nicolas Pitre
2016-02-18 16:26 ` [PATCH v2] " Arnd Bergmann
2016-02-18 16:26 ` Arnd Bergmann
2016-02-18 17:14 ` Nicolas Pitre
2016-02-18 17:14 ` Nicolas Pitre
2016-02-19 16:58 ` Arnd Bergmann
2016-02-19 16:58 ` Arnd Bergmann
2016-02-18 14:01 ` [PATCH 6/9] ARM: uaccess: avoid warning for NOMMU in access_ok Arnd Bergmann
2016-02-18 14:01 ` Arnd Bergmann
2016-02-18 16:15 ` Nicolas Pitre
2016-02-18 16:15 ` Nicolas Pitre
2016-02-18 14:01 ` [PATCH 7/9] ARM: move NO_DMA definition to ecard.h Arnd Bergmann
2016-02-18 14:01 ` Arnd Bergmann
2016-02-18 16:17 ` Nicolas Pitre
2016-02-18 16:17 ` Nicolas Pitre
2016-02-18 14:02 ` [PATCH 8/9] ARM: do not use optimized do_div for ARMv3 Arnd Bergmann
2016-02-18 14:02 ` Arnd Bergmann
2016-02-18 17:20 ` Nicolas Pitre
2016-02-18 17:20 ` Nicolas Pitre
2016-02-19 9:03 ` Arnd Bergmann
2016-02-19 9:03 ` Arnd Bergmann
2016-02-19 18:44 ` Nicolas Pitre
2016-02-19 18:44 ` Nicolas Pitre
2016-02-18 14:02 ` [PATCH 9/9] ARM: fix kprobe test with CONFIG_CPU_32v3 Arnd Bergmann
2016-02-18 14:02 ` Arnd Bergmann
2016-02-18 14:21 ` Jon Medhurst (Tixy) [this message]
2016-02-18 14:21 ` Jon Medhurst (Tixy)
2016-02-18 16:21 ` Nicolas Pitre
2016-02-18 16:21 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455805276.3036.3.camel@linaro.org \
--to=tixy@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.