From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 13/16] xenalyze: handle Credit1 scheduler events Date: Thu, 18 Feb 2016 17:58:03 +0100 Message-ID: <1455814683.7213.12.camel@citrix.com> References: <20160216180550.27876.22680.stgit@Solace.station> <20160216181257.27876.13452.stgit@Solace.station> <56C5E3BA.50501@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4646820978375270368==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aWRyD-0000o3-SG for xen-devel@lists.xenproject.org; Thu, 18 Feb 2016 17:02:25 +0000 In-Reply-To: <56C5E3BA.50501@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap , xen-devel@lists.xenproject.org Cc: Olaf Hering , Wei Liu , Ian Campbell , George Dunlap , Ian Jackson List-Id: xen-devel@lists.xenproject.org --===============4646820978375270368== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-/3W1pnbCb+t+qwgxz24N" --=-/3W1pnbCb+t+qwgxz24N Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2016-02-18 at 15:31 +0000, George Dunlap wrote: > On 16/02/16 18:12, Dario Faggioli wrote: > >=C2=A0 > > diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c > > index 17021f1..4ab2dba 100644 > > --- a/tools/xentrace/xenalyze.c > > +++ b/tools/xentrace/xenalyze.c > > @@ -7673,6 +7673,63 @@ void sched_process(struct pcpu_info *p) > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0default: > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0process_generic(&p->ri); > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} > > +=C2=A0=C2=A0=C2=A0=C2=A0} else if(ri->evt.sub =3D=3D 2) { > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0/* TRC_SCHED_CLASS */ > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0switch(ri->event) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0{ > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0/* CREDIT (TRC_CSCHED_= xxx) */ > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0case TRC_SCHED_CLASS_E= VT(CSCHED, 1): /* SCHED_TASKLET */ >=20 > Sorry, just one more comment: >=20 > It would probably be good at some point to find a way to expose these > in > a public header, rather than having to manually keep this file in > sync > with the values in sched_*.c.=C2=A0=C2=A0But that's a nice-to-have for an= other > day. :-) >=20 Indeed. I can add this to my TODO list, although... > (Maybe a cleanup for a GSoC / OPW student...?) >=20 ... that's actually a good idea (and we should add this to the list of similar projects, if we keep one). Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-/3W1pnbCb+t+qwgxz24N Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlbF+BsACgkQk4XaBE3IOsSjawCgiPqSQEKgqfv9q8WjgqeOLfjx 17EAniia5GOyXqeeUWdTTQz81Yy8nriG =Errt -----END PGP SIGNATURE----- --=-/3W1pnbCb+t+qwgxz24N-- --===============4646820978375270368== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4646820978375270368==--