Re: [PATCH-v2 1/2] mac80211: Take bitrates into account when building IEs.

[Johannes Berg <johannes@sipsolutions.net>]

On Thu, 2016-02-18 at 12:40 -0800, Ben Greear wrote:

> > 1) sdata->sband[5GHZ].vht = wiphy->sband[5GHZ].vht & user-config
> >     (semantically, not implementation of course)
> > 2) sdata->sband[5GHZ].vht = wiphy->sband[5GHZ].vht

> I think option 1 might be better.  For option 2, I'd be worried about
> someone changing the wiphy somehow and vdevs getting out of sync.

Huh? I'm confused. Those two options above weren't meant as options,
they were meant as two sides of an "if (have-user-config)" branch :)

> Any opinions on the lifetime for the sdata->sband_user_config data?
> 
> For instance, could be cleared when station dis-associates,
> or we could make it persist until changed or until vdev goes away?

Should probably persist.

> And, while this would take care of some of the issues (3x3 vs 2x2?),
> it still wouldn't let someone have full control over the advertised
> rates vs configured-rates and such, would it?

Why not? The sband also contains the rates list. I was just using VHT
as an example.


johannes