All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Randy Witt <randy.e.witt@linux.intel.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 3/3] populate_sdk_ext.bbclass: Add SDK_RECRDEP_TASKS variable
Date: Thu, 18 Feb 2016 22:57:14 +0000	[thread overview]
Message-ID: <1455836234.28376.100.camel@linuxfoundation.org> (raw)
In-Reply-To: <941d876fe835bc1aa26039d0edec9573d482bca3.1455815778.git.randy.e.witt@linux.intel.com>

On Thu, 2016-02-18 at 09:17 -0800, Randy Witt wrote:
> Currently there isn't a way for the extensible sdk to know all the
> tasks
> that will need sstate for an image. This is because a layer can add
> it's
> on custom tasks that are required for an image to be generated.
> 
> The extensible sdk solved this for poky by using recrdeptask and
> specifying the tasks known to be required for the image as well as
> for
> building new recipes.
> 
> So the SDK_RECRDEP_TASKS variable allows a user to specify additional
> tasks that need to be pulled in.
> 
> Signed-off-by: Randy Witt <randy.e.witt@linux.intel.com>
> ---
>  meta/classes/populate_sdk_ext.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/populate_sdk_ext.bbclass
> b/meta/classes/populate_sdk_ext.bbclass
> index 7c95301..5f90aea 100644
> --- a/meta/classes/populate_sdk_ext.bbclass
> +++ b/meta/classes/populate_sdk_ext.bbclass
> @@ -359,7 +359,7 @@ addtask sdk_depends
>  do_sdk_depends[dirs] = "${WORKDIR}"
>  do_sdk_depends[depends] = "${@get_ext_sdk_depends(d)}"
>  do_sdk_depends[recrdeptask] = "${@d.getVarFlag('do_populate_sdk',
> 'recrdeptask', False)}"
> -do_sdk_depends[recrdeptask] += "do_populate_lic do_package_qa
> do_populate_sysroot do_deploy"
> +do_sdk_depends[recrdeptask] += "do_populate_lic do_package_qa
> do_populate_sysroot do_deploy ${SDK_RECRDEP_TASKS}"
>  do_sdk_depends[rdepends] = "${@get_sdk_ext_rdepends(d)}"
>  
>  def get_sdk_ext_rdepends(d):

Doesn't this need a default value or it will throw parse failures?

Cheers,

Richard


  reply	other threads:[~2016-02-18 22:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-18 17:17 [PATCH 0/3] extsdk bug fixes Randy Witt
2016-02-18 17:17 ` [PATCH 1/3] populate_sdk_ext: Don't ignore SDK_TARGETS value Randy Witt
2016-02-18 17:17 ` [PATCH 2/3] devtool: Don't recursively look for .devtoolbase in --basepath Randy Witt
2016-02-18 17:17 ` [PATCH 3/3] populate_sdk_ext.bbclass: Add SDK_RECRDEP_TASKS variable Randy Witt
2016-02-18 22:57   ` Richard Purdie [this message]
2016-02-19  4:34     ` Randy Witt
2016-02-19  4:42   ` [PATCH v2 " Randy Witt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455836234.28376.100.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=randy.e.witt@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.