From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43297)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1aWfCT-0003xE-8V
	for qemu-devel@nongnu.org; Fri, 19 Feb 2016 02:10:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1aWfCO-0007jj-A8
	for qemu-devel@nongnu.org; Fri, 19 Feb 2016 02:10:01 -0500
Message-ID: <1455865794.29896.3.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Fri, 19 Feb 2016 08:09:54 +0100
In-Reply-To: <1455823860-22268-1-git-send-email-lersek@redhat.com>
References: <1455823860-22268-1-git-send-email-lersek@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] fw_cfg: unbreak migration compatibility
 for 2.4 and earlier machines
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Marc Mar? <markmb@redhat.com>, qemu-devel@nongnu.org, Alexandre DERUMIER <aderumier@odiso.com>, qemu-stable@nongnu.org

On Do, 2016-02-18 at 20:31 +0100, Laszlo Ersek wrote:
> When I reviewed Marc's fw_cfg DMA patches, I completely missed that the
> way we set dma_enabled would break migration.

Patch looks fine to me ...

>     Not tested:
>     * actual migration
>     * when board code doesn't request DMA support
>    =20
>     Testing feedback from people who use migration would be nice.

... but some actual migration testing would be great indeed.

thanks,
  Gerd