All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: broonie@kernel.org
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
	lgirdwood@gmail.com
Subject: [PATCH 1/4] ASoC: wm_adsp: Avoid narrow race condition on compr pointer
Date: Fri, 19 Feb 2016 14:44:41 +0000	[thread overview]
Message-ID: <1455893084-4556-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> (raw)

There is a very small window between then wm_adsp_compr_free gets call
and when the DSP is actually powered down. If we get an IRQ from the DSP
in this window then the wm_adsp_compr pointer will be NULL. This patch
adds a check for this into the IRQ handler to avoid any issues when this
happens.

Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
 sound/soc/codecs/wm_adsp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c
index ed90e12..00a7d68 100644
--- a/sound/soc/codecs/wm_adsp.c
+++ b/sound/soc/codecs/wm_adsp.c
@@ -2857,7 +2857,7 @@ int wm_adsp_compr_handle_irq(struct wm_adsp *dsp)
 		goto out;
 	}
 
-	if (compr->stream)
+	if (compr && compr->stream)
 		snd_compr_fragment_elapsed(compr->stream);
 
 out:
-- 
2.1.4

             reply	other threads:[~2016-02-19 14:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-19 14:44 Charles Keepax [this message]
2016-02-19 14:44 ` [PATCH 2/4] ASoC: wm_adsp: Explicitly set the control access flags in all cases Charles Keepax
2016-02-20 18:10   ` Applied "ASoC: wm_adsp: Explicitly set the control access flags in all cases" to the asoc tree Mark Brown
2016-02-19 14:44 ` [PATCH 3/4] ASoC: wm_adsp: Fixup some odd line wrapping Charles Keepax
2016-02-20 18:10   ` Applied "ASoC: wm_adsp: Fixup some odd line wrapping" to the asoc tree Mark Brown
2016-02-19 14:44 ` [PATCH 4/4] ASoC: wm_adsp: wm_coeff_{read|write}_control should use passed length Charles Keepax
2016-02-20 18:10   ` Applied "ASoC: wm_adsp: wm_coeff_{read|write}_control should use passed length" to the asoc tree Mark Brown
2016-02-20 18:10 ` Applied "ASoC: wm_adsp: Avoid narrow race condition on compr pointer" " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455893084-4556-1-git-send-email-ckeepax@opensource.wolfsonmicro.com \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.