From: Joe Perches <joe@perches.com>
To: Simon Quigley <tsimonq2@ubuntu.com>, clm@fb.com
Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters
Date: Sat, 20 Feb 2016 16:02:30 -0800 [thread overview]
Message-ID: <1456012950.4031.17.camel@perches.com> (raw)
In-Reply-To: <1455992258-9176-1-git-send-email-tsimonq2@ubuntu.com>
On Sat, 2016-02-20 at 12:17 -0600, Simon Quigley wrote:
> checkpatch.pl reported a warning of over 80 characters on line 1833
[]
> diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
[]
> @@ -1830,7 +1830,11 @@ static int iterate_inode_extrefs(u64 inum, struct btrfs_root *fs_root,
> unsigned long ptr;
>
> while (1) {
> - ret = btrfs_find_one_extref(fs_root, inum, offset, path, &extref,
> + ret = btrfs_find_one_extref(fs_root,
> + inum,
> + offset,
> + path,
> + &extref,
> &offset);
I think this is poor because all the arguments aren't aligned.
It'd be nicer like:
ret = btrfs_find_one_extref(fs_root, inum, offset, path,
&extref, &offset);
next prev parent reply other threads:[~2016-02-21 0:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 18:17 [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters Simon Quigley
2016-02-21 0:02 ` Joe Perches [this message]
2016-02-21 0:56 ` [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 Simon Quigley
2016-02-21 0:57 ` Simon Quigley
2016-02-21 1:49 ` Joe Perches
2016-02-21 2:06 ` [PATCH] btrfs: backref: Fixed checkpatch warning of over 80 characters Simon Quigley
2016-02-21 2:08 ` Simon Quigley
2016-02-22 11:57 ` David Sterba
2016-02-22 12:10 ` Simon Quigley
2016-02-22 12:33 ` David Sterba
2016-02-22 12:36 ` Simon Quigley
-- strict thread matches above, loose matches on Subject: below --
2016-02-20 18:16 Simon Quigley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456012950.4031.17.camel@perches.com \
--to=joe@perches.com \
--cc=clm@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tsimonq2@ubuntu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.