From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Ming Lei <ming.lei@canonical.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: set firmware_buf size in fw_get_filesystem_firmware()
Date: Sun, 21 Feb 2016 08:46:51 -0500 [thread overview]
Message-ID: <1456062411.6604.8.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160221050128.GA563@swordfish>
On Sun, 2016-02-21 at 14:01 +0900, Sergey Senozhatsky wrote:
> Hello,
>
> On (02/20/16 22:59), Mimi Zohar wrote:
> > On Sat, 2016-02-20 at 18:22 +0900, Sergey Senozhatsky wrote:
> > > Set firmware_buf->size in fw_get_filesystem_firmware() after
> > > successful kernel_read_file_from_path(), otherwise assign_firmware_buf()
> > > fails.
> > >
> > > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > > ---
> > > drivers/base/firmware_class.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
> > > index b8bc846..7cf41a5 100644
> > > --- a/drivers/base/firmware_class.c
> > > +++ b/drivers/base/firmware_class.c
> > > @@ -335,6 +335,7 @@ static int fw_get_filesystem_firmware(struct device *device,
> > > }
> > > dev_dbg(device, "direct-loading %s\n",
> > > buf->fw_id);
> > > + buf->size = size;
> > > fw_finish_direct_load(device, buf);
> > > break;
> > > }
> >
> > Thanks, Sergey.
> >
> > Somehow this was dropped in v4.
>
> sure, no prob.
> if there is a way to fold this small fix into the original patch, then I wouldn't
> mind at all to go with this option.
Will do, thanks.
>
> The other thing is that, the dmesg output has changed, and now it keeps the
> log of unsuccessful ucode accesses from ->ucode_api_max to ->ucode_api_min:
>
> [ 1.236866] Unable to open file: /lib/firmware/updates/4.5.0-rc4-mm1-dbg-00407-g2edf49f-dirty/iwlwifi-7260-17.ucode (-2)
> [ 1.236874] iwlwifi 0000:02:00.0: loading /lib/firmware/updates/4.5.0-rc4-mm1-dbg-00407-g2edf49f-dirty/iwlwifi-7260-17.ucode failed with error -2
> [ 1.236889] Unable to open file: /lib/firmware/updates/iwlwifi-7260-17.ucode (-2)
> [ 1.236894] iwlwifi 0000:02:00.0: loading /lib/firmware/updates/iwlwifi-7260-17.ucode failed with error -2
> [ 1.237064] Unable to open file: /lib/firmware/4.5.0-rc4-mm1-dbg-00407-g2edf49f-dirty/iwlwifi-7260-17.ucode (-2)
> [ 1.237073] iwlwifi 0000:02:00.0: loading /lib/firmware/4.5.0-rc4-mm1-dbg-00407-g2edf49f-dirty/iwlwifi-7260-17.ucode failed with error -2
> [ 1.237094] Unable to open file: /lib/firmware/iwlwifi-7260-17.ucode (-2)
> [ 1.237099] iwlwifi 0000:02:00.0: loading /lib/firmware/iwlwifi-7260-17.ucode failed with error -2
> [ 1.237106] iwlwifi 0000:02:00.0: Direct firmware load for iwlwifi-7260-17.ucode failed with error -2
> [ 1.237190] Unable to open file: /lib/firmware/updates/4.5.0-rc4-mm1-dbg-00407-g2edf49f-dirty/iwlwifi-7260-16.ucode (-2)
> [ 1.237195] iwlwifi 0000:02:00.0: loading /lib/firmware/updates/4.5.0-rc4-mm1-dbg-00407-g2edf49f-dirty/iwlwifi-7260-16.ucode failed with error -2
> [ 1.237201] Unable to open file: /lib/firmware/updates/iwlwifi-7260-16.ucode (-2)
> [ 1.237204] iwlwifi 0000:02:00.0: loading /lib/firmware/updates/iwlwifi-7260-16.ucode failed with error -2
> [ 1.237217] Unable to open file: /lib/firmware/4.5.0-rc4-mm1-dbg-00407-g2edf49f-dirty/iwlwifi-7260-16.ucode (-2)
> [ 1.237221] iwlwifi 0000:02:00.0: loading /lib/firmware/4.5.0-rc4-mm1-dbg-00407-g2edf49f-dirty/iwlwifi-7260-16.ucode failed with error -2
>
>
> is this intentional? is there any reason to give this info back to user or
> this is just a small regression?
Thank you for pointing this out. The move from
kernel_read_file_from_fd() to kernel_read_from_path() introduced this
change. Neither function should display errors.
Mimi
next prev parent reply other threads:[~2016-02-21 18:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 9:14 [PATCH] firmware: set firmware_buf size in kernel_read_file_from_path() Sergey Senozhatsky
2016-02-20 9:21 ` Sergey Senozhatsky
2016-02-20 9:22 ` [PATCH] firmware: set firmware_buf size in fw_get_filesystem_firmware() Sergey Senozhatsky
[not found] ` <1456027178.2906.196.camel@linux.vnet.ibm.com>
2016-02-21 5:01 ` Sergey Senozhatsky
2016-02-21 13:46 ` Mimi Zohar [this message]
2016-02-21 9:46 ` Ming Lei
2016-02-23 7:20 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456062411.6604.8.camel@linux.vnet.ibm.com \
--to=zohar@linux.vnet.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.