From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752236AbcBUWar (ORCPT ); Sun, 21 Feb 2016 17:30:47 -0500 Received: from smtprelay0141.hostedemail.com ([216.40.44.141]:37686 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751460AbcBUWaq (ORCPT ); Sun, 21 Feb 2016 17:30:46 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:968:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:4321:5007:6261:7903:7974:10004:10400:10848:11026:11232:11658:11914:12517:12519:12740:13069:13311:13357:13894:14659:21080:30034:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: flock58_79d1d9adfbd4e X-Filterd-Recvd-Size: 1457 Message-ID: <1456093820.31061.7.camel@perches.com> Subject: Re: [PATCH 1/8] tty: n_gsm: fix formatting errors From: Joe Perches To: Andrej Krpic , linux-kernel@vger.kernel.org Cc: jslaby@suse.com, gregkh@linuxfoundation.org Date: Sun, 21 Feb 2016 14:30:20 -0800 In-Reply-To: <1456090717-19913-2-git-send-email-ak77@tnode.com> References: <1456090717-19913-1-git-send-email-ak77@tnode.com> <1456090717-19913-2-git-send-email-ak77@tnode.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-02-21 at 22:38 +0100, Andrej Krpic wrote: > Minor formatting changes to remove errors and reduce number of > warnings produced by checkpatch.pl script. [] > diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c [] > @@ -489,7 +490,8 @@ static void gsm_print_packet(const char *hdr, int addr, int cr, >   if (!(control & 0x01)) { >   pr_cont("I N(S)%d N(R)%d", >   (control & 0x0E) >> 1, (control & 0xE0) >> 5); > - } else switch (control & 0x0F) { > + } else > + switch (control & 0x0F) { Please follow the brace rule for else uses where if one branch has braces, the other does too.