All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Philippe Loctaux <phil@philippeloctaux.com>
Cc: jbacik@fb.com, dsterba@suse.com, linux-btrfs@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Btrfs: ctree: added lines after variable declarations
Date: Sun, 21 Feb 2016 16:06:03 -0800	[thread overview]
Message-ID: <1456099563.31061.12.camel@perches.com> (raw)
In-Reply-To: <20160222000107.GA11444@carbon.home>

On Mon, 2016-02-22 at 01:01 +0100, Philippe Loctaux wrote:
> Is there no need of additional blank line here particulary
> or in all lines that I changed?

Please don't top post and just here.
> On Sun, Feb 21, 2016 at 03:53:04PM -0800, Joe Perches wrote:
> > On Mon, 2016-02-22 at 00:46 +0100, Philippe Loctaux wrote:
> > > Added lines after variable declarations, fixing 22 checkpatch warnings.
> > []
> > > diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
> > []
> > > @@ -4592,6 +4610,7 @@ void btrfs_truncate_item(struct btrfs_root *root, struct btrfs_path *path,
> > >  			      data_end, old_data_start + new_size - data_end);
> > >  	} else {
> > >  		struct btrfs_disk_key disk_key;
> > > +
> > >  		u64 offset;
> > 
> > Overzealous here.
> > No additional blank line required.

  reply	other threads:[~2016-02-22  0:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-21 23:46 [PATCH] Btrfs: ctree: added lines after variable declarations Philippe Loctaux
2016-02-21 23:53 ` Joe Perches
2016-02-22  0:01   ` Philippe Loctaux
2016-02-22  0:06     ` Joe Perches [this message]
2016-02-22  0:31       ` Philippe Loctaux
2016-02-22  0:44         ` Joe Perches
2016-02-22  7:22           ` Philippe Loctaux
2016-02-22 22:49             ` Duncan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456099563.31061.12.camel@perches.com \
    --to=joe@perches.com \
    --cc=dsterba@suse.com \
    --cc=jbacik@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phil@philippeloctaux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.