From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Alexander Shashkevich <alex@stunpix.com>,
bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH] bb/fetch2: broken functionality for entries like file://dir; subdir=foo in SRC_URI
Date: Mon, 22 Feb 2016 20:51:18 +0000 [thread overview]
Message-ID: <1456174278.28376.199.camel@linuxfoundation.org> (raw)
In-Reply-To: <1456166091-13075-1-git-send-email-alex@stunpix.com>
On Mon, 2016-02-22 at 20:34 +0200, Alexander Shashkevich wrote:
> For SRC_URI entries like file://dir1;subdir=foo1 and
> file://dir2/dir3;subdir=foo2/foo3
> subdirectories ${WORKDIR}/foo1 and ${WORKDIR}/foo2/foo3 are created,
> but dir1 and dir2/dir3 are
> only copied to ${WORKDIR}/dir1 and ${WORKDIR}/dir2/dir. Correct way:
> directories must be copied/unpacked
> into '${WORKDIR}/foo1/dir1' and '${WORKDIR}/foo2/foo3/dir2/dir'
> respectively.
Where we have cases like this, I'd ask that you add a test case to
lib/bb/tests/ which illustrates the problem and ensures we don't
regress in future. We've had far too many problems with corner cases
and the fetcher :(
I need to properly review the patch but wanted to mention this now.
Cheers,
Richard
next prev parent reply other threads:[~2016-02-22 20:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 18:34 [PATCH] bb/fetch2: broken functionality for entries like file://dir; subdir=foo in SRC_URI Alexander Shashkevich
2016-02-22 20:51 ` Richard Purdie [this message]
2016-02-23 21:45 ` Sasha Shashkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456174278.28376.199.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=alex@stunpix.com \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.