From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932249AbcBWAhN (ORCPT ); Mon, 22 Feb 2016 19:37:13 -0500 Received: from smtprelay0171.hostedemail.com ([216.40.44.171]:45011 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755859AbcBWAhL (ORCPT ); Mon, 22 Feb 2016 19:37:11 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1567:1593:1594:1711:1714:1730:1747:1777:1792:2198:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3867:3868:3872:4321:5007:6261:10004:10400:10848:11026:11232:11473:11657:11658:11914:12043:12517:12519:12740:13069:13311:13357:13894:14659:21080:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: pie85_78ad2da63b052 X-Filterd-Recvd-Size: 1385 Message-ID: <1456187828.4139.3.camel@perches.com> Subject: Re: [PATCH] Staging: comedi: mite: added spaces around | and * From: Joe Perches To: Philippe Loctaux , gregkh@linuxfoundation.org Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Mon, 22 Feb 2016 16:37:08 -0800 In-Reply-To: <1456184291-30665-1-git-send-email-phil@philippeloctaux.com> References: <1456184291-30665-1-git-send-email-phil@philippeloctaux.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-02-23 at 00:38 +0100, Philippe Loctaux wrote: > Added spaces around | and *, fixing 2 checkpatch checks. [] > diff --git a/drivers/staging/comedi/drivers/mite.c b/drivers/staging/comedi/drivers/mite.c [] > @@ -51,7 +51,7 @@ >   >  #include "mite.h" >   > -#define TOP_OF_PAGE(x) ((x)|(~(PAGE_MASK))) > +#define TOP_OF_PAGE(x) ((x) | (~(PAGE_MASK))) It'd be nice to remove superfluous parentheses here too +#define TOP_OF_PAGE(x) ((x) | ~PAGE_MASK)