All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: bp@alien8.de, hpa@zytor.com, tglx@linutronix.de,
	mingo@redhat.com, rusty@rustcorp.com.au
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	luto@amacapital.net, boris.ostrovsky@oracle.com,
	david.vrabel@citrix.com, konrad.wilk@oracle.com,
	xen-devel@lists.xensource.com, lguest@lists.ozlabs.org,
	"Luis R. Rodriguez" <mcgrof@kernel.org>
Subject: [PATCH v3 09/11] x86/boot: add BIT() to boot/bitops.h
Date: Mon, 22 Feb 2016 23:24:13 -0800	[thread overview]
Message-ID: <1456212255-23959-10-git-send-email-mcgrof@kernel.org> (raw)
In-Reply-To: <1456212255-23959-1-git-send-email-mcgrof@kernel.org>

The boot/bitops.h has guards against including the
regular bitops (include/asm-generic/bitops.h), it only
implements what we need at early boot. We'll be making
use of BIT() later so add it.

Users of boot/boot.h must include it prior to asm/setup.h
otherwise the guard protection devised against the regular
linux/bitops.h will not take effect.

v2: spelling fixes, and language descriptipon enhancements
    by Konrad.
v3: Parenthesize (x), just match what is in include/linux/bitmap.h

Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
 arch/x86/boot/bitops.h | 2 ++
 arch/x86/boot/boot.h   | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/x86/boot/bitops.h b/arch/x86/boot/bitops.h
index 878e4b9940d9..cfe154c0bd3d 100644
--- a/arch/x86/boot/bitops.h
+++ b/arch/x86/boot/bitops.h
@@ -40,4 +40,6 @@ static inline void set_bit(int nr, void *addr)
 	asm("btsl %1,%0" : "+m" (*(u32 *)addr) : "Ir" (nr));
 }
 
+#define BIT(nr)	(1UL << (nr))
+
 #endif /* BOOT_BITOPS_H */
diff --git a/arch/x86/boot/boot.h b/arch/x86/boot/boot.h
index 9011a88353de..4fb53da1f48a 100644
--- a/arch/x86/boot/boot.h
+++ b/arch/x86/boot/boot.h
@@ -23,8 +23,8 @@
 #include <stdarg.h>
 #include <linux/types.h>
 #include <linux/edd.h>
-#include <asm/setup.h>
 #include "bitops.h"
+#include <asm/setup.h>
 #include "ctype.h"
 #include "cpuflags.h"
 
-- 
2.7.0

  parent reply	other threads:[~2016-02-23  7:25 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-23  7:24 [PATCH v3 00/11] x86/init: replace paravirt_enabled() were possible Luis R. Rodriguez
2016-02-23  7:24 ` [PATCH v3 01/11] x86/boot: enumerate documentation for the x86 hardware_subarch Luis R. Rodriguez
2016-02-23  8:51   ` Ingo Molnar
2016-02-23 10:34     ` Luis R. Rodriguez
2016-02-23 20:41       ` Luis R. Rodriguez
2016-02-24  8:32         ` Ingo Molnar
2016-02-24 16:40           ` Andy Lutomirski
     [not found]             ` <CAB=NE6X0S-iXV_0t+JEE9zstE-+CfVZrU-WidyMk1dPJMi-hhQ@mail.gmail.com>
2016-02-25  1:29               ` Andy Lutomirski
2016-02-25  8:10             ` Ingo Molnar
2016-03-02  0:43           ` Luis R. Rodriguez
2016-03-02 19:40             ` Luis R. Rodriguez
2016-04-07 20:59           ` Luis R. Rodriguez
2016-02-23  7:24 ` [PATCH v3 02/11] tools/lguest: make lguest launcher use X86_SUBARCH_LGUEST explicitly Luis R. Rodriguez
2016-02-23  7:24 ` [PATCH v3 03/11] x86/xen: use X86_SUBARCH_XEN for PV guest boots Luis R. Rodriguez
2016-02-23  7:24 ` [PATCH v3 04/11] x86/init: make ebda depend on PC subarch Luis R. Rodriguez
2016-02-23  7:24 ` [PATCH v3 05/11] tools/lguest: force disable tboot and apm Luis R. Rodriguez
2016-02-23  7:24 ` [PATCH v3 06/11] apm32: remove paravirt_enabled() use Luis R. Rodriguez
2016-02-23  7:24 ` [PATCH v3 07/11] x86/tboot: remove paravirt_enabled() Luis R. Rodriguez
2016-02-23  7:24 ` [PATCH v3 08/11] x86/cpu/intel: replace paravirt_enabled() for f00f work around Luis R. Rodriguez
2016-02-23  7:24 ` Luis R. Rodriguez [this message]
2016-02-23  7:24 ` [PATCH v3 10/11] x86/rtc: replace paravirt rtc check with x86 specific solution Luis R. Rodriguez
2016-02-23 11:57   ` [Xen-devel] " David Vrabel
2016-02-23 18:10     ` Luis R. Rodriguez
2016-02-23  7:24 ` [PATCH v3 11/11] pnpbios: replace paravirt_enabled() check with subarch checks Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456212255-23959-10-git-send-email-mcgrof@kernel.org \
    --to=mcgrof@kernel.org \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=david.vrabel@citrix.com \
    --cc=hpa@zytor.com \
    --cc=konrad.wilk@oracle.com \
    --cc=lguest@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@redhat.com \
    --cc=rusty@rustcorp.com.au \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.