From: Johannes Berg <johannes@sipsolutions.net>
To: Avery Pennarun <apenwarr@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
ath9k-devel@vger.kernel.org, nbd@nbd.name
Subject: Re: [PATCH] mac80211: debugfs var for the default aggregation timeout.
Date: Tue, 23 Feb 2016 11:14:01 +0100 [thread overview]
Message-ID: <1456222441.2041.10.camel@sipsolutions.net> (raw)
In-Reply-To: <1455658091-28262-2-git-send-email-apenwarr@gmail.com> (sfid-20160216_222826_373181_FA784E45)
On Tue, 2016-02-16 at 16:28 -0500, Avery Pennarun wrote:
> Since around the beginning of time, ath9k aggregates have timed out
> after
> 5000 TU (around 5000ms) of inactivity, but nobody seems to be quite
> sure
> why, and this magic number seems to have migrated around from one
> place to
> another. An openbsd mailing list recently had a patch to disable the
> timeout completely, which they say matches some commercial routers:
> https://www.mail-archive.com/tech@openbsd.org/msg29456.html
>
> Even in Linux, several non-ath9k drivers default to no timeout
> already. I
> think changing it directly to zero would be safe, but to allow a more
> structured investigation, let's make it configurable for now.
>
Since we just made it zero, perhaps we don't need this?
Although perhaps we still want it to be able to debug it?
Anyway - you shouldn't create a debugfs file and play with the extern
stuff etc., let minstrel create the debugfs file in minstrel_ht_alloc()
johannes
next prev parent reply other threads:[~2016-02-23 10:14 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 5:03 ath9k(?): AP stops sending traffic to iPhone 4S until another 802.11n-capable STA joins Avery Pennarun
2016-02-16 21:28 ` Avery Pennarun
2016-02-16 21:28 ` [PATCH] mac80211: debugfs var for the default aggregation timeout Avery Pennarun
2016-02-16 21:44 ` Johannes Berg
2016-02-17 2:05 ` Sujith Manoharan
2016-02-23 10:14 ` Johannes Berg [this message]
2016-02-23 18:43 ` Avery Pennarun
2016-02-23 20:05 ` Johannes Berg
2016-04-05 23:46 ` [ath9k-devel] " Avery Pennarun
2016-04-05 23:46 ` Avery Pennarun
2016-04-06 7:40 ` [ath9k-devel] " Johannes Berg
2016-04-06 7:40 ` Johannes Berg
2016-04-08 1:32 ` [ath9k-devel] " Avery Pennarun
2016-04-08 1:32 ` Avery Pennarun
2016-04-08 6:56 ` [ath9k-devel] " Johannes Berg
2016-04-08 6:56 ` Johannes Berg
2016-04-08 7:01 ` [ath9k-devel] " Johannes Berg
2016-04-08 7:01 ` Johannes Berg
2016-04-08 7:15 ` [ath9k-devel] " Johannes Berg
2016-04-08 7:15 ` Johannes Berg
2016-04-08 8:31 ` [ath9k-devel] " Avery Pennarun
2016-04-08 8:31 ` Avery Pennarun
2016-04-09 1:27 ` [ath9k-devel] " Avery Pennarun
2016-04-09 1:27 ` Avery Pennarun
2016-04-09 4:56 ` [ath9k-devel] " Johannes Berg
2016-04-09 4:56 ` Johannes Berg
2016-04-10 0:31 ` [ath9k-devel] " Adrian Chadd
2016-04-10 0:31 ` Adrian Chadd
2016-04-10 1:59 ` bruce m beach
2016-04-10 2:12 ` [ath9k-devel] " bruce m beach
2016-04-19 1:29 ` Avery Pennarun
2016-04-19 1:29 ` Avery Pennarun
2016-02-16 22:05 ` ath9k(?): AP stops sending traffic to iPhone 4S until another 802.11n-capable STA joins Johannes Berg
2016-02-17 4:32 ` Avery Pennarun
2016-02-17 6:23 ` Krishna Chaitanya
2016-02-17 7:05 ` Avery Pennarun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456222441.2041.10.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=apenwarr@gmail.com \
--cc=ath9k-devel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.