From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2] xl: close nullfd after dup2'ing it to stdin Date: Tue, 23 Feb 2016 10:30:31 +0000 Message-ID: <1456223431.6225.124.camel@citrix.com> References: <1455659662.15441.61.camel@citrix.com> <1455705580-27781-1-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1455705580-27781-1-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: ian.jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org Cc: andrew.cooper3@citrix.com List-Id: xen-devel@lists.xenproject.org T24gV2VkLCAyMDE2LTAyLTE3IGF0IDEwOjM5ICswMDAwLCBJYW4gQ2FtcGJlbGwgd3JvdGU6Cj4g V2UgYXNzZXJ0IHRoYXQgbnVsbGZkIGlmIG5vdCBzdGR7aW4sb3V0LGVycn0gc2luY2UgdGhhdCB3 b3VsZCByZXN1bHQKPiBpbiBjbG9zaW5nIG9uZSBvZiB0aGUganVzdCBkdXAyJ2QgZmRzLiBGb3Ig dGhpcyB0byBoYXBwZW4KPiBzdGR7aW4sb3V0LGVycn0gd291bGQgaGF2ZSBuZWVkZWQgdG8gYmUg Y2xvc2VkLCBhdCB3aGljaCBwb2ludCBhbGwKPiBzb3J0cyBvZiBvdGhlciB0aGluZ3MgY291bGQg Z28gd3JvbmcuCj4gCj4gQ0lEOiAxMTMwNTE5Cj4gCj4gSXQgd2FzIHByZXZpb3VzbHkgaHlwb3Ro ZXNpc2VkWzBdIHRoYXQgZml4aW5nIDExMzA1MTYgd291bGQgc29sdmUgdGhpcwo+IHRvbywgYnV0 IHRoYXQgYXBwZWFycyB0byBub3QgaGF2ZSBiZWVuIHRoZSBjYXNlLgo+IAo+IENvbXBpbGUgdGVz dGVkIG9ubHkuCj4gCj4gWzBdIGh0dHA6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9hcmNoaXZlcy9o dG1sL3hlbi1kZXZlbC8yMDEzLTExL21zZzAyOTMxLgo+IGh0bWwKPiAKPiBTaWduZWQtb2ZmLWJ5 OiBJYW4gQ2FtcGJlbGwgPGlhbi5jYW1wYmVsbEBjaXRyaXguY29tPgo+IENjOiBhbmRyZXcuY29v cGVyM0BjaXRyaXguY29tCgpwaW5nPwoKPiAtLS0KPiB2MjogQXNzZXJ0IGxvZ2ZpbGUgYW5kIG51 bGxmZCBhcmUgbm90IHN0ZGlvIGZkcwo+IC0tLQo+IMKgdG9vbHMvbGlieGwveGxfY21kaW1wbC5j IHwgNSArKysrKwo+IMKgMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYg LS1naXQgYS90b29scy9saWJ4bC94bF9jbWRpbXBsLmMgYi90b29scy9saWJ4bC94bF9jbWRpbXBs LmMKPiBpbmRleCA5OTU4ZDhhLi5hMzc3ZGUxIDEwMDY0NAo+IC0tLSBhL3Rvb2xzL2xpYnhsL3hs X2NtZGltcGwuYwo+ICsrKyBiL3Rvb2xzL2xpYnhsL3hsX2NtZGltcGwuYwo+IEBAIC00OTksMTIg KzQ5OSwxNyBAQCBzdGF0aWMgaW50IGRvX2RhZW1vbml6ZShjaGFyICpuYW1lLCBjb25zdCBjaGFy Cj4gKnBpZGZpbGUpCj4gwqAKPiDCoMKgwqDCoMKgQ0hLX1NZU0NBTEwobG9nZmlsZSA9IG9wZW4o ZnVsbG5hbWUsIE9fV1JPTkxZfE9fQ1JFQVR8T19BUFBFTkQsCj4gMDY0NCkpOwo+IMKgwqDCoMKg wqBmcmVlKGZ1bGxuYW1lKTsKPiArwqDCoMKgwqBhc3NlcnQobG9nZmlsZSA+PSAzKTsKPiDCoAo+ IMKgwqDCoMKgwqBDSEtfU1lTQ0FMTChudWxsZmQgPSBvcGVuKCIvZGV2L251bGwiLCBPX1JET05M WSkpOwo+ICvCoMKgwqDCoGFzc2VydChudWxsZmQgPj0gMyk7Cj4gKwo+IMKgwqDCoMKgwqBkdXAy KG51bGxmZCwgMCk7Cj4gwqDCoMKgwqDCoGR1cDIobG9nZmlsZSwgMSk7Cj4gwqDCoMKgwqDCoGR1 cDIobG9nZmlsZSwgMik7Cj4gwqAKPiArwqDCoMKgwqBjbG9zZShudWxsZmQpOwo+ICsKPiDCoMKg wqDCoMKgQ0hLX1NZU0NBTEwoZGFlbW9uKDAsIDEpKTsKPiDCoAo+IMKgwqDCoMKgwqBpZiAocGlk ZmlsZSkgewoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K WGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlz dHMueGVuLm9yZy94ZW4tZGV2ZWwK