From: Imre Deak <imre.deak@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [RFC] drm/i915: Check if we hold a wakeref during ioread32/iowrite32
Date: Tue, 23 Feb 2016 17:09:29 +0200 [thread overview]
Message-ID: <1456240169.573.8.camel@intel.com> (raw)
In-Reply-To: <20160223145539.GL27386@nuc-i3427.alporthouse.com>
On ti, 2016-02-23 at 14:55 +0000, Chris Wilson wrote:
> On Tue, Feb 23, 2016 at 04:47:17PM +0200, Imre Deak wrote:
> > The device needs to be in D0 state whenever we call these
> > functions, so
> > add the corresponding assert checks.
>
> No. In quite a few of those cases we are calling iowrite to non-
> device
> memory, even normal pages.
Hm right didn't think about that. I guess the only case we care about
then are accesses through the GTT.
> How's the separation of struct_mutex from rpm going so that we can
> forgo
> adding assertions and use explicit power management instead?
It's planned to be done, but no one is working on that yet. This is
something we could still have regardless, similarly to other helpers
accessing the device.
> -Chris
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-02-23 15:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 14:47 [RFC] drm/i915: Check if we hold a wakeref during ioread32/iowrite32 Imre Deak
2016-02-23 14:55 ` Chris Wilson
2016-02-23 15:09 ` Imre Deak [this message]
2016-02-23 16:54 ` Chris Wilson
2016-02-26 15:42 ` Imre Deak
2016-02-23 15:50 ` ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456240169.573.8.camel@intel.com \
--to=imre.deak@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.