All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, pkrempa@redhat.com, qemu-devel@nongnu.org,
	armbru@redhat.com, mreitz@redhat.com
Subject: [Qemu-devel] [PATCH 2/2] hmp: Extend drive_del to delete nodes without BB
Date: Tue, 23 Feb 2016 18:16:39 +0100	[thread overview]
Message-ID: <1456247799-9593-3-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1456247799-9593-1-git-send-email-kwolf@redhat.com>

Now that we can use drive_add to create new nodes without a BB, we also
want to be able to delete such nodes again.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 blockdev.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/blockdev.c b/blockdev.c
index 3f46bc1..b76b6cd 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -2816,6 +2816,15 @@ void hmp_drive_del(Monitor *mon, const QDict *qdict)
     AioContext *aio_context;
     Error *local_err = NULL;
 
+    bs = bdrv_find_node(id);
+    if (bs) {
+        qmp_x_blockdev_del(false, NULL, true, id, &local_err);
+        if (local_err) {
+            error_report_err(local_err);
+        }
+        return;
+    }
+
     blk = blk_by_name(id);
     if (!blk) {
         error_report("Device '%s' not found", id);
-- 
1.8.3.1

  parent reply	other threads:[~2016-02-23 17:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-23 17:16 [Qemu-devel] [PATCH 0/2] block: drive_add/del without BlockBackend Kevin Wolf
2016-02-23 17:16 ` [Qemu-devel] [PATCH 1/2] hmp: 'drive_add -n' for creating a node without BB Kevin Wolf
2016-02-24 17:50   ` Max Reitz
2016-02-24 18:24     ` Kevin Wolf
2016-02-25 13:18   ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2016-02-25 16:05     ` Eric Blake
2016-02-23 17:16 ` Kevin Wolf [this message]
2016-02-24 17:54   ` [Qemu-devel] [PATCH 2/2] hmp: Extend drive_del to delete nodes " Max Reitz
2016-02-24 18:23     ` Kevin Wolf
2016-02-26 13:09       ` Max Reitz
2016-02-25 12:51     ` Peter Krempa
2016-02-26 13:11       ` Max Reitz
2016-03-09 10:54 ` [Qemu-devel] [PATCH 0/2] block: drive_add/del without BlockBackend Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1456247799-9593-3-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=armbru@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pkrempa@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.