Re: [PATCHv2 2/2] testimage.bbclass: reuse generic test suites

[Benjamin Esquivel <benjamin.esquivel@linux.intel.com>]

Hi Franco, how did you test this? what is the behavior you get with
these defaults instead of how's behaving now?

See comments below.

On Tue, 2016-02-23 at 09:14 +0000, Alex Franco wrote:
> Modify existing default test suites to reuse the new
> generic test suites.
> 
> Related to [YOCTO #8410]
> 
> Signed-off-by: Alex Franco <alejandro.franco@linux.intel.com>
> ---
>  meta/classes/testimage.bbclass | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/meta/classes/testimage.bbclass
> b/meta/classes/testimage.bbclass
> index 791cce3..e77bb11 100644
> --- a/meta/classes/testimage.bbclass
> +++ b/meta/classes/testimage.bbclass
> @@ -37,17 +37,19 @@ MINTESTSUITE = "ping"
>  NETTESTSUITE = "${MINTESTSUITE} ssh df date scp syslog"
>  DEVTESTSUITE = "gcc kernelmodule ldd"
>  
> -DEFAULT_TEST_SUITES = "ping auto"
> -DEFAULT_TEST_SUITES_pn-core-image-minimal = "ping"
> +DEFAULT_TEST_SUITES = "${MINTESTSUITE} auto"
> +DEFAULT_TEST_SUITES_pn-core-image-minimal = "${MINTESTSUITE}"
>  DEFAULT_TEST_SUITES_pn-core-image-minimal-dev = "${MINTESTSUITE}"
>  DEFAULT_TEST_SUITES_pn-core-image-full-cmdline = "${NETTESTSUITE}
> perl python logrotate"
>  DEFAULT_TEST_SUITES_pn-core-image-x11 = "${MINTESTSUITE}"
>  DEFAULT_TEST_SUITES_pn-core-image-lsb = "${NETTESTSUITE} pam
> parselogs ${RPMTESTSUITE}"
> -DEFAULT_TEST_SUITES_pn-core-image-sato = "ping ssh df connman syslog
> xorg scp date parselogs ${RPMTESTSUITE} \
> +DEFAULT_TEST_SUITES_pn-core-image-sato = "${NETTESTSUITE} connman
> xorg parselogs ${RPMTESTSUITE} \
>      ${@bb.utils.contains('IMAGE_PKGTYPE', 'rpm', 'python', '', d)}"
> -DEFAULT_TEST_SUITES_pn-core-image-sato-sdk = "ping ssh df connman
> syslog xorg scp date perl ldd gcc kernelmodule python parselogs
> ${RPMTESTSUITE}"
> +DEFAULT_TEST_SUITES_pn-core-image-sato-sdk = "${NETTESTSUITE}
> connman xorg perl python \
> +    ${DEVTESTSUITE} parselogs ${RPMTESTSUITE}"
>  DEFAULT_TEST_SUITES_pn-core-image-lsb-dev = "${NETTESTSUITE} pam
> perl python parselogs ${RPMTESTSUITE}"
> -DEFAULT_TEST_SUITES_pn-core-image-lsb-sdk = "ping buildcvs
> buildiptables buildsudoku connman date df gcc kernelmodule ldd pam
> parselogs perl python scp ${RPMTESTSUITE} ssh syslog logrotate"
> +DEFAULT_TEST_SUITES_pn-core-image-lsb-sdk = "${NETTESTSUITE}
> buildcvs buildiptables buildsudoku \
> +    connman ${DEVTESTSUITE} pam perl python parselogs

These lots of declarations seem to be suited for a .inc file instead of
living in the bbclass.
> ${RPMTESTSUITE}"
>  DEFAULT_TEST_SUITES_pn-meta-toolchain = "auto"
>  
>  # aarch64 has no graphics
> -- 
> 2.6.2
>