From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 0/9] xl: convert exit codes related to domain subcommands to EXIT_[SUCCESS|FAILURE] Date: Thu, 25 Feb 2016 11:57:25 +0100 Message-ID: <1456397845.6288.74.camel@citrix.com> References: <1456318407-3635-1-git-send-email-write.harmandeep@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8286340326982884282==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.84) (envelope-from ) id 1aYtbv-0003NX-VV for xen-devel@lists.xenproject.org; Thu, 25 Feb 2016 10:57:32 +0000 In-Reply-To: <1456318407-3635-1-git-send-email-write.harmandeep@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Harmandeep Kaur , xen-devel@lists.xenproject.org Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org --===============8286340326982884282== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-JYA6CglhH58xKD/HQcs/" --=-JYA6CglhH58xKD/HQcs/ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2016-02-24 at 18:23 +0530, Harmandeep Kaur wrote: > *main_foo() is treated somewhat as a regular main(), it is changed to > return EXIT_SUCCESS or EXIT_FAILURE. >=20 > *Functions that are not main_foo(), are changed to do 'return 0' or > 'return 1', and then 0/1 is taken care in the main_foo() functions > that calls them. >=20 > *Functions in xl_cmdimpl.c related to domain subcommands are changed. >=20 > *This series perceds the following series: > http://lists.xenproject.org/archives/html/xen-devel/2015- > 10/msg02990.html >=20 You mean "precedes"? And even if yes, isn't it that this series you're sending now is a follow-up of the work at the link? Anyway, as I said when replying to Olaf, please, try to summarize a bit better the previous discussions we've had, and the work you have already done on this. > Signed-off-by: Harmandeep Kaur > Not that it matters much, but the cover letter needs not to be Signed- off-by. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-JYA6CglhH58xKD/HQcs/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEABECAAYFAlbO3hUACgkQk4XaBE3IOsQ1vgCfWSTswS7meJrS2wM2SAc9P7St P5EAoJ7bmphVFfzEGAgkwKv6OVEPwJv2 =bUu0 -----END PGP SIGNATURE----- --=-JYA6CglhH58xKD/HQcs/-- --===============8286340326982884282== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============8286340326982884282==--