From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760657AbcBYMPl (ORCPT ); Thu, 25 Feb 2016 07:15:41 -0500 Received: from mail-pa0-f53.google.com ([209.85.220.53]:33602 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760404AbcBYMPk (ORCPT ); Thu, 25 Feb 2016 07:15:40 -0500 Message-ID: <1456402534.25534.27.camel@gmail.com> Subject: Re: [PATCH] arch/x86: convert all printk(KERN_INFO ) to pr_info() From: Chen Yucong To: Ingo Molnar Cc: tglx@linutronix.de, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org, Borislav Petkov Date: Thu, 25 Feb 2016 20:15:34 +0800 In-Reply-To: <20160225082255.GA11930@gmail.com> References: <1456129300-27006-1-git-send-email-slaoub@gmail.com> <20160225082255.GA11930@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-02-25 at 09:22 +0100, Ingo Molnar wrote: > * Chen Yucong wrote: > > > arch/x86/* use a mixture of printk(KERN_INFO ) and pr_info(). > > This patch converts all of printk(KERN_INFO ) to pr_info() for > > arch/x86 directory. > > > > Signed-off-by: Chen Yucong > > > 85 files changed, 332 insertions(+), 394 deletions(-) > > So what this changelog is missing is how it was ensured that the printk output did > not change. > The previously committed patch was applied to a particular directory. This involved all printk(KERN_), including `ugly` pr_debug(). However this patch are only related to printk(KERN_INFO ...), pr_info() is less dangerous than pr_debug(). The macro body of pr_info() is simple and definite, without any conditional options. An theme to notice: this patch also refers to only a few pr_err(), and if it is feasible, the next patch will covert all printk(KERN_ERR ) to pr_err(). This might be a less risky way for conversion. thx! cyc