All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lluís Vilanova" <vilanova@ac.upc.edu>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH v9 4/7] tcg: Move definition of type TCGv
Date: Thu, 25 Feb 2016 17:43:21 +0100	[thread overview]
Message-ID: <145641860129.30295.17554707227384022653.stgit@localhost> (raw)
In-Reply-To: <145641857632.30295.407142116443473458.stgit@localhost>

The target-dependant type TCGv must be defined in "tcg/tcg.h" before
including the tracing helper wrappers in "tcg/tcg-op.h".

It also makes more sense to define it here, where other TCG types are
defined too.

Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
---
 tcg/tcg-op.h |    2 --
 tcg/tcg.h    |    7 +++++++
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h
index 4e20dc1..c446d3d 100644
--- a/tcg/tcg-op.h
+++ b/tcg/tcg-op.h
@@ -756,7 +756,6 @@ static inline void tcg_gen_exit_tb(uintptr_t val)
 void tcg_gen_goto_tb(unsigned idx);
 
 #if TARGET_LONG_BITS == 32
-#define TCGv TCGv_i32
 #define tcg_temp_new() tcg_temp_new_i32()
 #define tcg_global_reg_new tcg_global_reg_new_i32
 #define tcg_global_mem_new tcg_global_mem_new_i32
@@ -768,7 +767,6 @@ void tcg_gen_goto_tb(unsigned idx);
 #define tcg_gen_qemu_ld_tl tcg_gen_qemu_ld_i32
 #define tcg_gen_qemu_st_tl tcg_gen_qemu_st_i32
 #else
-#define TCGv TCGv_i64
 #define tcg_temp_new() tcg_temp_new_i64()
 #define tcg_global_reg_new tcg_global_reg_new_i64
 #define tcg_global_mem_new tcg_global_mem_new_i64
diff --git a/tcg/tcg.h b/tcg/tcg.h
index e7983be..b83f763 100644
--- a/tcg/tcg.h
+++ b/tcg/tcg.h
@@ -309,6 +309,13 @@ typedef struct TCGv_i32_d *TCGv_i32;
 typedef struct TCGv_i64_d *TCGv_i64;
 typedef struct TCGv_ptr_d *TCGv_ptr;
 typedef TCGv_ptr TCGv_env;
+#if TARGET_LONG_BITS == 32
+#define TCGv TCGv_i32
+#elif TARGET_LONG_BITS == 64
+#define TCGv TCGv_i64
+#else
+#error Unhandled TARGET_LONG_BITS value
+#endif
 
 static inline TCGv_i32 QEMU_ARTIFICIAL MAKE_TCGV_I32(intptr_t i)
 {

  parent reply	other threads:[~2016-02-25 16:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-25 16:42 [Qemu-devel] [PATCH v9 0/7] trace: Show vCPU info in guest code events Lluís Vilanova
2016-02-25 16:43 ` [Qemu-devel] [PATCH v9 1/7] trace: Extend API to manage event arguments Lluís Vilanova
2016-02-25 16:43 ` [Qemu-devel] [PATCH v9 2/7] trace: Remove unnecessary intermediate event copies Lluís Vilanova
2016-02-25 16:43 ` [PATCH v9 3/7] tcg: Add type for vCPU pointers Lluís Vilanova
2016-02-25 16:43   ` [Qemu-devel] " Lluís Vilanova
2016-02-25 16:43 ` Lluís Vilanova [this message]
2016-02-25 16:43 ` [Qemu-devel] [PATCH v9 5/7] [trivial] trace: Add helper function to cast event arguments Lluís Vilanova
2016-02-25 16:43 ` [Qemu-devel] [PATCH v9 6/7] typedefs: Add CPUState Lluís Vilanova
2016-02-25 16:43 ` [Qemu-devel] [PATCH v9 7/7] trace: Add 'vcpu' event property to trace guest vCPU Lluís Vilanova
2016-03-01 11:10 ` [Qemu-devel] [PATCH v9 0/7] trace: Show vCPU info in guest code events Lluís Vilanova
2016-03-01 13:31 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=145641860129.30295.17554707227384022653.stgit@localhost \
    --to=vilanova@ac.upc.edu \
    --cc=alex.bennee@linaro.org \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.