From: Keller, Jacob E <jacob.e.keller@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v2] fm10k: remove duplication of the driver summary
Date: Fri, 26 Feb 2016 01:05:24 +0000 [thread overview]
Message-ID: <1456448724.12253.10.camel@intel.com> (raw)
In-Reply-To: <804857E1F29AAC47BF68C404FC60A18490D7121B@ORSMSX104.amr.corp.intel.com>
On Fri, 2016-02-26 at 00:57 +0000, Allan, Bruce W wrote:
> >
> > -----Original Message-----
> > From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.
> > org] On
> > Behalf Of Jacob Keller
> > Sent: Thursday, February 25, 2016 3:59 PM
> > To: Intel Wired LAN
> > Subject: [Intel-wired-lan] [PATCH v2] fm10k: remove duplication of
> > the
> > driver summary
> >
> > Use DRV_SUMMARY, similar to DRV_VERSION so that we don't have
> > duplicate
> > copies of the summary left in the driver.
> >
> > Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> > ---
> > This is a direct replacement of what is already on the queue. This
> > version drops the summary change and only removes the duplication.
> >
> > ?drivers/net/ethernet/intel/fm10k/fm10k_main.c | 6 +++---
> > ?1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_main.c
> > b/drivers/net/ethernet/intel/fm10k/fm10k_main.c
> > index 3a81c1451624..7832f9cdf743 100644
> > --- a/drivers/net/ethernet/intel/fm10k/fm10k_main.c
> > +++ b/drivers/net/ethernet/intel/fm10k/fm10k_main.c
> > @@ -29,15 +29,15 @@
> > ?#include "fm10k.h"
> >
> > ?#define DRV_VERSION "0.19.3-k"
> > +#define DRV_SUMMARY "Intel(R) Ethernet Switch Host
> > Interface
> > Driver"
> > ?const char fm10k_driver_version[] = DRV_VERSION;
> > ?char fm10k_driver_name[] = "fm10k";
> > -static const char fm10k_driver_string[] =
> > - "Intel(R) Ethernet Switch Host Interface Driver";
> > +static const char fm10k_driver_string[] = DRV_SUMMARY;
> > ?static const char fm10k_copyright[] =
> > ? "Copyright (c) 2013 Intel Corporation.";
> >
> > ?MODULE_AUTHOR("Intel Corporation, <linux.nics@intel.com>");
> > -MODULE_DESCRIPTION("Intel(R) Ethernet Switch Host Interface
> > Driver");
> > +MODULE_DESCRIPTION(DRV_SUMMARY);
> > ?MODULE_LICENSE("GPL");
> > ?MODULE_VERSION(DRV_VERSION);
> Perhaps consider updating the copyright at the same time you are
> modifying this file?!?
>
> I suggested a change to "Copyright(c) 2013 - 2016 Intel Corporation."
>
Sure.
Thanks,
Jake
prev parent reply other threads:[~2016-02-26 1:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 23:58 [Intel-wired-lan] [PATCH v2] fm10k: remove duplication of the driver summary Jacob Keller
2016-02-26 0:57 ` Allan, Bruce W
2016-02-26 1:05 ` Keller, Jacob E [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456448724.12253.10.camel@intel.com \
--to=jacob.e.keller@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.