From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Sasha Shashkevich <alex@stunpix.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH] bb/fetch2: fixes copying of file://dir; subdir=foo, bug 6128 and bug 6129
Date: Fri, 26 Feb 2016 11:46:27 +0000 [thread overview]
Message-ID: <1456487187.11498.70.camel@linuxfoundation.org> (raw)
In-Reply-To: <8F8D0DA4-2383-4900-A0C6-9AAEA334C568@stunpix.com>
On Fri, 2016-02-26 at 13:30 +0200, Sasha Shashkevich wrote:
> > On Feb 26, 2016, at 12:51, Richard Purdie <
> > richard.purdie@linuxfoundation.org> wrote:
> >
> > On Thu, 2016-02-25 at 18:32 +0200, Alexander Shashkevich wrote:
> > > When in SRC_URI appears file://dir;subdir=foo unpacker copies
> > > 'dir'
> > > to ${WORKDIR}, not
> > > ${WORKDIR}/foo as it should be.
> > >
> > > These changes are fixing following bugs as well:
> > > Bug 6128 - Incorrect wildcard unpack behaviour in fetcher
> > > Bug 6129 - Local directories unpack to a different location than
> > > local files
> >
> > Sadly, this change isn't without side effects. For example:
> >
> > https://autobuilder.yoctoproject.org/main/builders/nightly-x86-64/b
> > uilds/680/steps/Building%20Toolchain%20Images/logs/stdio
> >
> > > NOTE: Unpacking /home/pokybuild/yocto-autobuilder/yocto
> > > -worker/nightly-x86-64/build/scripts/runqemu to
> > > /home/pokybuild/yocto-autobuilder/yocto-worker/nightly-x86
> > > -64/build/build/tmp/work/i686-nativesdk-pokysdk-linux/nativesdk
> > > -qemu-helper/1.0-r9/
> > > cp: `/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-x86
> > > -64/build/scripts/runqemu' and `/home/pokybuild/yocto
> > > -autobuilder/yocto-worker/nightly-x86-64/build/scripts/runqemu'
> > > are the same file
> > > DEBUG: Python function base_do_unpack finished
> > > DEBUG: Python function do_unpack finished
>
>
> Despite all tests were successfully passed, something remains
> incorrect. Very sensitive feature. I'll check what is wrong and
> supply additional test cases with updated patch. Seems I need to
> build several configurations locally before submitting such patches –
> just tests are not enough.
Yes, sadly our tests aren't entirely complete. I'd much appreciate
added test cases if we can figure out what the issue is.
This change does introduce a change in behaviour, admittedly one where
we think the current behaviour is incorrect. It is possible recipes are
relying on that incorrect behaviour though and they may need adjusting.
Cheers,
Richard
next prev parent reply other threads:[~2016-02-26 11:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 16:32 [PATCH] bb/fetch2: fixes copying of file://dir; subdir=foo, bug 6128 and bug 6129 Alexander Shashkevich
2016-02-26 10:51 ` Richard Purdie
2016-02-26 11:30 ` Sasha Shashkevich
2016-02-26 11:46 ` Richard Purdie [this message]
2016-02-26 16:51 ` Richard Purdie
2016-02-26 17:11 ` Richard Purdie
2016-02-26 17:18 ` Sasha Shashkevich
2016-02-27 17:22 ` Sasha Shashkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1456487187.11498.70.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=alex@stunpix.com \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.