From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v1 05/10] ACPI: switch to use generic UUID API Date: Fri, 26 Feb 2016 15:46:31 +0200 Message-ID: <1456494391.13244.137.camel@linux.intel.com> References: <1455711448-124103-1-git-send-email-andriy.shevchenko@linux.intel.com> <1455711448-124103-6-git-send-email-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dan Williams Cc: "Rafael J. Wysocki" , Theodore Ts'o , Arnd Bergmann , Greg Kroah-Hartman , Jarkko Sakkinen , Jani Nikula , David Airlie , Benjamin Tissoires , Bjorn Helgaas , Mathias Nyman , Matt Fleming , Lv Zheng , Mark Brown , Zhang Rui , Mika Westerberg , Andrew Morton , Rasmus Villemoes , Linux ACPI , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Maling list - DRI developers , linux-efi-u79uwXL29TbrhsbdSgBK9A@public.gmane.org List-Id: linux-api@vger.kernel.org On Wed, 2016-02-17 at 09:49 -0800, Dan Williams wrote: > On Wed, Feb 17, 2016 at 4:17 AM, Andy Shevchenko > wrote: > > Instead of opencoding the existing library functions let's use them > > directly. > >=20 > > The conversion fixes a potential bug in int340x_thermal as well > > since we have > > to use memcmp() on binary data. [..] > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0uuid_le_to_bin(UUID_NFIT= _BUS, &nfit_uuid[NFIT_DEV_BUS]); > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0uuid_le_to_bin(UUID_NFIT= _DIMM, &nfit_uuid[NFIT_DEV_DIMM]); >=20 > I don't see the benefit of this change. The benefit is to have less places (ideally one) which provides UUID helper routines for kernel. > =C2=A0=C2=A0For the NFIT driver we went > through a fire drill trying to make sure the ACPI spec format of a > UUID matched the Linux interpretation, and this change makes that > harder to determine.=C2=A0=C2=A0 How harder? At least you look into one place and see exactly all functions related. Besides this series actually uses the same approach that was used in ACPI. > ACPI drivers should use ACPICA uuid helper > routines in my opinion. As far as I can see ACPICA lacks of needed API. --=20 Andy Shevchenko Intel Finland Oy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by ml01.01.org (Postfix) with ESMTP id 2C8C71A1E1A for ; Fri, 26 Feb 2016 05:45:57 -0800 (PST) Message-ID: <1456494391.13244.137.camel@linux.intel.com> Subject: Re: [PATCH v1 05/10] ACPI: switch to use generic UUID API From: Andy Shevchenko Date: Fri, 26 Feb 2016 15:46:31 +0200 In-Reply-To: References: <1455711448-124103-1-git-send-email-andriy.shevchenko@linux.intel.com> <1455711448-124103-6-git-send-email-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: linux-efi@vger.kernel.org, David Airlie , Rasmus Villemoes , Maling list - DRI developers , Benjamin Tissoires , Lv Zheng , Matt Fleming , Arnd Bergmann , "linux-nvdimm@lists.01.org" , Linux ACPI , Zhang Rui , Mathias Nyman , Jani Nikula , Mark Brown , Jarkko Sakkinen , Bjorn Helgaas , Mika Westerberg , Theodore Ts'o , Greg Kroah-Hartman , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , linux-api@vger.kernel.org, Andrew Morton List-ID: T24gV2VkLCAyMDE2LTAyLTE3IGF0IDA5OjQ5IC0wODAwLCBEYW4gV2lsbGlhbXMgd3JvdGU6Cj4g T24gV2VkLCBGZWIgMTcsIDIwMTYgYXQgNDoxNyBBTSwgQW5keSBTaGV2Y2hlbmtvCj4gPGFuZHJp eS5zaGV2Y2hlbmtvQGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gPiBJbnN0ZWFkIG9mIG9wZW5j b2RpbmcgdGhlIGV4aXN0aW5nIGxpYnJhcnkgZnVuY3Rpb25zIGxldCdzIHVzZSB0aGVtCj4gPiBk aXJlY3RseS4KPiA+IAo+ID4gVGhlIGNvbnZlcnNpb24gZml4ZXMgYSBwb3RlbnRpYWwgYnVnIGlu IGludDM0MHhfdGhlcm1hbCBhcyB3ZWxsCj4gPiBzaW5jZSB3ZSBoYXZlCj4gPiB0byB1c2UgbWVt Y21wKCkgb24gYmluYXJ5IGRhdGEuCgpbLi5dCgo+ID4gK8KgwqDCoMKgwqDCoMKgdXVpZF9sZV90 b19iaW4oVVVJRF9ORklUX0JVUywgJm5maXRfdXVpZFtORklUX0RFVl9CVVNdKTsKPiA+ICvCoMKg wqDCoMKgwqDCoHV1aWRfbGVfdG9fYmluKFVVSURfTkZJVF9ESU1NLCAmbmZpdF91dWlkW05GSVRf REVWX0RJTU1dKTsKPiAKPiBJIGRvbid0IHNlZSB0aGUgYmVuZWZpdCBvZiB0aGlzIGNoYW5nZS4K ClRoZSBiZW5lZml0IGlzIHRvIGhhdmUgbGVzcyBwbGFjZXMgKGlkZWFsbHkgb25lKSB3aGljaCBw cm92aWRlcyBVVUlECmhlbHBlciByb3V0aW5lcyBmb3Iga2VybmVsLgoKPiDCoMKgRm9yIHRoZSBO RklUIGRyaXZlciB3ZSB3ZW50Cj4gdGhyb3VnaCBhIGZpcmUgZHJpbGwgdHJ5aW5nIHRvIG1ha2Ug c3VyZSB0aGUgQUNQSSBzcGVjIGZvcm1hdCBvZiBhCj4gVVVJRCBtYXRjaGVkIHRoZSBMaW51eCBp bnRlcnByZXRhdGlvbiwgYW5kIHRoaXMgY2hhbmdlIG1ha2VzIHRoYXQKPiBoYXJkZXIgdG8gZGV0 ZXJtaW5lLsKgwqAKCkhvdyBoYXJkZXI/IEF0IGxlYXN0IHlvdSBsb29rIGludG8gb25lIHBsYWNl IGFuZCBzZWUgZXhhY3RseSBhbGwKZnVuY3Rpb25zIHJlbGF0ZWQuIEJlc2lkZXMgdGhpcyBzZXJp ZXMgYWN0dWFsbHkgdXNlcyB0aGUgc2FtZSBhcHByb2FjaAp0aGF0IHdhcyB1c2VkIGluIEFDUEku Cgo+IEFDUEkgZHJpdmVycyBzaG91bGQgdXNlIEFDUElDQSB1dWlkIGhlbHBlcgo+IHJvdXRpbmVz IGluIG15IG9waW5pb24uCgpBcyBmYXIgYXMgSSBjYW4gc2VlIEFDUElDQSBsYWNrcyBvZiBuZWVk ZWQgQVBJLgoKLS0gCkFuZHkgU2hldmNoZW5rbyA8YW5kcml5LnNoZXZjaGVua29AbGludXguaW50 ZWwuY29tPgpJbnRlbCBGaW5sYW5kIE95CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpMaW51eC1udmRpbW0gbWFpbGluZyBsaXN0CkxpbnV4LW52ZGltbUBs aXN0cy4wMS5vcmcKaHR0cHM6Ly9saXN0cy4wMS5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1u dmRpbW0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932297AbcBZNpz (ORCPT ); Fri, 26 Feb 2016 08:45:55 -0500 Received: from mga11.intel.com ([192.55.52.93]:40508 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754114AbcBZNpx (ORCPT ); Fri, 26 Feb 2016 08:45:53 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,498,1449561600"; d="scan'208";a="911850138" Message-ID: <1456494391.13244.137.camel@linux.intel.com> Subject: Re: [PATCH v1 05/10] ACPI: switch to use generic UUID API From: Andy Shevchenko To: Dan Williams Cc: "Rafael J. Wysocki" , "Theodore Ts'o" , Arnd Bergmann , Greg Kroah-Hartman , Jarkko Sakkinen , Jani Nikula , David Airlie , Benjamin Tissoires , Bjorn Helgaas , Mathias Nyman , Matt Fleming , Lv Zheng , Mark Brown , Zhang Rui , Mika Westerberg , Andrew Morton , Rasmus Villemoes , Linux ACPI , "linux-kernel@vger.kernel.org" , Maling list - DRI developers , linux-efi@vger.kernel.org, linux-api@vger.kernel.org, "linux-nvdimm@lists.01.org" Date: Fri, 26 Feb 2016 15:46:31 +0200 In-Reply-To: References: <1455711448-124103-1-git-send-email-andriy.shevchenko@linux.intel.com> <1455711448-124103-6-git-send-email-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-02-17 at 09:49 -0800, Dan Williams wrote: > On Wed, Feb 17, 2016 at 4:17 AM, Andy Shevchenko > wrote: > > Instead of opencoding the existing library functions let's use them > > directly. > > > > The conversion fixes a potential bug in int340x_thermal as well > > since we have > > to use memcmp() on binary data. [..] > > +       uuid_le_to_bin(UUID_NFIT_BUS, &nfit_uuid[NFIT_DEV_BUS]); > > +       uuid_le_to_bin(UUID_NFIT_DIMM, &nfit_uuid[NFIT_DEV_DIMM]); > > I don't see the benefit of this change. The benefit is to have less places (ideally one) which provides UUID helper routines for kernel. >   For the NFIT driver we went > through a fire drill trying to make sure the ACPI spec format of a > UUID matched the Linux interpretation, and this change makes that > harder to determine.   How harder? At least you look into one place and see exactly all functions related. Besides this series actually uses the same approach that was used in ACPI. > ACPI drivers should use ACPICA uuid helper > routines in my opinion. As far as I can see ACPICA lacks of needed API. -- Andy Shevchenko Intel Finland Oy