From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v1 06/10] device property: switch to use UUID API Date: Fri, 26 Feb 2016 16:11:37 +0200 Message-ID: <1456495897.13244.144.camel@linux.intel.com> References: <1455711448-124103-1-git-send-email-andriy.shevchenko@linux.intel.com> <1455711448-124103-7-git-send-email-andriy.shevchenko@linux.intel.com> <7544228.v4QPX4F7J7@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <7544228.v4QPX4F7J7-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Rafael J. Wysocki" Cc: Theodore Ts'o , Arnd Bergmann , Greg Kroah-Hartman , Jarkko Sakkinen , Jani Nikula , David Airlie , Benjamin Tissoires , Bjorn Helgaas , Mathias Nyman , Matt Fleming , Lv Zheng , Mark Brown , Zhang Rui , Mika Westerberg , Andrew Morton , Rasmus Villemoes , linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org List-Id: linux-api@vger.kernel.org On Thu, 2016-02-18 at 01:03 +0100, Rafael J. Wysocki wrote: > On Wednesday, February 17, 2016 02:17:24 PM Andy Shevchenko wrote: > > Switch to use a generic UUID API instead of custom approach. It > > allows to > > define UUIDs, compare them, and validate. [] > > +static const uuid_le ads_uuid =3D > > + UUID_LE(0xdbb8e3e6, 0x5886, 0x4ba6, > > + 0x87, 0x95, 0x13, 0x19, 0xf5, 0x2a, 0x96, 0x6b); > > =C2=A0 > > =C2=A0static bool acpi_enumerate_nondev_subnodes(acpi_handle scope, > > =C2=A0 =C2=A0=C2=A0=C2=A0const union acpi_object > > *desc, > > @@ -138,7 +136,7 @@ static bool > > acpi_enumerate_nondev_subnodes(acpi_handle scope, > > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0|| links->type !=3D ACPI_TYPE_PACKA= GE) > > =C2=A0 break; > > =C2=A0 > > - if (memcmp(uuid->buffer.pointer, ads_uuid, > > sizeof(ads_uuid))) > > + if (uuid_le_cmp(*(uuid_le *)uuid->buffer.pointer, > > ads_uuid)) >=20 > Maybe it's too late, but I don't quite understand the pointer > manipulations here. >=20 > I can see why you need a type conversion (although it looks ugly), > but why do you > need to dereference it too? The function takes that kind of type on input. The other variants are not compiled. Perhaps we better change uuid_{lb}e_cmp() first to take normal pointers, though I think the initial idea was to get type checking at compile time. --=20 Andy Shevchenko Intel Finland Oy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by ml01.01.org (Postfix) with ESMTP id 7535E1A1DF3 for ; Fri, 26 Feb 2016 06:11:02 -0800 (PST) Message-ID: <1456495897.13244.144.camel@linux.intel.com> Subject: Re: [PATCH v1 06/10] device property: switch to use UUID API From: Andy Shevchenko Date: Fri, 26 Feb 2016 16:11:37 +0200 In-Reply-To: <7544228.v4QPX4F7J7@vostro.rjw.lan> References: <1455711448-124103-1-git-send-email-andriy.shevchenko@linux.intel.com> <1455711448-124103-7-git-send-email-andriy.shevchenko@linux.intel.com> <7544228.v4QPX4F7J7@vostro.rjw.lan> Mime-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Rafael J. Wysocki" Cc: linux-efi@vger.kernel.org, David Airlie , Rasmus Villemoes , dri-devel@lists.freedesktop.org, Benjamin Tissoires , Lv Zheng , Matt Fleming , Arnd Bergmann , linux-nvdimm@lists.01.org, linux-acpi@vger.kernel.org, Zhang Rui , Mathias Nyman , Jani Nikula , Mark Brown , Jarkko Sakkinen , Bjorn Helgaas , Mika Westerberg , Theodore Ts'o , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Andrew Morton List-ID: T24gVGh1LCAyMDE2LTAyLTE4IGF0IDAxOjAzICswMTAwLCBSYWZhZWwgSi4gV3lzb2NraSB3cm90 ZToKPiBPbiBXZWRuZXNkYXksIEZlYnJ1YXJ5IDE3LCAyMDE2IDAyOjE3OjI0IFBNIEFuZHkgU2hl dmNoZW5rbyB3cm90ZToKPiA+IFN3aXRjaCB0byB1c2UgYSBnZW5lcmljIFVVSUQgQVBJIGluc3Rl YWQgb2YgY3VzdG9tIGFwcHJvYWNoLiBJdAo+ID4gYWxsb3dzIHRvCj4gPiBkZWZpbmUgVVVJRHMs IGNvbXBhcmUgdGhlbSwgYW5kIHZhbGlkYXRlLgoKW10KCj4gPiArc3RhdGljIGNvbnN0IHV1aWRf bGUgYWRzX3V1aWQgPQo+ID4gKwlVVUlEX0xFKDB4ZGJiOGUzZTYsIDB4NTg4NiwgMHg0YmE2LAo+ ID4gKwkJMHg4NywgMHg5NSwgMHgxMywgMHgxOSwgMHhmNSwgMHgyYSwgMHg5NiwgMHg2Yik7Cj4g PiDCoAo+ID4gwqBzdGF0aWMgYm9vbCBhY3BpX2VudW1lcmF0ZV9ub25kZXZfc3Vibm9kZXMoYWNw aV9oYW5kbGUgc2NvcGUsCj4gPiDCoAkJCQkJwqDCoMKgY29uc3QgdW5pb24gYWNwaV9vYmplY3QK PiA+ICpkZXNjLAo+ID4gQEAgLTEzOCw3ICsxMzYsNyBAQCBzdGF0aWMgYm9vbAo+ID4gYWNwaV9l bnVtZXJhdGVfbm9uZGV2X3N1Ym5vZGVzKGFjcGlfaGFuZGxlIHNjb3BlLAo+ID4gwqAJCcKgwqDC oMKgfHwgbGlua3MtPnR5cGUgIT0gQUNQSV9UWVBFX1BBQ0tBR0UpCj4gPiDCoAkJCWJyZWFrOwo+ ID4gwqAKPiA+IC0JCWlmIChtZW1jbXAodXVpZC0+YnVmZmVyLnBvaW50ZXIsIGFkc191dWlkLAo+ ID4gc2l6ZW9mKGFkc191dWlkKSkpCj4gPiArCQlpZiAodXVpZF9sZV9jbXAoKih1dWlkX2xlICop dXVpZC0+YnVmZmVyLnBvaW50ZXIsCj4gPiBhZHNfdXVpZCkpCj4gCj4gTWF5YmUgaXQncyB0b28g bGF0ZSwgYnV0IEkgZG9uJ3QgcXVpdGUgdW5kZXJzdGFuZCB0aGUgcG9pbnRlcgo+IG1hbmlwdWxh dGlvbnMgaGVyZS4KPiAKPiBJIGNhbiBzZWUgd2h5IHlvdSBuZWVkIGEgdHlwZSBjb252ZXJzaW9u IChhbHRob3VnaCBpdCBsb29rcyB1Z2x5KSwKPiBidXQgd2h5IGRvIHlvdQo+IG5lZWQgdG8gZGVy ZWZlcmVuY2UgaXQgdG9vPwoKVGhlIGZ1bmN0aW9uIHRha2VzIHRoYXQga2luZCBvZiB0eXBlIG9u IGlucHV0LiBUaGUgb3RoZXIgdmFyaWFudHMgYXJlCm5vdCBjb21waWxlZC4KUGVyaGFwcyB3ZSBi ZXR0ZXIgY2hhbmdlIHV1aWRfe2xifWVfY21wKCkgZmlyc3QgdG8gdGFrZSBub3JtYWwKcG9pbnRl cnMsIHRob3VnaCBJIHRoaW5rIHRoZSBpbml0aWFsIGlkZWEgd2FzIHRvIGdldCB0eXBlIGNoZWNr aW5nIGF0CmNvbXBpbGUgdGltZS4KCi0tIApBbmR5IFNoZXZjaGVua28gPGFuZHJpeS5zaGV2Y2hl bmtvQGxpbnV4LmludGVsLmNvbT4KSW50ZWwgRmlubGFuZCBPeQoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtbnZkaW1tIG1haWxpbmcgbGlzdApM aW51eC1udmRpbW1AbGlzdHMuMDEub3JnCmh0dHBzOi8vbGlzdHMuMDEub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtbnZkaW1tCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754246AbcBZOLa (ORCPT ); Fri, 26 Feb 2016 09:11:30 -0500 Received: from mga14.intel.com ([192.55.52.115]:24510 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751678AbcBZOL2 (ORCPT ); Fri, 26 Feb 2016 09:11:28 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,498,1449561600"; d="scan'208";a="659738986" Message-ID: <1456495897.13244.144.camel@linux.intel.com> Subject: Re: [PATCH v1 06/10] device property: switch to use UUID API From: Andy Shevchenko To: "Rafael J. Wysocki" Cc: "Theodore Ts'o" , Arnd Bergmann , Greg Kroah-Hartman , Jarkko Sakkinen , Jani Nikula , David Airlie , Benjamin Tissoires , Bjorn Helgaas , Mathias Nyman , Matt Fleming , Lv Zheng , Mark Brown , Zhang Rui , Mika Westerberg , Andrew Morton , Rasmus Villemoes , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-efi@vger.kernel.org, linux-api@vger.kernel.org, linux-nvdimm@ml01.01.org Date: Fri, 26 Feb 2016 16:11:37 +0200 In-Reply-To: <7544228.v4QPX4F7J7@vostro.rjw.lan> References: <1455711448-124103-1-git-send-email-andriy.shevchenko@linux.intel.com> <1455711448-124103-7-git-send-email-andriy.shevchenko@linux.intel.com> <7544228.v4QPX4F7J7@vostro.rjw.lan> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-02-18 at 01:03 +0100, Rafael J. Wysocki wrote: > On Wednesday, February 17, 2016 02:17:24 PM Andy Shevchenko wrote: > > Switch to use a generic UUID API instead of custom approach. It > > allows to > > define UUIDs, compare them, and validate. [] > > +static const uuid_le ads_uuid = > > + UUID_LE(0xdbb8e3e6, 0x5886, 0x4ba6, > > + 0x87, 0x95, 0x13, 0x19, 0xf5, 0x2a, 0x96, 0x6b); > >   > >  static bool acpi_enumerate_nondev_subnodes(acpi_handle scope, > >      const union acpi_object > > *desc, > > @@ -138,7 +136,7 @@ static bool > > acpi_enumerate_nondev_subnodes(acpi_handle scope, > >       || links->type != ACPI_TYPE_PACKAGE) > >   break; > >   > > - if (memcmp(uuid->buffer.pointer, ads_uuid, > > sizeof(ads_uuid))) > > + if (uuid_le_cmp(*(uuid_le *)uuid->buffer.pointer, > > ads_uuid)) > > Maybe it's too late, but I don't quite understand the pointer > manipulations here. > > I can see why you need a type conversion (although it looks ugly), > but why do you > need to dereference it too? The function takes that kind of type on input. The other variants are not compiled. Perhaps we better change uuid_{lb}e_cmp() first to take normal pointers, though I think the initial idea was to get type checking at compile time. -- Andy Shevchenko Intel Finland Oy