From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v1 06/10] device property: switch to use UUID API Date: Fri, 26 Feb 2016 16:28:10 +0200 Message-ID: <1456496890.13244.146.camel@linux.intel.com> References: <1455711448-124103-1-git-send-email-andriy.shevchenko@linux.intel.com> <1455711448-124103-7-git-send-email-andriy.shevchenko@linux.intel.com> <20160218110754.GG1742@lahna.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20160218110754.GG1742-3PARRvDOhMZrdx17CPfAsdBPR1lH4CV8@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mika Westerberg Cc: "Rafael J. Wysocki" , Theodore Ts'o , Arnd Bergmann , Greg Kroah-Hartman , Jarkko Sakkinen , Jani Nikula , David Airlie , Benjamin Tissoires , Bjorn Helgaas , Mathias Nyman , Matt Fleming , Lv Zheng , Mark Brown , Zhang Rui , Andrew Morton , Rasmus Villemoes , linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org List-Id: linux-api@vger.kernel.org On Thu, 2016-02-18 at 13:07 +0200, Mika Westerberg wrote: > On Wed, Feb 17, 2016 at 02:17:24PM +0200, Andy Shevchenko wrote: > > Switch to use a generic UUID API instead of custom approach. It > > allows to > > define UUIDs, compare them, and validate. > >=20 > > Signed-off-by: Andy Shevchenko > > --- > > =C2=A0drivers/acpi/property.c | 18 ++++++++---------- > > =C2=A01 file changed, 8 insertions(+), 10 deletions(-) > >=20 > > diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c > > index 2aee416..1e75305 100644 > > --- a/drivers/acpi/property.c > > +++ b/drivers/acpi/property.c > > @@ -25,15 +25,13 @@ static int acpi_data_get_property_array(struct > > acpi_device_data *data, > > =C2=A0 const union acpi_object > > **obj); > > =C2=A0 > > =C2=A0/* ACPI _DSD device properties UUID: daffd814-6eba-4d8c-8a91- > > bc9bbf4aa301 */ > > -static const u8 prp_uuid[16] =3D { > > - 0x14, 0xd8, 0xff, 0xda, 0xba, 0x6e, 0x8c, 0x4d, > > - 0x8a, 0x91, 0xbc, 0x9b, 0xbf, 0x4a, 0xa3, 0x01 > > -}; > > +static const uuid_le prp_uuid =3D > > + UUID_LE(0xdaffd814, 0x6eba, 0x4d8c, > > + 0x8a, 0x91, 0xbc, 0x9b, 0xbf, 0x4a, 0xa3, 0x01); > > =C2=A0/* ACPI _DSD data subnodes UUID: dbb8e3e6-5886-4ba6-8795- > > 1319f52a966b */ > > -static const u8 ads_uuid[16] =3D { > > - 0xe6, 0xe3, 0xb8, 0xdb, 0x86, 0x58, 0xa6, 0x4b, > > - 0x87, 0x95, 0x13, 0x19, 0xf5, 0x2a, 0x96, 0x6b > > -}; > > +static const uuid_le ads_uuid =3D > > + UUID_LE(0xdbb8e3e6, 0x5886, 0x4ba6, > > + 0x87, 0x95, 0x13, 0x19, 0xf5, 0x2a, 0x96, 0x6b); >=20 > This looks better than the original but it is still not too readable. >=20 > I think it would be better to have uuid as string like: >=20 > static const char *ads_uuid =3D "dbb8e3e6-5886-4ba6-8795-1319f52a966b= "; >=20 > and then convert that to the right byte presentation when first time > used. That would match the uuid format in the ACPI (and device > properties) spec. and thus make it easier to read and understand. Yes we can do this on slow paths. Or in cases where we know that conversion happens only once. --=20 Andy Shevchenko Intel Finland Oy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by ml01.01.org (Postfix) with ESMTP id 89F0A1A1DF3 for ; Fri, 26 Feb 2016 06:27:52 -0800 (PST) Message-ID: <1456496890.13244.146.camel@linux.intel.com> Subject: Re: [PATCH v1 06/10] device property: switch to use UUID API From: Andy Shevchenko Date: Fri, 26 Feb 2016 16:28:10 +0200 In-Reply-To: <20160218110754.GG1742@lahna.fi.intel.com> References: <1455711448-124103-1-git-send-email-andriy.shevchenko@linux.intel.com> <1455711448-124103-7-git-send-email-andriy.shevchenko@linux.intel.com> <20160218110754.GG1742@lahna.fi.intel.com> Mime-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Mika Westerberg Cc: linux-efi@vger.kernel.org, David Airlie , Rasmus Villemoes , dri-devel@lists.freedesktop.org, Benjamin Tissoires , Lv Zheng , Matt Fleming , Arnd Bergmann , linux-nvdimm@lists.01.org, linux-acpi@vger.kernel.org, Zhang Rui , Mathias Nyman , Jani Nikula , Mark Brown , Jarkko Sakkinen , Bjorn Helgaas , Theodore Ts'o , Greg Kroah-Hartman , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Andrew Morton List-ID: T24gVGh1LCAyMDE2LTAyLTE4IGF0IDEzOjA3ICswMjAwLCBNaWthIFdlc3RlcmJlcmcgd3JvdGU6 Cj4gT24gV2VkLCBGZWIgMTcsIDIwMTYgYXQgMDI6MTc6MjRQTSArMDIwMCwgQW5keSBTaGV2Y2hl bmtvIHdyb3RlOgo+ID4gU3dpdGNoIHRvIHVzZSBhIGdlbmVyaWMgVVVJRCBBUEkgaW5zdGVhZCBv ZiBjdXN0b20gYXBwcm9hY2guIEl0Cj4gPiBhbGxvd3MgdG8KPiA+IGRlZmluZSBVVUlEcywgY29t cGFyZSB0aGVtLCBhbmQgdmFsaWRhdGUuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IEFuZHkgU2hl dmNoZW5rbyA8YW5kcml5LnNoZXZjaGVua29AbGludXguaW50ZWwuY29tPgo+ID4gLS0tCj4gPiDC oGRyaXZlcnMvYWNwaS9wcm9wZXJ0eS5jIHwgMTggKysrKysrKystLS0tLS0tLS0tCj4gPiDCoDEg ZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9hY3BpL3Byb3BlcnR5LmMgYi9kcml2ZXJzL2FjcGkvcHJvcGVy dHkuYwo+ID4gaW5kZXggMmFlZTQxNi4uMWU3NTMwNSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMv YWNwaS9wcm9wZXJ0eS5jCj4gPiArKysgYi9kcml2ZXJzL2FjcGkvcHJvcGVydHkuYwo+ID4gQEAg LTI1LDE1ICsyNSwxMyBAQCBzdGF0aWMgaW50IGFjcGlfZGF0YV9nZXRfcHJvcGVydHlfYXJyYXko c3RydWN0Cj4gPiBhY3BpX2RldmljZV9kYXRhICpkYXRhLAo+ID4gwqAJCQkJCWNvbnN0IHVuaW9u IGFjcGlfb2JqZWN0Cj4gPiAqKm9iaik7Cj4gPiDCoAo+ID4gwqAvKiBBQ1BJIF9EU0QgZGV2aWNl IHByb3BlcnRpZXMgVVVJRDogZGFmZmQ4MTQtNmViYS00ZDhjLThhOTEtCj4gPiBiYzliYmY0YWEz MDEgKi8KPiA+IC1zdGF0aWMgY29uc3QgdTggcHJwX3V1aWRbMTZdID0gewo+ID4gLQkweDE0LCAw eGQ4LCAweGZmLCAweGRhLCAweGJhLCAweDZlLCAweDhjLCAweDRkLAo+ID4gLQkweDhhLCAweDkx LCAweGJjLCAweDliLCAweGJmLCAweDRhLCAweGEzLCAweDAxCj4gPiAtfTsKPiA+ICtzdGF0aWMg Y29uc3QgdXVpZF9sZSBwcnBfdXVpZCA9Cj4gPiArCVVVSURfTEUoMHhkYWZmZDgxNCwgMHg2ZWJh LCAweDRkOGMsCj4gPiArCQkweDhhLCAweDkxLCAweGJjLCAweDliLCAweGJmLCAweDRhLCAweGEz LCAweDAxKTsKPiA+IMKgLyogQUNQSSBfRFNEIGRhdGEgc3Vibm9kZXMgVVVJRDogZGJiOGUzZTYt NTg4Ni00YmE2LTg3OTUtCj4gPiAxMzE5ZjUyYTk2NmIgKi8KPiA+IC1zdGF0aWMgY29uc3QgdTgg YWRzX3V1aWRbMTZdID0gewo+ID4gLQkweGU2LCAweGUzLCAweGI4LCAweGRiLCAweDg2LCAweDU4 LCAweGE2LCAweDRiLAo+ID4gLQkweDg3LCAweDk1LCAweDEzLCAweDE5LCAweGY1LCAweDJhLCAw eDk2LCAweDZiCj4gPiAtfTsKPiA+ICtzdGF0aWMgY29uc3QgdXVpZF9sZSBhZHNfdXVpZCA9Cj4g PiArCVVVSURfTEUoMHhkYmI4ZTNlNiwgMHg1ODg2LCAweDRiYTYsCj4gPiArCQkweDg3LCAweDk1 LCAweDEzLCAweDE5LCAweGY1LCAweDJhLCAweDk2LCAweDZiKTsKPiAKPiBUaGlzIGxvb2tzIGJl dHRlciB0aGFuIHRoZSBvcmlnaW5hbCBidXQgaXQgaXMgc3RpbGwgbm90IHRvbyByZWFkYWJsZS4K PiAKPiBJIHRoaW5rIGl0IHdvdWxkIGJlIGJldHRlciB0byBoYXZlIHV1aWQgYXMgc3RyaW5nIGxp a2U6Cj4gCj4gc3RhdGljIGNvbnN0IGNoYXIgKmFkc191dWlkID0gImRiYjhlM2U2LTU4ODYtNGJh Ni04Nzk1LTEzMTlmNTJhOTY2YiI7Cj4gCj4gYW5kIHRoZW4gY29udmVydCB0aGF0IHRvIHRoZSBy aWdodCBieXRlIHByZXNlbnRhdGlvbiB3aGVuIGZpcnN0IHRpbWUKPiB1c2VkLiBUaGF0IHdvdWxk IG1hdGNoIHRoZSB1dWlkIGZvcm1hdCBpbiB0aGUgQUNQSSAoYW5kIGRldmljZQo+IHByb3BlcnRp ZXMpIHNwZWMuIGFuZCB0aHVzIG1ha2UgaXQgZWFzaWVyIHRvIHJlYWQgYW5kIHVuZGVyc3RhbmQu CgpZZXMgd2UgY2FuIGRvIHRoaXMgb24gc2xvdyBwYXRocy4gT3IgaW4gY2FzZXMgd2hlcmUgd2Ug a25vdyB0aGF0CmNvbnZlcnNpb24gaGFwcGVucyBvbmx5IG9uY2UuCgoKLS0gCkFuZHkgU2hldmNo ZW5rbyA8YW5kcml5LnNoZXZjaGVua29AbGludXguaW50ZWwuY29tPgpJbnRlbCBGaW5sYW5kIE95 CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1u dmRpbW0gbWFpbGluZyBsaXN0CkxpbnV4LW52ZGltbUBsaXN0cy4wMS5vcmcKaHR0cHM6Ly9saXN0 cy4wMS5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1udmRpbW0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754507AbcBZO1e (ORCPT ); Fri, 26 Feb 2016 09:27:34 -0500 Received: from mga11.intel.com ([192.55.52.93]:46258 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932738AbcBZO1b (ORCPT ); Fri, 26 Feb 2016 09:27:31 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,498,1449561600"; d="scan'208";a="659744262" Message-ID: <1456496890.13244.146.camel@linux.intel.com> Subject: Re: [PATCH v1 06/10] device property: switch to use UUID API From: Andy Shevchenko To: Mika Westerberg Cc: "Rafael J. Wysocki" , "Theodore Ts'o" , Arnd Bergmann , Greg Kroah-Hartman , Jarkko Sakkinen , Jani Nikula , David Airlie , Benjamin Tissoires , Bjorn Helgaas , Mathias Nyman , Matt Fleming , Lv Zheng , Mark Brown , Zhang Rui , Andrew Morton , Rasmus Villemoes , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-efi@vger.kernel.org, linux-api@vger.kernel.org, linux-nvdimm@ml01.01.org Date: Fri, 26 Feb 2016 16:28:10 +0200 In-Reply-To: <20160218110754.GG1742@lahna.fi.intel.com> References: <1455711448-124103-1-git-send-email-andriy.shevchenko@linux.intel.com> <1455711448-124103-7-git-send-email-andriy.shevchenko@linux.intel.com> <20160218110754.GG1742@lahna.fi.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-02-18 at 13:07 +0200, Mika Westerberg wrote: > On Wed, Feb 17, 2016 at 02:17:24PM +0200, Andy Shevchenko wrote: > > Switch to use a generic UUID API instead of custom approach. It > > allows to > > define UUIDs, compare them, and validate. > > > > Signed-off-by: Andy Shevchenko > > --- > >  drivers/acpi/property.c | 18 ++++++++---------- > >  1 file changed, 8 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c > > index 2aee416..1e75305 100644 > > --- a/drivers/acpi/property.c > > +++ b/drivers/acpi/property.c > > @@ -25,15 +25,13 @@ static int acpi_data_get_property_array(struct > > acpi_device_data *data, > >   const union acpi_object > > **obj); > >   > >  /* ACPI _DSD device properties UUID: daffd814-6eba-4d8c-8a91- > > bc9bbf4aa301 */ > > -static const u8 prp_uuid[16] = { > > - 0x14, 0xd8, 0xff, 0xda, 0xba, 0x6e, 0x8c, 0x4d, > > - 0x8a, 0x91, 0xbc, 0x9b, 0xbf, 0x4a, 0xa3, 0x01 > > -}; > > +static const uuid_le prp_uuid = > > + UUID_LE(0xdaffd814, 0x6eba, 0x4d8c, > > + 0x8a, 0x91, 0xbc, 0x9b, 0xbf, 0x4a, 0xa3, 0x01); > >  /* ACPI _DSD data subnodes UUID: dbb8e3e6-5886-4ba6-8795- > > 1319f52a966b */ > > -static const u8 ads_uuid[16] = { > > - 0xe6, 0xe3, 0xb8, 0xdb, 0x86, 0x58, 0xa6, 0x4b, > > - 0x87, 0x95, 0x13, 0x19, 0xf5, 0x2a, 0x96, 0x6b > > -}; > > +static const uuid_le ads_uuid = > > + UUID_LE(0xdbb8e3e6, 0x5886, 0x4ba6, > > + 0x87, 0x95, 0x13, 0x19, 0xf5, 0x2a, 0x96, 0x6b); > > This looks better than the original but it is still not too readable. > > I think it would be better to have uuid as string like: > > static const char *ads_uuid = "dbb8e3e6-5886-4ba6-8795-1319f52a966b"; > > and then convert that to the right byte presentation when first time > used. That would match the uuid format in the ACPI (and device > properties) spec. and thus make it easier to read and understand. Yes we can do this on slow paths. Or in cases where we know that conversion happens only once. -- Andy Shevchenko Intel Finland Oy