* [Intel-wired-lan] [PATCH v3] fm10k: remove duplication of the driver summary
@ 2016-02-26 1:08 Jacob Keller
2016-02-26 1:22 ` Allan, Bruce W
0 siblings, 1 reply; 3+ messages in thread
From: Jacob Keller @ 2016-02-26 1:08 UTC (permalink / raw)
To: intel-wired-lan
Use DRV_SUMMARY, similar to DRV_VERSION so that we don't have duplicate
copies of the summary left in the driver.
Also update the file copyright string and the ethtool copyright string
while we are here.
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
---
drivers/net/ethernet/intel/fm10k/fm10k_main.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_main.c b/drivers/net/ethernet/intel/fm10k/fm10k_main.c
index 3a81c1451624..98166e8b0789 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k_main.c
+++ b/drivers/net/ethernet/intel/fm10k/fm10k_main.c
@@ -1,5 +1,5 @@
/* Intel Ethernet Switch Host Interface Driver
- * Copyright(c) 2013 - 2014 Intel Corporation.
+ * Copyright(c) 2013 - 2016 Intel Corporation.
*
* This program is free software; you can redistribute it and/or modify it
* under the terms and conditions of the GNU General Public License,
@@ -29,15 +29,15 @@
#include "fm10k.h"
#define DRV_VERSION "0.19.3-k"
+#define DRV_SUMMARY "Intel(R) Ethernet Switch Host Interface Driver"
const char fm10k_driver_version[] = DRV_VERSION;
char fm10k_driver_name[] = "fm10k";
-static const char fm10k_driver_string[] =
- "Intel(R) Ethernet Switch Host Interface Driver";
+static const char fm10k_driver_string[] = DRV_SUMMARY;
static const char fm10k_copyright[] =
- "Copyright (c) 2013 Intel Corporation.";
+ "Copyright (c) 2013 - 2016 Intel Corporation.";
MODULE_AUTHOR("Intel Corporation, <linux.nics@intel.com>");
-MODULE_DESCRIPTION("Intel(R) Ethernet Switch Host Interface Driver");
+MODULE_DESCRIPTION(DRV_SUMMARY);
MODULE_LICENSE("GPL");
MODULE_VERSION(DRV_VERSION);
--
2.7.1.429.g45cd78e
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Intel-wired-lan] [PATCH v3] fm10k: remove duplication of the driver summary
2016-02-26 1:08 [Intel-wired-lan] [PATCH v3] fm10k: remove duplication of the driver summary Jacob Keller
@ 2016-02-26 1:22 ` Allan, Bruce W
2016-02-26 16:33 ` Keller, Jacob E
0 siblings, 1 reply; 3+ messages in thread
From: Allan, Bruce W @ 2016-02-26 1:22 UTC (permalink / raw)
To: intel-wired-lan
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Jacob Keller
> Sent: Thursday, February 25, 2016 5:08 PM
> To: Intel Wired LAN
> Subject: [Intel-wired-lan] [PATCH v3] fm10k: remove duplication of the
> driver summary
>
> Use DRV_SUMMARY, similar to DRV_VERSION so that we don't have
> duplicate
> copies of the summary left in the driver.
>
> Also update the file copyright string and the ethtool copyright string
What do you mean "the ethtool copyright string"? Typo?
> while we are here.
>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> ---
> drivers/net/ethernet/intel/fm10k/fm10k_main.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_main.c
> b/drivers/net/ethernet/intel/fm10k/fm10k_main.c
> index 3a81c1451624..98166e8b0789 100644
> --- a/drivers/net/ethernet/intel/fm10k/fm10k_main.c
> +++ b/drivers/net/ethernet/intel/fm10k/fm10k_main.c
> @@ -1,5 +1,5 @@
> /* Intel Ethernet Switch Host Interface Driver
> - * Copyright(c) 2013 - 2014 Intel Corporation.
> + * Copyright(c) 2013 - 2016 Intel Corporation.
> *
> * This program is free software; you can redistribute it and/or modify it
> * under the terms and conditions of the GNU General Public License,
> @@ -29,15 +29,15 @@
> #include "fm10k.h"
>
> #define DRV_VERSION "0.19.3-k"
> +#define DRV_SUMMARY "Intel(R) Ethernet Switch Host Interface
> Driver"
> const char fm10k_driver_version[] = DRV_VERSION;
> char fm10k_driver_name[] = "fm10k";
> -static const char fm10k_driver_string[] =
> - "Intel(R) Ethernet Switch Host Interface Driver";
> +static const char fm10k_driver_string[] = DRV_SUMMARY;
> static const char fm10k_copyright[] =
> - "Copyright (c) 2013 Intel Corporation.";
> + "Copyright (c) 2013 - 2016 Intel Corporation.";
>
> MODULE_AUTHOR("Intel Corporation, <linux.nics@intel.com>");
> -MODULE_DESCRIPTION("Intel(R) Ethernet Switch Host Interface Driver");
> +MODULE_DESCRIPTION(DRV_SUMMARY);
> MODULE_LICENSE("GPL");
> MODULE_VERSION(DRV_VERSION);
>
> --
> 2.7.1.429.g45cd78e
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at lists.osuosl.org
> http://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 3+ messages in thread* [Intel-wired-lan] [PATCH v3] fm10k: remove duplication of the driver summary
2016-02-26 1:22 ` Allan, Bruce W
@ 2016-02-26 16:33 ` Keller, Jacob E
0 siblings, 0 replies; 3+ messages in thread
From: Keller, Jacob E @ 2016-02-26 16:33 UTC (permalink / raw)
To: intel-wired-lan
On Fri, 2016-02-26 at 01:22 +0000, Allan, Bruce W wrote:
> >
> > -----Original Message-----
> > From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.
> > org] On
> > Behalf Of Jacob Keller
> > Sent: Thursday, February 25, 2016 5:08 PM
> > To: Intel Wired LAN
> > Subject: [Intel-wired-lan] [PATCH v3] fm10k: remove duplication of
> > the
> > driver summary
> >
> > Use DRV_SUMMARY, similar to DRV_VERSION so that we don't have
> > duplicate
> > copies of the summary left in the driver.
> >
> > Also update the file copyright string and the ethtool copyright
> > string
> What do you mean "the ethtool copyright string"???Typo?
>
Brain cramp. I meant the string we display in the module info, and for
some reason I went to the ethtool -i output, obviously incorrect. I can
fix that up.
Thanks,
Jake
> >
> > while we are here.
> >
> > Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> > ---
> > ?drivers/net/ethernet/intel/fm10k/fm10k_main.c | 10 +++++-----
> > ?1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_main.c
> > b/drivers/net/ethernet/intel/fm10k/fm10k_main.c
> > index 3a81c1451624..98166e8b0789 100644
> > --- a/drivers/net/ethernet/intel/fm10k/fm10k_main.c
> > +++ b/drivers/net/ethernet/intel/fm10k/fm10k_main.c
> > @@ -1,5 +1,5 @@
> > ?/* Intel Ethernet Switch Host Interface Driver
> > - * Copyright(c) 2013 - 2014 Intel Corporation.
> > + * Copyright(c) 2013 - 2016 Intel Corporation.
> > ? *
> > ? * This program is free software; you can redistribute it and/or
> > modify it
> > ? * under the terms and conditions of the GNU General Public
> > License,
> > @@ -29,15 +29,15 @@
> > ?#include "fm10k.h"
> >
> > ?#define DRV_VERSION "0.19.3-k"
> > +#define DRV_SUMMARY "Intel(R) Ethernet Switch Host
> > Interface
> > Driver"
> > ?const char fm10k_driver_version[] = DRV_VERSION;
> > ?char fm10k_driver_name[] = "fm10k";
> > -static const char fm10k_driver_string[] =
> > - "Intel(R) Ethernet Switch Host Interface Driver";
> > +static const char fm10k_driver_string[] = DRV_SUMMARY;
> > ?static const char fm10k_copyright[] =
> > - "Copyright (c) 2013 Intel Corporation.";
> > + "Copyright (c) 2013 - 2016 Intel Corporation.";
> >
> > ?MODULE_AUTHOR("Intel Corporation, <linux.nics@intel.com>");
> > -MODULE_DESCRIPTION("Intel(R) Ethernet Switch Host Interface
> > Driver");
> > +MODULE_DESCRIPTION(DRV_SUMMARY);
> > ?MODULE_LICENSE("GPL");
> > ?MODULE_VERSION(DRV_VERSION);
> >
> > --
> > 2.7.1.429.g45cd78e
> >
> > _______________________________________________
> > Intel-wired-lan mailing list
> > Intel-wired-lan at lists.osuosl.org
> > http://lists.osuosl.org/mailman/listinfo/intel-wired-lan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-26 16:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-26 1:08 [Intel-wired-lan] [PATCH v3] fm10k: remove duplication of the driver summary Jacob Keller
2016-02-26 1:22 ` Allan, Bruce W
2016-02-26 16:33 ` Keller, Jacob E
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.